Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 902739 - dtrace generates poor quality C code that provokes static analyzers
dtrace generates poor quality C code that provokes static analyzers
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: systemtap (Show other bugs)
6.4
Unspecified Unspecified
unspecified Severity unspecified
: rc
: ---
Assigned To: Frank Ch. Eigler
Martin Cermak
:
Depends On:
Blocks: 1013228
  Show dependency treegraph
 
Reported: 2013-01-22 06:22 EST by Kamil Dudka
Modified: 2013-11-21 06:45 EST (History)
4 users (show)

See Also:
Fixed In Version: systemtap-2.3-1.el6
Doc Type: Bug Fix
Doc Text:
Cause: Systemtap's 'dtrace' utility generates C code that could be improved. Consequence: When the generated code is compiled, gcc gives warning messages. Fix: Systemtap's dtrace utility generates more correct code. Result: When the generated code is compiled, gcc reports no warnings/errors.
Story Points: ---
Clone Of:
: 1013228 (view as bug list)
Environment:
Last Closed: 2013-11-21 06:45:42 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:1630 normal SHIPPED_LIVE systemtap bug fix and enhancement update 2013-11-20 16:53:53 EST

  None (edit)
Description Kamil Dudka 2013-01-22 06:22:37 EST
Description of problem:
We get defect reports like this from Coverity:

Error: MISSING_RETURN:
/tmp/tmpp5tUKb.c:1: missing_return: Arriving at the end of a function without returning a value.


Version-Release number of selected component (if applicable):
systemtap-1.8-7.el6


How reproducible:
easily


Steps to Reproduce:
1. printf "providers xxx { };\n" > xxx
2. dtrace -G -k -s xxx
3. gcc -c -Wall /tmp/tmpXXXXXX.c


Actual results:
$ printf "providers xxx { };" > xxx
$ dtrace -G -k -s xxx
header: /tmp/tmp_hnRff.h
source: /tmp/tmpXTWPUV.c

$ gcc -c -Wall /tmp/tmpXTWPUV.c
/tmp/tmpXTWPUV.c:1: warning: return type defaults to ‘int’
/tmp/tmpXTWPUV.c: In function ‘__dtrace’:
/tmp/tmpXTWPUV.c:1: warning: control reaches end of non-void function
/tmp/tmpXTWPUV.c: At top level:
/tmp/tmpXTWPUV.c:1: warning: ‘__dtrace’ defined but not used
Comment 1 Frank Ch. Eigler 2013-01-23 09:42:34 EST
Upstream commit 69607fc corrects this.
Comment 2 Kamil Dudka 2013-01-23 10:20:58 EST
Thanks for the quick response!
Comment 5 errata-xmlrpc 2013-11-21 06:45:42 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1630.html

Note You need to log in before you can comment on or make changes to this bug.