Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JMSParser.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JMSParser-1.0.0-1.fc18.src.rpm Description: Library for writing recursive-descent parsers. Fedora Account System Username: siwinski
LICENSE is Apache 2.0: OK. doc/LICENSE is BY-NC-ND (http://jmsyst.com/libs/parser-lib), this only apply to documentation (not provided in the rpm, but present in the src.rpm)... As BY-NC-ND is explicitly rejected for fedora https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3 you have to strip the doc folder from upstream tarball.
Spec changes: https://github.com/siwinski/rpms/commit/caed08c94a271da486aa21530fc29219ab0e6383 SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-JMSParser.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-JMSParser-1.0.0-2.fc18.src.rpm
Created attachment 712022 [details] phpci.log phpci version 2.14.0.
Created attachment 712023 [details] review.txt Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 903785
[!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Please provides php-JMSParser-strip.sh as Source1 As there are no Guildelines about this script, some packager are used to only add it in the fedora git repo. I prefer to have it in the .src.rpm. No blocker. == APPROVED ==
(In reply to comment #5) > [!]: SourceX tarball generation or download is documented. > Note: Package contains tarball without URL, check comments > > Please provides php-JMSParser-strip.sh as Source1 > > As there are no Guildelines about this script, some packager are used to > only add it in the fedora git repo. > > I prefer to have it in the .src.rpm. Shoot! I actually meant to do that. I will add that after initial import.
THANKS for the review! New Package SCM Request ======================= Package Name: php-JMSParser Short Description: Library for writing recursive-descent parsers Owners: siwinski Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
php-JMSParser-1.0.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-JMSParser-1.0.0-3.el6
php-JMSParser-1.0.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-JMSParser-1.0.0-3.fc18
php-JMSParser-1.0.0-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-JMSParser-1.0.0-3.fc18 has been pushed to the Fedora 18 stable repository.
php-JMSParser-1.0.0-3.el6 has been pushed to the Fedora EPEL 6 stable repository.