RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 905322 - "hivex-commit" should fail with a relative path
Summary: "hivex-commit" should fail with a relative path
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libguestfs
Version: 7.1
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 981683
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-29 07:26 UTC by bfan
Modified: 2014-06-18 01:58 UTC (History)
3 users (show)

Fixed In Version: libguestfs-1.22.2-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 905341 980372 (view as bug list)
Environment:
Last Closed: 2014-06-13 10:55:20 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description bfan 2013-01-29 07:26:08 UTC 
Description of problem:
Command "hivex-commit" need a absolute path as its parameter, it's different with "hivex-open" which just need a relative path.

"/WINDOWS/system32/config/software" is exist, and that folder is writable. it's like hivex-commit didn't correctly follow the link, its path is not start from "/sysroot/"  


Version-Release number of selected component (if applicable):
><fs> version
major: 1
minor: 20
release: 1
extra: rhel=7,release=6.el7,libvirt


How reproducible:
100%


Steps to Reproduce:
1. launch libguestfs with a windows guest
[root#] guestfish -a Win2003-32-hvm.raw
><fs> run
><fs> mount /dev/sda1 /

2. open a registry hive file with write model
><fs> hivex-open /WINDOWS/system32/config/software write:true

3. commit changes to the hive file with relative path, it's failed
><fs> hivex-commit /WINDOWS/system32/config/software
libguestfs: error: hivex_commit: failed: No such file or directory

4. commit changes to the hive file with absolute path, it's passed
><fs> hivex-commit /sysroot/WINDOWS/system32/config/software


Actual results:
hivex-commit with relatived path failed


Expected results:
hivex-commit with relatived path can pass


Additional info:
Comment 2 Richard W.M. Jones 2013-01-29 10:38:13 UTC 
Fixed upstream in:
https://github.com/libguestfs/libguestfs/commit/be4a3d77c42148731a977b68aab8b454372518d7
Comment 4 Lingfei Kong 2013-12-06 06:41:31 UTC 
Can verified with libguestfs-1.20.1-4.el7
Steps to verify:
1. Install libguestfs-1.20.1-4.el7 & libguestfs-winsupport-7.0-2.el7
2. #guestfish -a Win2008r2-64-hvm.raw
><fs> run
 100% [#################################################################################] 00:00
><fs> mount /dev/sda1 /
><fs> hivex-open  /Windows/System32/config/SOFTWARE write:true
><fs> hivex-commit  /Windows/System32/config/SOFTWARE           
libguestfs: error: hivex_commit: failed: No such file or directory
><fs> hivex-commit  /sysroot/Windows/System32/config/SOFTWARE 

Can not commit with a relative path.


--------------------------------------
Verified with libguestfs-1.22.6-15.el7

Steps to verify:
1. Install libguestfs-1.22.6-15.el7 & libguestfs-winsupport-7.0-2.el7

#guestfish  -a Win2008r2-64-hvm.raw
><fs> run
><fs> mount /dev/sda1 /
><fs> hivex-open  /Windows/System32/config/SOFTWARE write:true
><fs> hivex-commit /Windows/System32/config/SOFTWARE

Can commit with a relative path. 

Additional information:
><fs> hivex-open  /sysroot//Windows/System32/config/SOFTWARE write:true
libguestfs: error: hivex_open: hivex failed to open /sysroot//Windows/System32/config/SOFTWARE: No such file or directory
><fs> hivex-open  /sysroot/Windows/System32/config/SOFTWARE write:true
libguestfs: error: hivex_open: hivex failed to open /sysroot/Windows/System32/config/SOFTWARE: No such file or directory
Comment 5 Ludek Smid 2014-06-13 10:55:20 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.