Bug 981683 - "hivex-commit" should fail with a relative path
Summary: "hivex-commit" should fail with a relative path
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 905322 980372
TreeView+ depends on / blocked
 
Reported: 2013-07-05 13:17 UTC by Richard W.M. Jones
Modified: 2013-07-05 14:09 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 980372
Environment:
Last Closed: 2013-07-05 14:09:05 UTC


Attachments (Terms of Use)

Description Richard W.M. Jones 2013-07-05 13:17:28 UTC
+++ This bug was initially created as a clone of Bug #980372 +++

+++ This bug was initially created as a clone of Bug #905322 +++

Test script.  You will need 'minimal' from
https://github.com/libguestfs/hivex/blob/master/images/minimal
and note that you have to uncomment only *one* of the three hivex-commit
lines in the script.

guestfish -x -N fs -m /dev/sda1 <<EOF
upload /mnt/scratch/minimal /minimal
hivex-open /minimal write:true
#hivex-commit ""
#hivex-commit "/minimal"
hivex-commit "minimal"
EOF

The first case (NULL) should always succeed and it does.

The second case (absolute path "/minimal") should succeed
and it does.

The third case (relative path "minimal") should fail because
relative paths shouldn't be allowed.  It doesn't fail, so that is
a bug.

Tested on libguestfs-1.23.7-1.fc20.x86_64


Note You need to log in before you can comment on or make changes to this bug.