Red Hat Bugzilla – Bug 906924
[patch] Backport support correct cookie handling
Last modified: 2013-02-16 22:32:07 EST
Created attachment 691772 [details]
Handle cookies correctly
We found a weird corner case in python-requests-0.14.1 in the way that it handles cookies. It is discussed here: https://github.com/fedora-infra/python-fedora/pull/6
Fixing it ended up requiring a patch that I have added to python-requests-0.14.1-3.el6. This is a request to merge that patch back into rawhide and f18.
The patch is attached. A simple "git merge" from el6 into the master and f18 branches should do it.
One note -- the patch is not quite a backport. The python-requests-1.0.0 release doesn't have this problem but 1.0.0 was a huge restructuring of code. So this was fix doesn't have an analogoue in the upstream 1.0.0 tree.
*** Bug 909296 has been marked as a duplicate of this bug. ***
Arun, mind if I apply the patch and rebuild? The broken behavior was noticed by someone running fedora-easy-karma today.
Sure, Not a problem. Go ahead!
I got carried away a little bit. Made a few changes above and beyond what we talked about here. I'll upload the patch and then build it if either one of you okay it.
Created attachment 695229 [details]
Changes to the spec file
This fixes the cookie handling, fixes the certificate bundle in https://bugzilla.redhat.com/show_bug.cgi?id=904614 , and removes the py-3 specific and py2-specific modules in the packages where they won't run (chardet is not in python-requests and chardet2, oauthlib is removed from python3-requests) so that we can use the generic fedora python byte compilation.
Created attachment 695230 [details]
Patch to enable the system cert bundle
+1 to the patches. Thanks for all your work on this Toshio!
python-fedora-0.3.32.3-1.fc18, python-requests-0.14.1-4.fc18 has been submitted as an update for Fedora 18.
*** Bug 909444 has been marked as a duplicate of this bug. ***
Package python-fedora-0.3.32.3-1.fc18, python-requests-0.14.1-4.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-fedora-0.3.32.3-1.fc18 python-requests-0.14.1-4.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
python-fedora-0.3.32.3-1.fc18, python-requests-0.14.1-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.