Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/nodejs-jasmine-node.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/nodejs-jasmine-node-1.2.3-1.fc18.src.rpm Fedora Account System Username: jamielinux Description: DOM-less JavaScript behaviour-driven development (BDD) testing framework for Node.
Amend typo in the summary. Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/nodejs-jasmine-node.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/nodejs-jasmine-node-1.2.3-2.fc18.src.rpm
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains no bundled libraries without FPC exception. lib/jasmine-node/cs.js is taken from http://github.com/jrburke/require-cs lib/jasmine-node/jasmine-1.3.1.js is a bundled copy of jasmine - Package is named according to the Package Naming Guidelines. This one should probably drop the nodejs prefix - Requires correct, justified where necessary. It seems to be generating requires on nodejs(abi) and nodejs(v8-abi) for some reason, but only binary modules should need those. - Latest version is packaged. Version 1.4.0 is now available. - Rpmlint is run on all installed packages. nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/index.js nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/reporter.js nodejs-jasmine-node.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-jasmine-node-1.2.3/LICENSE nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/cli.js nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/package.json nodejs-jasmine-node.noarch: W: no-manual-page-for-binary jasmine-node ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/tom/912104-nodejs-jasmine-node/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-jasmine-node-1.2.3-2.fc20.noarch.rpm nodejs-jasmine-node.noarch: W: only-non-binary-in-usr-lib nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/coffee-script /usr/lib/node_modules/coffee-script nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/walkdir /usr/lib/node_modules/walkdir nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/index.js nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/requirejs /usr/lib/node_modules/requirejs nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/gaze /usr/lib/node_modules/gaze nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/reporter.js nodejs-jasmine-node.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-jasmine-node-1.2.3/LICENSE nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/cli.js nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/jasmine-reporters /usr/lib/node_modules/jasmine-reporters nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/package.json nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/underscore /usr/lib/node_modules/underscore nodejs-jasmine-node.noarch: W: no-manual-page-for-binary jasmine-node 1 packages and 0 specfiles checked; 4 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-jasmine-node nodejs-jasmine-node.noarch: W: only-non-binary-in-usr-lib nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/coffee-script /usr/lib/node_modules/coffee-script nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/walkdir /usr/lib/node_modules/walkdir nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/index.js nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/requirejs /usr/lib/node_modules/requirejs nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/gaze /usr/lib/node_modules/gaze nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/reporter.js nodejs-jasmine-node.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-jasmine-node-1.2.3/LICENSE nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/lib/jasmine-node/cli.js nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/jasmine-reporters /usr/lib/node_modules/jasmine-reporters nodejs-jasmine-node.noarch: E: script-without-shebang /usr/lib/node_modules/jasmine-node/package.json nodejs-jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/underscore /usr/lib/node_modules/underscore nodejs-jasmine-node.noarch: W: no-manual-page-for-binary jasmine-node 1 packages and 0 specfiles checked; 4 errors, 9 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-jasmine-node (rpmlib, GLIBC filtered): /usr/bin/env nodejs(abi) nodejs(engine) nodejs(v8-abi) npm(coffee-script) npm(gaze) npm(jasmine-reporters) npm(requirejs) npm(underscore) npm(walkdir) Provides -------- nodejs-jasmine-node: nodejs-jasmine-node npm(jasmine-node) MD5-sum check ------------- http://registry.npmjs.org/jasmine-node/-/jasmine-node-1.2.3.tgz : CHECKSUM(SHA256) this package : 9ef09d077934f3db9722a9ff518991469243663be217d03a47f6b5ced87064c4 CHECKSUM(SHA256) upstream package : 9ef09d077934f3db9722a9ff518991469243663be217d03a47f6b5ced87064c4 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 912104
Actually the abi requires are probably triggered by the executable js files, which is also the cause the missing shebang warnings from rpmlint.
Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/jasmine-node.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/jasmine-node-1.4.0-1.fc18.src.rpm * Sun Mar 17 2013 Jamie Nguyen <jamielinux> - 1.4.0-1 - update to upstream release 1.4.0 - rename from nodejs-jasmine-node to just jasmine-node - remove bundled cs.js and jasmine.js and replace with symlinks to system versions - lots of files are executable but shouldn't be, so chmod 0644 all of them - add a custom man page
Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/jasmine-node.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/jasmine-node-1.4.0-2.fc18.src.rpm Amend path to jasmine.js.
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Requires correct, justified where necessary. I'm still seeing requires on nodejs(abi) and nodejs(v8-abi) for some reason... - %check is present and all tests pass. Tests fail to fun as specs.sh is not executable and if that is fixed then they fail due to the unbundled files not being available. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/tom/912104-jasmine-node/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Note: Incorrect Requires : /usr/lib/node_modules/require-cs/cs.js, /usr/share/jasmine/jasmine.js [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [=]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jasmine-node-1.4.0-2.fc20.noarch.rpm jasmine-node.noarch: W: only-non-binary-in-usr-lib jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/coffee-script /usr/lib/node_modules/coffee-script jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/walkdir /usr/lib/node_modules/walkdir jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/requirejs /usr/lib/node_modules/requirejs jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/gaze /usr/lib/node_modules/gaze jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/jasmine-reporters /usr/lib/node_modules/jasmine-reporters jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/underscore /usr/lib/node_modules/underscore 1 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint jasmine-node jasmine-node.noarch: W: only-non-binary-in-usr-lib jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/coffee-script /usr/lib/node_modules/coffee-script jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/walkdir /usr/lib/node_modules/walkdir jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/requirejs /usr/lib/node_modules/requirejs jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/gaze /usr/lib/node_modules/gaze jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/jasmine-reporters /usr/lib/node_modules/jasmine-reporters jasmine-node.noarch: W: dangling-symlink /usr/lib/node_modules/jasmine-node/node_modules/underscore /usr/lib/node_modules/underscore 1 packages and 0 specfiles checked; 0 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- jasmine-node (rpmlib, GLIBC filtered): /usr/bin/env /usr/lib/node_modules/require-cs/cs.js /usr/share/jasmine/jasmine.js nodejs(abi) nodejs(engine) nodejs(v8-abi) npm(coffee-script) npm(gaze) npm(jasmine-reporters) npm(requirejs) npm(underscore) npm(walkdir) Provides -------- jasmine-node: jasmine-node npm(jasmine-node) MD5-sum check ------------- http://registry.npmjs.org/jasmine-node/-/jasmine-node-1.4.0.tgz : CHECKSUM(SHA256) this package : 54b5401091421b7ec4fe160f54f8f5517426fbefd2c3f75a0f2ef5e827ba65dd CHECKSUM(SHA256) upstream package : 54b5401091421b7ec4fe160f54f8f5517426fbefd2c3f75a0f2ef5e827ba65dd Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 912104
The abi requires thing is a bug in the nodejs package... Opened https://bugzilla.redhat.com/show_bug.cgi?id=923941 about it.
Nice work finding the bug! :) Fixed the tests. Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/jasmine-node.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/jasmine-node-1.4.0-3.fc18.src.rpm
Great. Looks good now, so package is approved.
New Package SCM Request ======================= Package Name: jasmine-node Short Description: DOM-less JavaScript behavior-driven development (BDD) testing framework for Node Owners: jamielinux Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
jasmine-node-1.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jasmine-node-1.4.0-3.fc18
jasmine-node-1.4.0-3.fc18 has been pushed to the Fedora 18 stable repository.
jasmine-node-1.7.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/jasmine-node-1.7.1-1.el6
jasmine-node-1.7.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.