Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/nodejs-require-cs.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/nodejs-require-cs-0.4.3-1.fc18.src.rpm Fedora Account System Username: jamielinux Description: A CoffeeScript loader plugin that may work with module loaders like RequireJS, curl and backdraft. This loader plugin makes it easy to write your JS functionality in CoffeeScript, and easily use it in the browser, Node or Rhino. Plus, if you use the RequireJS optimizer, your CoffeeScript files can be translated to JavaScript and in-lined into optimized layers for fast performance.
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - License file required We need to add a copy of the license until upstream provides it. - Patches link to upstream bugs/comments/lists or are otherwise justified. Maybe worth suggesting to upstream that they register with the registry to avoid the risk of future name conflicts? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/tom/922502-nodejs-require-cs/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 112640 bytes in 12 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [!]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Note: Incorrect Requires : /usr/lib/node_modules/requirejs/bin/r.js, /usr/share/coffee-script/extras/coffee-script.js [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-require-cs-0.4.3-1.fc20.noarch.rpm nodejs-require-cs.noarch: W: spelling-error %description -l en_US backdraft -> back draft, back-draft, backtrack nodejs-require-cs.noarch: W: only-non-binary-in-usr-lib nodejs-require-cs.noarch: W: dangling-symlink /usr/lib/node_modules/require-cs/node_modules/coffee-script /usr/lib/node_modules/coffee-script 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-require-cs nodejs-require-cs.noarch: W: spelling-error %description -l en_US backdraft -> back draft, back-draft, backtrack nodejs-require-cs.noarch: W: only-non-binary-in-usr-lib nodejs-require-cs.noarch: W: dangling-symlink /usr/lib/node_modules/require-cs/node_modules/coffee-script /usr/lib/node_modules/coffee-script 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-require-cs (rpmlib, GLIBC filtered): /bin/sh /usr/lib/node_modules/requirejs/bin/r.js /usr/share/coffee-script/extras/coffee-script.js nodejs(engine) npm(coffee-script) Provides -------- nodejs-require-cs: nodejs-require-cs npm(require-cs) MD5-sum check ------------- https://github.com/jrburke/require-cs/archive/0.4.3.tar.gz : CHECKSUM(SHA256) this package : a190419a1a37a39d39136a6f855c6cc2c9c5ebad3df3ff9e742354ec87e9d67b CHECKSUM(SHA256) upstream package : a190419a1a37a39d39136a6f855c6cc2c9c5ebad3df3ff9e742354ec87e9d67b Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 922502
Spec URL: http://jamielinux.fedorapeople.org/jasmine-node/nodejs-require-cs.spec SRPM URL: http://jamielinux.fedorapeople.org/jasmine-node/SRPMS/nodejs-require-cs-0.4.3-2.fc18.src.rpm > License file required > > We need to add a copy of the license until upstream provides it. Done. > Maybe worth suggesting to upstream that they register with the > registry to avoid the risk of future name conflicts? Sure, will open an issue upstream.
You don't seem to have uploaded the new spec and srpm?
Oh sorry, done.
Great. Package approved.
New Package SCM Request ======================= Package Name: nodejs-require-cs Short Description: An AMD loader plugin for CoffeeScript Owners: jamielinux Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
nodejs-require-cs-0.4.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-require-cs-0.4.3-2.fc18
nodejs-require-cs-0.4.3-2.fc18 has been pushed to the Fedora 18 stable repository.