Bug 912426 - engine-upgrade fails checking running task on non english systems
Summary: engine-upgrade fails checking running task on non english systems
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-installer
Version: 3.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.3
Assignee: Sandro Bonazzola
QA Contact:
URL:
Whiteboard: integration
Depends On:
Blocks: 920501
TreeView+ depends on / blocked
 
Reported: 2013-02-18 16:11 UTC by Sandro Bonazzola
Modified: 2013-09-23 07:36 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
: 920501 (view as bug list)
Environment:
Last Closed: 2013-09-23 07:36:03 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 12220 0 None None None Never
oVirt gerrit 12227 0 None None None Never
oVirt gerrit 13131 0 None None None Never

Description Sandro Bonazzola 2013-02-18 16:11:35 UTC
Description of problem:
running engine-upgrade from 3.2 to 3.3 nightly with italian locale fails while checking running tasks.

Version-Release number of selected component (if applicable):
ovirt-engine-setup-3.3.0-0.1.20130217110611.20130217.gite03d604.fc18.noarch

How reproducible:
Always reproducible

Steps to Reproduce:
1. set locale to italian (it-IT.utf-8)
2. install ovirt-engine from stable repository
3. enable nightly repository
4. upgrade ovirt-engine-setup
5. run engine-upgrade
  
Actual results:
engine-upgrade wait for compensation that doesn't exists

Expected results:
engine-upgrade correctly detect that there aren't compensations

Additional info:

The error is caused by the parsing of psql command in engine-upgrade getCompensations: it search for "0 rows" and it is "0 righe" in italian.

psql should be run with LC_ALL=C or the parser has to be rewritten.

Comment 1 Sandro Bonazzola 2013-02-20 09:39:28 UTC
Talking with Juan Hernandez, it seems that the best solution is run psql with LC_ALL=C and rewrite the parser since searching for 0 rows match also "10 rows".

Comment 2 Sandro Bonazzola 2013-02-21 14:34:21 UTC
patch 12220 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=a5bc44f6bc4c6f138b5398b026af62cc34d00ea4

Comment 3 Sandro Bonazzola 2013-02-25 08:39:58 UTC
patch 12227 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=f4da1607762ccece3eddebf1b68d00afa3115a0d

Comment 4 Sandro Bonazzola 2013-03-19 12:46:54 UTC
better solution for patch 12220 pushed for review at http://gerrit.ovirt.org/13162 . It seems there is a problem adding the reference to the external tracker field.

Comment 5 Sandro Bonazzola 2013-03-20 07:31:29 UTC
http://gerrit.ovirt.org/13162 abandoned in favor of http://gerrit.ovirt.org/13131

Comment 6 Itamar Heim 2013-08-21 16:42:59 UTC
as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)

Comment 7 Itamar Heim 2013-09-23 07:36:03 UTC
closing as this should be in 3.3 (doing so in bulk, so may be incorrect)


Note You need to log in before you can comment on or make changes to this bug.