Bug 920501 - engine-upgrade fails checking running task on non english systems
Summary: engine-upgrade fails checking running task on non english systems
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-setup
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: 3.2.0
Assignee: Sandro Bonazzola
QA Contact: movciari
URL:
Whiteboard: integration
Depends On: 912426
Blocks: 948448
TreeView+ depends on / blocked
 
Reported: 2013-03-12 09:34 UTC by Sandro Bonazzola
Modified: 2015-09-22 13:09 UTC (History)
11 users (show)

Fixed In Version: sf12
Doc Type: Bug Fix
Doc Text:
Clone Of: 912426
Environment:
Last Closed:
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 12220 0 None None None Never
oVirt gerrit 12227 0 None None None Never

Description Sandro Bonazzola 2013-03-12 09:34:03 UTC
+++ This bug was initially created as a clone of Bug #912426 +++

Description of problem:
running engine-upgrade from 3.2 to 3.3 nightly with italian locale fails while checking running tasks.

Version-Release number of selected component (if applicable):
ovirt-engine-setup-3.3.0-0.1.20130217110611.20130217.gite03d604.fc18.noarch

How reproducible:
Always reproducible

Steps to Reproduce:
1. set locale to italian (it-IT.utf-8)
2. install ovirt-engine from stable repository
3. enable nightly repository
4. upgrade ovirt-engine-setup
5. run engine-upgrade
  
Actual results:
engine-upgrade wait for compensation that doesn't exists

Expected results:
engine-upgrade correctly detect that there aren't compensations

Additional info:

The error is caused by the parsing of psql command in engine-upgrade getCompensations: it search for "0 rows" and it is "0 righe" in italian.

psql should be run with LC_ALL=C or the parser has to be rewritten.

--- Additional comment from Sandro Bonazzola on 2013-02-20 04:39:28 EST ---

Talking with Juan Hernandez, it seems that the best solution is run psql with LC_ALL=C and rewrite the parser since searching for 0 rows match also "10 rows".

--- Additional comment from Sandro Bonazzola on 2013-02-21 09:34:21 EST ---

patch 12220 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=a5bc44f6bc4c6f138b5398b026af62cc34d00ea4

--- Additional comment from Sandro Bonazzola on 2013-02-25 03:39:58 EST ---

patch 12227 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=f4da1607762ccece3eddebf1b68d00afa3115a0d

Comment 1 Sandro Bonazzola 2013-03-20 07:34:21 UTC
http://gerrit.ovirt.org/13131 will be used instead of http://gerrit.ovirt.org/12220

Comment 2 Sandro Bonazzola 2013-03-20 08:21:21 UTC
patch 7170 abandoned in favor of patch 7217.

Comment 3 Sandro Bonazzola 2013-03-21 07:25:45 UTC
patch 13131 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=9d1a0ae62da705e63484b50fdde724f63563c23f

Comment 4 Itamar Heim 2013-06-11 09:26:38 UTC
3.2 has been released

Comment 5 Itamar Heim 2013-06-11 09:30:52 UTC
3.2 has been released

Comment 6 Itamar Heim 2013-06-11 09:46:28 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.