Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-2.fc18.src.rpm Koji build --scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=5038720 Description: Advanced color picker written in C++ using GTK+ toolkit Fedora Account System Username: luya
*** Bug 853775 has been marked as a duplicate of this bug. ***
Package seems clear. I get it on review swaping with next qt-based applications: https://bugzilla.redhat.com/show_bug.cgi?id=929425 - advanced plain text editor https://bugzilla.redhat.com/show_bug.cgi?id=947049 - keyboard layout switcher https://bugzilla.redhat.com/show_bug.cgi?id=949154 - clipboard history manager
Thank you, I will do the same for one of listed package.
BUGS: * %description: Description is smaller then Summary. * %post, %postun: "/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :" is hack. Add hicolor-icon-theme to BuildRequires and Requires. * %files: As Fedora puts documents into %{_docdir}/%{name}-%{version} - replace current %doc expression with "share/doc/gpick/copyright" (patching SConstruct befor, naturally). Issues (not blockers): * Separate expressions inside sections something different then sections between each other. E.g. - double CR between sections and one CR between expression. Or one CR and no CR respectively. * You can replace BRs with "rpmname-independent" expressions: dbus-glib-devel => pkgconfig(dbus-glib-1) gtk2-devel => pkgconfig(gtk+-2.0) lua-devel => pkgconfig(lua) expat-devel => pkgconfig(expat) * You can replace "export ... scons..." with one line: "scons ... CFLAGS=... CXXFLAGS=..." * You can replace %{_usr} with %{_prefix} Questions: * Why lemon is needed? I created package without it.
Re comment #4 the BUGS: suggestion about icon-related %post,%postun scriptlets is invalid, please see: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache (in particular, the scriptlet's here are valid, and adding an extra Requires: hicolor-icon-theme is not, since gtk2 already pulls that in) While we're on non-blocker topics: my own pet-peave... I'd suggest removing from Summary/description the text "written in C++ using GTK+ toolkit". End users don't need to know or care what language or toolkit is used.
Here is the updated spec and srpms including a short summary and description Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-3.fc18.src.rpm Koji build --scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=5249406 Upstream has released a newest version but I will update the package when it will be available to the repository.
Greate. Everything clear but... To Rex Dieter: I can't find in guidelines - whether "%doc %{_docdir}/%{name}/copyright" is accaptable?
(In reply to comment #5) > End users don't need to know or care what language or toolkit is used. I agree with removeing language, but not - with GTK. User can want to know - how application look like. As for me - I prefere qt-based or kde-based - due gtk look'n'feel. This is an example - nothing personal :-)
(In reply to comment #6) > Here is the updated spec and srpms including a short summary and description > Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec > SRPM URL: > http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-3.fc18.src.rpm Something wrong: bash-4.2$ fedora-review -b 913367 INFO: Processing bugzilla bug: 913367 INFO: Getting .spec and .srpm Urls from : 913367 INFO: --> SRPM url: http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-3.fc18.src.rpm INFO: --> Spec url: http://luya.fedorapeople.org/packages/SPECS/gpick.spec INFO: Downloading .spec and .srpm files ERROR: 'Error 404 downloading http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-3.fc18.src.rpm'
The .srpm is locatd on other path. Here is the correct address Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec SRPM URL: http://luya.fedorapeople.org/packages/gpick-0.2.4-3.fc18.src.rpm I am currently on a place with unstable network.
(In reply to comment #10) > The .srpm is locatd on other path. Here is the correct address > Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec > SRPM URL: http://luya.fedorapeople.org/packages/gpick-0.2.4-3.fc18.src.rpm > > I am currently on a place with unstable network. Disregard above post, I fixed the correct location of srpm files on SRPM url: http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-3.fc18.src.rpm Could you try again?
Ooops... Seems expat-devel in F17 has no pkg-config file: http://kojipkgs.fedoraproject.org//work/tasks/2410/5252410/mock_output.log I'm sorry.
Here is these updated files Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-3.fc18.src.rpm Koji build of f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5254527 Koji build for f17 (with expat-devel): http://koji.fedoraproject.org/koji/taskinfo?taskID=5254552 Once accepted, f18+ version will use pkg-config.
gpick.spec contains Relese: 4, but srpm is ...-3. fedora-package produces error
I forgot to change the srpm because release 4 is already published. Spec URL: http://luya.fedorapeople.org/packages/SPECS/gpick.spec SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/gpick-0.2.4-4.fc18.src.rpm
Be attentive: http://luya.fedorapeople.org/packages/SRPMS/ There is no -4.fc18 As I get - fedora-package gets last Spec URL and SRPM URL in bug thread.
(In reply to comment #16) > Be attentive: http://luya.fedorapeople.org/packages/SRPMS/ > There is no -4.fc18 It is now uploaded.
During reviewing: "[ ]: Latest version is packaged." http://code.google.com/p/gpick/downloads/list - latest is 0.2.5 but 0.2.4 packaged.
I am aware of it but the review was submitted before 0.2.5 was released.
In addition, 0.2.5 requires lua >= 5.2 which is not available on Fedora 18.
Package Review ============== ===== MUST items ===== OK ===== SHOULD items ===== * Latest version is packaged. * Patches link to upstream bugs/comments/lists or are otherwise justified. * Packages should try to preserve timestamps of original installed files. Rpmlint ------- OK but source n/a MD5-sum check ------------- N/a because of source N/A APPROVED
Weird. Bugzilla somehow changed fedora-review+ to luya fedora-review? which requesting fedora-cvs? . Is it some kind of bug?
No SCM request found, un-setting fedora-cvs.
New Package SCM Request ======================= Package Name: gpick Short Description: Advanced color picker Owners: luya Branches: f19 f18 f17 el6 InitialCC: luya
Git done (by process-git-requests).
gpick-0.2.4-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gpick-0.2.4-4.fc18
gpick-0.2.4-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gpick-0.2.4-4.fc19
gpick-0.2.4-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gpick-0.2.4-4.el6
gpick-0.2.4-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gpick-0.2.4-4.fc17
gpick-0.2.4-4.fc17 has been pushed to the Fedora 17 testing repository.
gpick-0.2.4-4.fc19 has been pushed to the Fedora 19 stable repository.