Spec URL: http://tieugene.fedorapeople.org/rpms/qlipper/qlipper.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/qlipper/qlipper-2.0.1-1.fc17.src.rpm Description: Lightweight and cross-platform clipboard history applet. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5220472 http://koji.fedoraproject.org/koji/taskinfo?taskID=5220480 http://koji.fedoraproject.org/koji/taskinfo?taskID=5220483 rpmlint: bash-4.2$ rpmlint rpmbuild/SPECS/qlipper.spec /mnt/shares/home/eugene/rpmbuild/SRPMS/qlipper-2.0.1-1.fc17.src.rpm /mnt/shares/home/eugene/rpmbuild/RPMS/i686/qlipper-2.0.1-1.fc17.i686.rpm rpmbuild/SPECS/qlipper.spec: W: invalid-url Source0: http://qlipper.googlecode.com/files/qlipper-2.0.1.tar.bz2 HTTP Error 404: Not Found qlipper.src: W: invalid-url Source0: http://qlipper.googlecode.com/files/qlipper-2.0.1.tar.bz2 HTTP Error 404: Not Found qlipper.i686: W: no-manual-page-for-binary qlipper 2 packages and 1 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: tieugene
I can review... 1. MUST fix license, recommend using: License: GPLv3+ since it's a mixture of BSD and GPLv2+ and GPLv3+ $ licensecheck -r * build/CMakeFiles/2.8.10.2/CompilerIdC/CMakeCCompilerId.c: *No copyright* UNKNOWN macosx/strip_bundle.sh: *No copyright* UNKNOWN qkeysequencewidget/qkeysequencewidget.h: BSD (3 clause) qkeysequencewidget/qkeysequencewidget.cpp: BSD (3 clause) qkeysequencewidget/qkeysequencewidget_p.h: BSD (3 clause) qmenuview/qmenuview_p.h: GPL (v3 or later) qmenuview/qmenuview.h: GPL (v3 or later) qmenuview/qmenuview.cpp: GPL (v3 or later) src/qlippertypes.h: *No copyright* UNKNOWN src/qlipperpreferencesdialog.h: GPL src/qlipperpreferences.h: GPL src/qlippernetwork.cpp: GPL src/qlipperpreferences.cpp: GPL src/qlippermodel.h: GPL src/qlippermodel.cpp: GPL src/qlipperitem.h: GPL src/qlippernetwork.h: GPL src/qlippermenuview.cpp: GPL src/qlippermenuview.h: GPL src/config.h: GPL src/main.cpp: GPL src/qlipperpreferencesdialog.cpp: GPL src/qlippersystray.cpp: GPL src/qlipperitem.cpp: GPL src/qlippersystray.h: GPL sources: ok e5e256de9b8ea07e237bde9b8e3ceb75 qlipper-2.0.1.tar.bz2 2. SHOULD drop from %build: -DCMAKE_INSTALL_PREFIX=/usr this is redundant and already included in %cmake macro macros: ok builds/installs: ok scriptlets: n/a (none) 3. SHOULD drop "and cross-platform" from %description, it doesn't add any value, imo the rest is a fairly simple package, I see no other issues.
(In reply to comment #1) > 1. MUST fix license, recommend using: > License: GPLv3+ > > since it's a mixture of BSD and GPLv2+ and GPLv3+ But COPYING in the root is about GPLv2 (GPLv3 code is copy-pasted from other project). Whether License tag will not conflict with COPYING?
That's upstream's job to fix (they should be shipping a GPLv3 COPYING, not a GPLv2 one), not ours. Please report it to them. In the meantime, ship the COPYING upstream ships.
(In reply to comment #1) > I can review... Thank you. > 1. MUST fix license, recommend using: > License: GPLv3+ Fixed. Upstream bugreport: http://code.google.com/p/qlipper/issues/detail?id=15 > 2. SHOULD drop from %build: > -DCMAKE_INSTALL_PREFIX=/usr Fixed. > 3. SHOULD drop "and cross-platform" from %description, it doesn't add any value, imo Fixed. Spec URL: http://tieugene.fedorapeople.org/rpms/qlipper/qlipper.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/qlipper/qlipper-2.0.1-2.fc18.src.rpm
Thanks, APPROVED
New Package SCM Request ======================= Package Name: qlipper Short Description: Lightweight clipboard history Owners: tieugene Branches: f17 f18 f19 InitialCC: Note: qlipper can be packaged for EL6 too (https://build.opensuse.org/package/show?package=qlipper&project=X11%3AQtDesktop) - but using built-in qxt and qtsingleapplication sources.
oops... browser error
Git done (by process-git-requests).
qlipper-2.0.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qlipper-2.0.1-2.fc19
qlipper-2.0.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/qlipper-2.0.1-2.fc18
qlipper-2.0.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/qlipper-2.0.1-2.fc17
qlipper-2.0.1-2.fc19 has been pushed to the Fedora 19 testing repository.
qlipper-2.0.1-2.fc19 has been pushed to the Fedora 19 stable repository.
qlipper-2.0.1-2.fc17 has been pushed to the Fedora 17 stable repository.
qlipper-2.0.1-2.fc18 has been pushed to the Fedora 18 stable repository.