Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.1-1.fc18.src.rpm Description: Qt5 - QtWebKit components Fedora Account System Username: rdieter
Missing BuildReq: mesa-libGL-devel Please check: qt5-qtwebkit-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/qtwebkit-opensource-src-5.0.1/Source/WTF/wtf/MediaTime.h qt5-qtwebkit-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtwebkit-opensource-src-5.0.1/Source/WTF/.moc qt5-qtwebkit-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtwebkit-opensource-src-5.0.1/Source/WTF/.moc SHOULD: This doesn't look very nice. Something we can do about it? qt5-qtwebkit.x86_64: W: shared-lib-calls-exit /usr/lib64/libQt5WebKit.so.5.0.1 exit.5 qt5-qtwebkit.x86_64: W: shared-lib-calls-exit /usr/lib64/libQt5WebKit.so.5.0.1 _exit.5
1. Missing BuildReq: mesa-libGL-devel as mentioned in the qttools review, I'll be adding this as a dep to qt5-qtbase-devel soon
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.1-2.fc18.src.rpm %changelog * Mon Feb 25 2013 Rex Dieter <rdieter> 5.0.1-2 - .prl love - BR: pkgconfig(gl)
As with qt5-qttools I'm getting an «Project ERROR: Module does not define version.» error when building (using mock here). Just reporting.
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.2-1.fc18.src.rpm %changelog * Thu Apr 11 2013 Rex Dieter <rdieter> 5.0.2-1 - 5.0.2 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5243996
doesn't build on rawhide. I get a build log of 65 mb containing messages like this: generated/InspectorTypeBuilder.h:3180:25: warning: typedef 'dummycannot_cast' locally defined but not used [-Wunused-local-typedefs] COMPILE_ASSERT(sizeof(Error) == sizeof(InspectorObject), cannot_cast); There is also this configure warning: Encountered 1 configuration warning(s): ! QtQuick module not found, QML APIs will not be built I suppose we don't want to waive on any of them.
oh wait, I think my build run out of space. Need to try later again...
(In reply to comment #6) > There is also this configure warning: Encountered 1 configuration warning(s): > ! QtQuick module not found, QML APIs will not be built Oh yes, adding qtdeclarative to buildreq did the trick, though I'm getting unpackaged file errors now ;) DEBUG: error: Installed (but unpackaged) file(s) found: DEBUG: /usr/lib64/qt5/qml/QtWebKit/experimental/libqmlwebkitexperimentalplugin.so DEBUG: /usr/lib64/qt5/qml/QtWebKit/experimental/qmldir DEBUG: /usr/lib64/qt5/qml/QtWebKit/libqmlwebkitplugin.so DEBUG: /usr/lib64/qt5/qml/QtWebKit/qmldir DEBUG: Installed (but unpackaged) file(s) found: DEBUG: /usr/lib64/qt5/qml/QtWebKit/experimental/libqmlwebkitexperimentalplugin.so DEBUG: /usr/lib64/qt5/qml/QtWebKit/experimental/qmldir DEBUG: /usr/lib64/qt5/qml/QtWebKit/libqmlwebkitplugin.so DEBUG: /usr/lib64/qt5/qml/QtWebKit/qmldir
Good catch, I'll add the optional builddep and feature in the next pkg iteration. In the meantime, I'd prefer if we could focus on review blockers... ;)
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.2-2.fc18.src.rpm %changelog * Fri Apr 12 2013 Rex Dieter <rdieter> 5.0.2-2 - BR: qt5-qtdeclarative-devel Can no longer do a scratch build, due to qt5-qtdeclarative not being available yet.
Created attachment 737531 [details] compact licensecheck issues: - this project contains multiple licenses (see check), also include the license files, if available, in doc - many subdirectories below Source/ contain licenses and changelogs, I'm sure they could be of interest also there is some heavy bundling taking place: Source/ThirdParty bundles - surprise - quite a lot of third party libs that are actively used during build. - ANGLE: fedora pkg 'mingw64-angleproject' - glu: has been adjusted by webkit team, probably copylib - gtest: we don't run tests, so.... - gyp: fedora pkg 'node-gyp' - jquery/qunit: probably can ignore this too This needs to be investigated.
Of those, it would appear that only ThirdParty/ANGLE is actively used during the build. Taking a closer look now.
As far as licensing is concerned, upstream intentions here is clear: http://qt-project.org/doc/qt-5.0/qtdoc/licensing.html
and, pretty sure we don't need angle. per https://code.google.com/p/angleproject/ The goal of ANGLE is to allow Windows users to seamlessly run WebGL and other OpenGL ES 2.0 content by translating OpenGL ES 2.0 API calls to DirectX 9 API calls. Looks like we're left with just Source/Thirdparty/mt19937ar.c and per http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/emt.html is fairly clear to be a copylib. I'll poke fpc about it.
mt19937ar.c copylib request: https://fedorahosted.org/fpc/ticket/291
And, grr, ANGLE actually is used, reading further down on it's project page, makes it clearer why: Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms. It is used on Mac OS X, Linux, and in mobile variants of the browsers. Having one shader validator helps to ensure that a consistent set of GLSL ES shaders are accepted across browsers and platforms. The shader translator can be used to translate shaders to other shading languages, and to optionally apply shader modifications to work around bugs or quirks in the native graphics drivers. The translator targets Desktop GLSL, Direct3D HLSL, and even ESSL for native GLES2 platforms.
OK, after banging against angle a bit, I found bug #858084 (mingw-qt5-qtwebkit review), and looks like unbundling angle may not be possible. Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.2-4.src.rpm %changelog * Wed May 15 2013 Rex Dieter <rdieter> 5.0.2-4 - BR: perl(version) perl(Digest::MD5) pkgconfig(xslt) - deal with bundled code - add (commented) upstream link http://qt-project.org/doc/qt-5.0/qtdoc/licensing.html to clarify licensing * Thu May 09 2013 Rex Dieter <rdieter> 5.0.2-3 - -devel: Requires: qt5-qtdeclarative-devel
(In reply to comment #17) > OK, after banging against angle a bit, I found bug #858084 > (mingw-qt5-qtwebkit review), and looks like unbundling angle may not be > possible. ah I see, can you open a fpc ticket for angle too?
as far as mt19937ar.c, turns out that code isn't used on linux either, but oh well. angle bundling exception submitted, https://fedorahosted.org/fpc/ticket/293
rpmbuild --rebuild qt5-qtwebkit-5.0.2-4.src.rpm output: error: Failed build dependencies: perl(version) is needed by qt5-qtwebkit-5.0.2-4.fc19.x86_64 while .... : perl --version This is perl 5, version 16, subversion 3 (v5.16.3) built for x86_64-linux-thread-multi
perl(version) is provided by perl-version, not perl.
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.2-5.src.rpm %changelog * Fri May 17 2013 Rex Dieter <rdieter> 5.0.2-5 - unbundle angleproject code
ping? it's been almost 2 weeks since my last update, you still interested in completing this review?
Created attachment 760028 [details] pre-review sorry for the late response. lets try to finish this whats left: - some (internal?) libs are defining rpaths - unspecific license tag: actually most of the code is LGPL and BSD; I've also spotted some apache, MIT, ISC and MPL files (see licensecheck). Since this is basically a copy of webkit I also don't think the qt license terms do really apply here ("# See also http://qt-project.org/doc/qt-5.0/qtdoc/licensing.html") - include ChangeLog and VERSION (there is no license file, is it?) thanks for your effort
Re: licensing $ licensecheck -r * | cut -d' ' -f2 | sort | uniq -c 7 Apache 9097 BSD 3 BSL 22 GENERATED 6 GPL 1 ISC 2946 LGPL 6 MIT/X11 30 MPL 451 *No 1 Public 492 UNKNOWN 3 zlib/libpng Of these, zlib is only used in configure tests, and only MPL is GPL incompatible (but ok, since all the MPL licensed files are also dual licensed GPL/LGPL). There are a small handful of Qt-standard licensed files. So... when all is said and done, the combined aggregate license still comes back to what we started with. Working on the other items now...
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtwebkit-5.0.2-6.src.rpm %changelog * Fri Jun 21 2013 Rex Dieter <rdieter> 5.0.2-6 - %%doc ChangeLog VERSION - %%doc Source/WebCore/LICENSE* - squash more rpaths
okay, go ahead APPROVED Rpmlint ------- Checking: qt5-qtwebkit-5.0.2-6.fc20.x86_64.rpm qt5-qtwebkit-devel-5.0.2-6.fc20.x86_64.rpm qt5-qtwebkit.x86_64: W: shared-lib-calls-exit /usr/lib64/libQt5WebKit.so.5.0.2 exit.5 qt5-qtwebkit.x86_64: W: shared-lib-calls-exit /usr/lib64/libQt5WebKit.so.5.0.2 _exit.5 qt5-qtwebkit-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
New Package SCM Request ======================= Package Name: qt5-qtwebkit Short Description: Qt5 - QtWebKit components Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
fyi, still waiting on angleproject dep to build this, bug #967234
qt5-qtsvg-5.0.2-1.fc19,qt5-qtwebkit-5.0.2-7.fc19,qt5-qtdeclarative-5.0.2-3.fc19,qt5-qtjsbackend-5.0.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/qt5-qtsvg-5.0.2-1.fc19,qt5-qtwebkit-5.0.2-7.fc19,qt5-qtdeclarative-5.0.2-3.fc19,qt5-qtjsbackend-5.0.2-2.fc19
qt5-qtsvg-5.0.2-1.fc18,qt5-qtwebkit-5.0.2-7.fc18,qt5-qtdeclarative-5.0.2-3.fc18,qt5-qtjsbackend-5.0.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/qt5-qtsvg-5.0.2-1.fc18,qt5-qtwebkit-5.0.2-7.fc18,qt5-qtdeclarative-5.0.2-3.fc18,qt5-qtjsbackend-5.0.2-2.fc18
Package qt5-qtsvg-5.0.2-1.fc19, qt5-qtwebkit-5.0.2-7.fc19, qt5-qtdeclarative-5.0.2-3.fc19, qt5-qtjsbackend-5.0.2-2.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing qt5-qtsvg-5.0.2-1.fc19 qt5-qtwebkit-5.0.2-7.fc19 qt5-qtdeclarative-5.0.2-3.fc19 qt5-qtjsbackend-5.0.2-2.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-14290/qt5-qtsvg-5.0.2-1.fc19,qt5-qtwebkit-5.0.2-7.fc19,qt5-qtdeclarative-5.0.2-3.fc19,qt5-qtjsbackend-5.0.2-2.fc19 then log in and leave karma (feedback).
qt5-qtsvg-5.0.2-1.fc19, qt5-qtwebkit-5.0.2-7.fc19, qt5-qtdeclarative-5.0.2-3.fc19, qt5-qtjsbackend-5.0.2-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
qt5-qtsvg-5.0.2-1.fc18, qt5-qtwebkit-5.0.2-7.fc18, qt5-qtdeclarative-5.0.2-3.fc18, qt5-qtjsbackend-5.0.2-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: qt5-qtwebkit New Branches: el6 Owners: hobbes1069 rdieter InitialCC: Co-maintainers welcome!