Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://people.parinux.org/~seyman/fedora/perl-URI-Escape-XS/perl-URI-Escape-XS.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-URI-Escape-XS/perl-URI-Escape-XS-0.10-1.fc18.src.rpm Description: This is a drop-in replacement for the URI::Escape module. Since it uses XS, it is really fast except for uri_escape("noop"). Fedora Account System Username: eseyman
Missing BRs: perl(base) from lib/URI/Escape/XS.pm:10 perl(Encode) from t/03-hashu.t:10 perl(Exporter) from lib/URI/Escape/XS.pm:10 perl(XSLoader) from lib/URI/Escape/XS.pm:15 People might also use perl(Carp) at runtime. Since it isn't autodetected, it should be required explicitly. The last changelog entry refers to version "010" instead of "0.10". Cosmetics: - s/PERL_INSTALL_ROOT/DESTDIR/ - line 34 is unnecessary
Petr, I've taken all your comments into account. Spec URL: http://people.parinux.org/~seyman/fedora/perl-URI-Escape-XS/perl-URI-Escape-XS.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-URI-Escape-XS/perl-URI-Escape-XS-0.10-2.fc18.src.rpm
Almost good but perl(Carp) should be Require'd instead. I don't think that part of code is executed during tests but end users might hit it.
Sorry, I was in a rush on the previous spec. Spec URL: http://people.parinux.org/~seyman/fedora/perl-URI-Escape-XS/perl-URI-Escape-XS.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-URI-Escape-XS/perl-URI-Escape-XS-0.10-3.fc18.src.rpm
Fixed, approving.
New Package SCM Request ======================= Package Name: perl-URI-Escape-XS Short Description: Drop-In replacement for URI::Escape Owners: eseyman Branches: f18 InitialCC: perl-sig
Git done (by process-git-requests).
perl-URI-Escape-XS-0.10-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-URI-Escape-XS-0.10-3.fc18
perl-URI-Escape-XS-0.10-3.fc18 has been pushed to the Fedora 18 testing repository.
perl-URI-Escape-XS-0.10-3.fc18 has been pushed to the Fedora 18 stable repository.