Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 917911

Summary: Keep "Validation Warnings: n" displayed even when moving focus to different pages
Product: [Retired] Zanata Reporter: Ding-Yi Chen <dchen>
Component: Component-UIAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: high Docs Contact:
Priority: urgent    
Version: 2.1CC: aeng, hpeters, zanata-bugs
Target Milestone: ---   
Target Release: 2.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 2.3-SNAPSHOT (20130409-1233) Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 910637 Environment:
Last Closed: 2013-11-27 03:23:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 910637    
Bug Blocks:    
Attachments:
Description Flags
Empty entries mistakenly got warning none

Description Ding-Yi Chen 2013-03-05 05:26:09 UTC 
Bug 910637 is for same page change entry in same page, this bug is for change different page and change back.

+++ This bug was initially created as a clone of Bug #910637 +++

Description of problem:
When a validation warning is current for any given translation entry, there is a red border around the whole entry as well as the words "Validation Warnings: n" highlighted in red. However, as soon as you move the focus to a different entry, the red "Validation Warnings: n" disappears, leaving only the red border around the entry.

  
Actual results:
Warning not obvious enough when moving focus to different entry.

Expected results:
Warning obvious even when moving to different entry.


Additional info:
We had a bug which displayed red borders for many entries, even if there was no error or validation warning present. Translators might have "learned" to ignore the red border (which is not very obvious at the best of times) - I sure did and got used to not taking any notice of it. 

Suggesting to keep the red highlighted text visible to break that habit, also suggesting to make the red border thicker.
Comment 1 Alex Eng 2013-03-19 03:52:04 UTC 
Implemented in 2.3

See
https://github.com/zanata/zanata/commit/6e97540cc042bf3334f11fe0864a16b5d4a5df12
Comment 2 Ding-Yi Chen 2013-03-19 05:17:31 UTC 
Tested with Zanata version 2.3-SNAPSHOT (20130319-1404).

If there are empty entries immediately after the error entry, those empty entries will be marked as error after I switch back.

Step to reproduce:
1. Find a document which is long enough to have multiple page
2. In any page, produce a validation warning.
3. Ensure the entries below the error entry are empty
4. Switch to other page
5. Switch back

Actual:
Validation warning show on empty entries below the error.

Expected:
NO validation warning on empty entries.

Reassigned.
Comment 3 Ding-Yi Chen 2013-03-19 05:19:26 UTC 
Created attachment 712391 [details]
Empty entries mistakenly got warning

Screen shot of empty entries mistakenly got warning.
Comment 4 Alex Eng 2013-03-19 05:51:43 UTC 
Fix problem in https://bugzilla.redhat.com/show_bug.cgi?id=917911#c2.

See

https://github.com/zanata/zanata/commit/89f5e3cf86196c108312704844384e2f97880dc7
Comment 5 Ding-Yi Chen 2013-04-09 04:56:25 UTC 
VERIFIED with Zanata version 2.3-SNAPSHOT (20130409-1233)
Comment 6 Sean Flanigan 2013-11-27 03:13:39 UTC 
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 7 Sean Flanigan 2013-11-27 03:15:37 UTC 
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 8 Sean Flanigan 2013-11-27 03:19:04 UTC 
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 9 Sean Flanigan 2013-11-27 03:23:31 UTC 
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 10 Sean Flanigan 2013-11-27 03:33:44 UTC 
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 11 Sean Flanigan 2013-11-27 03:36:00 UTC 
Closing VERIFIED bugs for Zanata versions <= 3.1.