Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-document-viewer-1.5.0-2.fc20.src.rpm Description: Atril is simple multi-page document viewer. It can display and print Portable Document Format (PDF), PostScript (PS) and Encapsulated PostScript (EPS) files. When supported by the document format, evince allows searching for text, copying text to the clipboard, hypertext navigation, table-of-contents bookmarks and editing of forms. Support for other document formats such as DVI, XPS and DJVU can be added by installing additional back-ends Fedora Account System Username: raveit65
Update for MATE 1.6 release Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-document-viewer-1.6.0-1.fc20.src.rpm
Dan, after 40 days of no action from you, i quess you're revised and have no time to review the request. Please do an action over the weekend. I think you agree that i reset 'assigned to' to nobody after the weekend, because of non blocking other potential reviewers.
I tried to build src.rpm but mate-keyring-1 wasn't found, libmatekeyring-devel needed instead of mate-keyring-devel.
(In reply to comment #3) > I tried to build src.rpm but mate-keyring-1 wasn't found, > libmatekeyring-devel needed instead of mate-keyring-devel. Thank you for this hint, i'm still wondering why mate-keyring-devel doesn't install libmatekeyring-devel as an dependency on you your system. I build with mock and here it wasn't a problem. But you're right in this point because configure.ac asked for mate-keyring-1 which is provide by libmatekeyring-devel. New mock build: * Thu May 09 2013 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-2 - use libmate-keyring-devel as BR instead of mate-keyring-devel - fix spelling-error in %%description of -devel subpackage - fix gsettings schema rpm scriptlets Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-document-viewer-1.6.0-2.fc20.src.rpm
(Disclaimer: not an official review) > %files dvi > %{_libdir}/atril/3/backends/libdvidocument.so* > > %files djvu > %{_libdir}/atril/3/backends/libdjvudocument.so > > %files xps > %{_libdir}/atril/3/backends/libxpsdocument.so Why the "*" after libdvidocument.so, but not after the others? All of the libraries are unversioned, so removing the "*" will give you a heads up if upstream decides to version those libraries. > %package libs > %package dvi > %package djvu > %package xps Is there a reason to to separate the backends from the libs package? Think of a user installing mate-document-viewer. Will they be able to view $backendname files without installing the $backendname subpackage? I see this is a fork of evince, and evince uses the same splitup. However, unless there is a good reason to do so, I think keeping everything in -libs is saner. (Just look at texlive, which has almost 1000 subpackages). > sed -i -e 's,Categories=MATE;GTK;Graphics;VectorGraphics;Viewer;,Categories=GTK;Graphics;VectorGraphics;Viewer;,g' data/atril.desktop.in.in data/atril.desktop.in.in > sed -i -e '/GTK;Graphics;VectorGraphics;Viewer;/ a\OnlyShowIn=MATE;' data/atril.desktop.in.in Small comment explaining why this is needed. >%configure \ > --disable-static \ > --disable-scrollkeeper \ Whitespace issue. either use only tabs, or only spaces, but don't mix them up. There are a few more issues. I'll post a detailed review later.
Package Review ============== Status: NEEDSWORK Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. no ld.so.conf entry, so this is marked as Pass. [x]: Package contains no bundled libraries without FPC exception. The included libdocument, libmisc, and libview are an integral part of the package. Issues: ======= See sed comment, and whitespace issue above. ================================================================================ - update-desktop-database is invoked when required Note: desktop file(s) in mate-document-viewer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > (EPS) files. When supported by the document format, evince allows searching This is not evince, is it? ================================================================================ > files libs > %{_libdir}/atril/3/backends/libpdfdocument.so > %{_libdir}/atril/3/backends/pdfdocument.atril-backend > %{_libdir}/atril/3/backends/libpsdocument.so > %{_libdir}/atril/3/backends/psdocument.atril-backend > %{_libdir}/atril/3/backends/libtiffdocument.so > %{_libdir}/atril/3/backends/tiffdocument.atril-backend > %{_libdir}/atril/3/backends/libcomicsdocument.so > %{_libdir}/atril/3/backends/comicsdocument.atril-backend and later down: > %files dvi > %{_libdir}/atril/3/backends/libdvidocument.so* > %{_libdir}/atril/3/backends/dvidocument.atril-backend > > %files djvu > %{_libdir}/atril/3/backends/libdjvudocument.so > %{_libdir}/atril/3/backends/djvudocument.atril-backend > > %files xps > %{_libdir}/atril/3/backends/libxpsdocument.so > %{_libdir}/atril/3/backends/xpsdocument.atril-backend Relating to what I asked in the previous comment: There is no reason to separate dvi, djvu, and xps, but leave pdf, ps, and tiff integral. Please drop these subpackages, and simplify this to: %{_libdir}/atril/3/backends/lib*document.so %{_libdir}/atril/3/backends/*document.atril-backend ================================================================================ [!]: Package requires other packages for directories it uses. > %{_datadir}/icons/hicolor/*/apps/atril.* Missing "Requires: hicolor-icon-them" > %{_datadir}/MateConf/gsettings/atril.convert Missing "Requires: mate-conf" ================================================================================ [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate- document-viewer-libs Since -libs subpackage is not really separable from the main package, you can go ahead and add this. ================================================================================ [!]: License file installed when any subpackage combination is installed. This won't be a problem once you add the dependency above. ================================================================================ [!]: Package uses nothing in %doc for runtime. > %{_datadir}/doc/mate/atril/atril.html > %{_datadir}/doc/mate/atril/atril_start_window.png These look like innocent documentation. You should include them with %doc. otherwise, you end up with both mate/ and mate-document-viewer/ in /usr/share/doc. ================================================================================ [!]: Package must own all directories that it creates. > %{_datadir}/mate/help/atril/ $ yum provides /usr/share/mate No Matches found Who owns %{_datadir}/mate/ and %{_datadir}/mate/atril/ ? > %{_libdir}/caja/extensions-2.0/libatril-properties-page.so $ yum provides /usr/lib64/caja/ No Matches found $ yum provides /usr/lib/caja/ No Matches found ================================================================================ [!]: Requires correct, justified where necessary. [!]: Final provides and requires are sane (see attachments). See above for missing Requires. ================================================================================ [!]: Large documentation must go in a -doc subpackage. Note: Documentation size is 153600 bytes in 6 files. Marked as failed until the %{_datadir}/doc issue is fixed. ================================================================================ [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4454400 bytes in /usr/share 4075520 mate-document-viewer-1.6.0-2.fc20.x86_64.rpm 378880 mate-document-viewer- devel-1.6.0-2.fc20.x86_64.rpm Self-explanatory. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [!]: Package requires other packages for directories it uses. [!]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate- document-viewer-libs [x]: glib-compile-schemas is run if required Note: gschema file(s) in mate-document-viewer [ ]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/mrnuke/924310-mate-document- viewer/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in mate-document-viewer [x]: Useful -debuginfo package or justification otherwise. [!]: Large documentation must go in a -doc subpackage. Note: Documentation size is 153600 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4454400 bytes in /usr/share 4075520 mate-document-viewer-1.6.0-2.fc20.x86_64.rpm 378880 mate-document-viewer- devel-1.6.0-2.fc20.x86_64.rpm [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mate-document-viewer-1.6.0-2.fc20.x86_64.rpm mate-document-viewer-libs-1.6.0-2.fc20.x86_64.rpm mate-document-viewer-devel-1.6.0-2.fc20.x86_64.rpm mate-document-viewer-dvi-1.6.0-2.fc20.x86_64.rpm mate-document-viewer-djvu-1.6.0-2.fc20.x86_64.rpm mate-document-viewer-xps-1.6.0-2.fc20.x86_64.rpm mate-document-viewer-caja-1.6.0-2.fc20.x86_64.rpm mate-document-viewer.x86_64: W: spelling-error %description -l en_US Atril -> Atria, April, Atrial mate-document-viewer.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer mate-document-viewer-libs.x86_64: W: no-documentation mate-document-viewer-devel.x86_64: W: no-documentation mate-document-viewer-dvi.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-dvi.x86_64: W: no-documentation mate-document-viewer-djvu.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-djvu.x86_64: W: no-documentation mate-document-viewer-xps.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-xps.x86_64: W: no-documentation mate-document-viewer-caja.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-caja.x86_64: W: spelling-error %description -l en_US atril -> atrial, trail, trial mate-document-viewer-caja.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mate-document-viewer-xps mate-document-viewer-devel mate-document-viewer-dvi mate-docume nt-viewer mate-document-viewer-libs mate-document-viewer-caja mate-document-viewer-djvu mate-document-viewer-xps.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-xps.x86_64: W: no-documentation mate-document-viewer-devel.x86_64: W: no-documentation mate-document-viewer-dvi.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-dvi.x86_64: W: no-documentation mate-document-viewer.x86_64: W: spelling-error %description -l en_US Atril -> Atria, April, Atrial mate-document-viewer.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libfontconfig.so.1 mate-document-viewer-libs.x86_64: W: no-documentation mate-document-viewer-caja.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-caja.x86_64: W: spelling-error %description -l en_US atril -> atrial, trail, trial mate-document-viewer-caja.x86_64: W: no-documentation mate-document-viewer-djvu.x86_64: W: spelling-error Summary(en_US) Atril -> Atria, April, Atrial mate-document-viewer-djvu.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 28 warnings. # echo 'rpmlint-done:' Requires -------- mate-document-viewer-xps (rpmlib, GLIBC filtered): libarchive.so.13()(64bit) libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libgxps.so.2()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) mate-document-viewer(x86-64) rtld(GNU_HASH) mate-document-viewer-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) mate-document-viewer(x86-64) pkgconfig(atril-document-1.5.0) pkgconfig(gio-2.0) pkgconfig(gthread-2.0) pkgconfig(gtk+-2.0) mate-document-viewer-dvi (rpmlib, GLIBC filtered): libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libkpathsea.so.6()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libspectre.so.1()(64bit) libt1.so.5()(64bit) mate-document-viewer(x86-64) rtld(GNU_HASH) mate-document-viewer (rpmlib, GLIBC filtered): /bin/sh libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgailutil.so.18()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libmate-keyring.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) mate-document-viewer-libs(x86-64) rtld(GNU_HASH) mate-document-viewer-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgailutil.so.18()(64bit) libgcc_s.so.1()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpoppler-glib.so.8()(64bit) libpthread.so.0()(64bit) libspectre.so.1()(64bit) libstdc++.so.6()(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) mate-document-viewer-caja (rpmlib, GLIBC filtered): libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcaja-extension.so.1()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libz.so.1()(64bit) mate-document-viewer(x86-64) mate-file-manager rtld(GNU_HASH) mate-document-viewer-djvu (rpmlib, GLIBC filtered): libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdjvulibre.so.21()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) mate-document-viewer(x86-64) rtld(GNU_HASH) Provides -------- mate-document-viewer-xps: libxpsdocument.so()(64bit) mate-document-viewer-xps mate-document-viewer-xps(x86-64) mate-document-viewer-devel: mate-document-viewer-devel mate-document-viewer-devel(x86-64) pkgconfig(atril-document-1.5.0) pkgconfig(atril-view-1.5.0) mate-document-viewer-dvi: libdvidocument.so()(64bit) mate-document-viewer-dvi mate-document-viewer-dvi(x86-64) mate-document-viewer: mate-document-viewer mate-document-viewer(x86-64) mimehandler(application/oxps) mimehandler(application/pdf) mimehandler(application/postscript) mimehandler(application/vnd.ms-xpsdocument) mimehandler(application/x-bzdvi) mimehandler(application/x-bzpdf) mimehandler(application/x-bzpostscript) mimehandler(application/x-cb7) mimehandler(application/x-cbr) mimehandler(application/x-cbt) mimehandler(application/x-cbz) mimehandler(application/x-dvi) mimehandler(application/x-gzdvi) mimehandler(application/x-gzpdf) mimehandler(application/x-gzpostscript) mimehandler(image/tiff) mimehandler(image/vnd.djvu) mimehandler(image/x-bzeps) mimehandler(image/x-eps) mimehandler(image/x-gzeps) mate-document-viewer-libs: libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) libcomicsdocument.so()(64bit) libpdfdocument.so()(64bit) libpsdocument.so()(64bit) libtiffdocument.so()(64bit) mate-document-viewer-libs mate-document-viewer-libs(x86-64) mate-document-viewer-caja: libatril-properties-page.so()(64bit) mate-document-viewer-caja mate-document-viewer-caja(x86-64) mate-document-viewer-djvu: libdjvudocument.so()(64bit) mate-document-viewer-djvu mate-document-viewer-djvu(x86-64) Unversioned so-files -------------------- mate-document-viewer-libs: /usr/lib64/atril/3/backends/libcomicsdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpdfdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpsdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libtiffdocument.so mate-document-viewer-dvi: /usr/lib64/atril/3/backends/libdvidocument.so mate-document-viewer-djvu: /usr/lib64/atril/3/backends/libdjvudocument.so mate-document-viewer-xps: /usr/lib64/atril/3/backends/libxpsdocument.so mate-document-viewer-caja: /usr/lib64/caja/extensions-2.0/libatril-properties-page.so MD5-sum check ------------- http://pub.mate-desktop.org/releases/1.6/mate-document-viewer-1.6.0.tar.xz : CHECKSUM(SHA256) this package : 40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf CHECKSUM(SHA256) upstream package : 40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/bin/fedora-review -b 924310
Thank you for revieving. (In reply to comment #5) > (Disclaimer: not an official review) > > %files dvi > > %{_libdir}/atril/3/backends/libdvidocument.so* > > > > %files djvu > > %{_libdir}/atril/3/backends/libdjvudocument.so > > > > %files xps > > %{_libdir}/atril/3/backends/libxpsdocument.so > > Why the "*" after libdvidocument.so, but not after the others? All of the > libraries are unversioned, so removing the "*" will give you a heads up if > upstream decides to version those libraries. yes, i will remove *. > > > %package libs > > %package dvi > > %package djvu > > %package xps > > Is there a reason to to separate the backends from the libs package? Think > of a user installing mate-document-viewer. Will they be able to view > $backendname files without installing the $backendname subpackage? > > I see this is a fork of evince, and evince uses the same splitup. However, > unless there is a good reason to do so, I think keeping everything in -libs > is saner. (Just look at texlive, which has almost 1000 subpackages). I did use the evince spec file as base if start building this package last year, but i agree there is no reason to do this for mate-document-viewer, and it is much user friendly. > > sed -i -e 's,Categories=MATE;GTK;Graphics;VectorGraphics;Viewer;,Categories=GTK;Graphics;VectorGraphics;Viewer;,g' data/atril.desktop.in.in data/atril.desktop.in.in > > sed -i -e '/GTK;Graphics;VectorGraphics;Viewer;/ a\OnlyShowIn=MATE;' data/atril.desktop.in.in > > Small comment explaining why this is needed. MATE hasn't a registred category in desktop-file-utils, only 'OnlyShowIn=MATE'. https://bugs.freedesktop.org/show_bug.cgi?id=44353#c2 But i fixed that already in upstream 1.6.0 version, here i started with the 1.5.x version. I agree that m-d-w can work as standalone without MATE desktop, so i won't add the 'OnlyShowIn=MATE entry. > > >%configure \ > > --disable-static \ > > --disable-scrollkeeper \ > > Whitespace issue. either use only tabs, or only spaces, but don't mix them > up. Of course, i will change it.
(In reply to comment #6) > > See sed comment, and whitespace issue above. > ============================================================================= > === > - update-desktop-database is invoked when required > Note: desktop file(s) in mate-document-viewer > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache I did already run the review tool for my own, but why the review tool failed here? I use the update-desktop-database rpm scriplet because desktop file has a mime data entry. > > > (EPS) files. When supported by the document format, evince allows searching > > This is not evince, is it? Opps, thank you, i will change description. > > ============================================================================= > === > > files libs > > %{_libdir}/atril/3/backends/libpdfdocument.so > > %{_libdir}/atril/3/backends/pdfdocument.atril-backend > > %{_libdir}/atril/3/backends/libpsdocument.so > > %{_libdir}/atril/3/backends/psdocument.atril-backend > > %{_libdir}/atril/3/backends/libtiffdocument.so > > %{_libdir}/atril/3/backends/tiffdocument.atril-backend > > %{_libdir}/atril/3/backends/libcomicsdocument.so > > %{_libdir}/atril/3/backends/comicsdocument.atril-backend > > and later down: > > %files dvi > > %{_libdir}/atril/3/backends/libdvidocument.so* > > %{_libdir}/atril/3/backends/dvidocument.atril-backend > > > > %files djvu > > %{_libdir}/atril/3/backends/libdjvudocument.so > > %{_libdir}/atril/3/backends/djvudocument.atril-backend > > > > %files xps > > %{_libdir}/atril/3/backends/libxpsdocument.so > > %{_libdir}/atril/3/backends/xpsdocument.atril-backend > > Relating to what I asked in the previous comment: > There is no reason to separate dvi, djvu, and xps, but leave pdf, ps, and > tiff > integral. Please drop these subpackages, and simplify this to: > > %{_libdir}/atril/3/backends/lib*document.so > %{_libdir}/atril/3/backends/*document.atril-backend Agree. > > ============================================================================= > === > [!]: Package requires other packages for directories it uses. > > > %{_datadir}/icons/hicolor/*/apps/atril.* > Missing "Requires: hicolor-icon-them" Ohh, this is new for me, i will add the require. > > > %{_datadir}/MateConf/gsettings/atril.convert > > Missing "Requires: mate-conf" Mate-conf is obsolete. MATE is complete ported to gsettings started with 1.5.x package versions. After i removed mate-conf from my latest compiz packages i expected Dan Marchal (MATE Maintainer) will obsolete mate-conf too, like he did it with other obsolete MATE packages for f19. In fedora MATE started with 1.5.x versions, all of them didn't use mate-conf anymore, in result there is no user who have mate-conf settings to convert. > > ============================================================================= > === > [!]: Fully versioned dependency in subpackages, if present. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate- > document-viewer-libs > > Since -libs subpackage is not really separable from the main package, you > can go > ahead and add this. > Agree, will change it > ============================================================================= > === > [!]: Package uses nothing in %doc for runtime. > > %{_datadir}/doc/mate/atril/atril.html > > %{_datadir}/doc/mate/atril/atril_start_window.png > > These look like innocent documentation. You should include them with %doc. > otherwise, you end up with both mate/ and mate-document-viewer/ in > /usr/share/doc. So i can use %doc README COPYING NEWS AUTHORS atril.html atril_start_window.png ???? Or what do you suggest? Can you explain it more detail please? > > ============================================================================= > === > [!]: Package must own all directories that it creates. > > > %{_datadir}/mate/help/atril/ > $ yum provides /usr/share/mate > No Matches found > > Who owns %{_datadir}/mate/ and %{_datadir}/mate/atril/ ? %{_datadir}/mate/ should owned by mate-desktop, because this is the major and first package in MATE. Also the build order for MATE is mate-common, mate-doc-utils, mate-desktop and then the rest. But i noticed it isn't. http://pkgs.fedoraproject.org/cgit/mate-desktop.git/tree/mate-desktop.spec For me it looks like a issue with mate-desktop spec file. Owning this directory with an additional (m-d-v) package is the wrong way, imo. %{_datadir}/mate/atril/ doesn't exists, you mean %{_datadir}/mate/help/atril/ which is owned by m-d-v. > > > %{_libdir}/caja/extensions-2.0/libatril-properties-page.so > $ yum provides /usr/lib64/caja/ > No Matches found > $ yum provides /usr/lib/caja/ > No Matches found Caja is the internal name, the package name is mate-file-manager. http://pkgs.fedoraproject.org/cgit/mate-file-manager.git/tree/mate-file-manager.spec Maybe the same prob here, i think %{_libdir}/caja/extensions-2.0 should also own %{_libdir}/caja ??? > > > Rpmlint (installed packages) > ---------------------------- > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency I did try to fix this with # remove unused-direct-shlib-dependency sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool Do you know a other solution?
Alex, do you have currently an open review for catching?
For the next build i change this. %changelog * Fri May 10 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-3 - remove -dvi, -djvu, -xps subpackages and move the libs to -libs subpackage - add Requires: %%{name}%%{?_isa} = %%{version}-%%{release} to -libs subpackage - remove sed commands for desktop file - add hicolor-icon-theme require - fix last changelog date - rename atril to mate-document-viewer in summarys and descriptions - to avoid rpmlint warnings - rename evince to mate-document-viewer in description - fix mixed-use-of-spaces-and-tabs in spec file But i don't know how to handle the %doc issue?
> > > > > %{_datadir}/MateConf/gsettings/atril.convert > > > > Missing "Requires: mate-conf" > Mate-conf is obsolete. MATE is complete ported to gsettings started with > 1.5.x package versions. > After i removed mate-conf from my latest compiz packages i expected Dan > Marchal (MATE Maintainer) will obsolete mate-conf too, like he did it with > other obsolete MATE packages for f19. > In fedora MATE started with 1.5.x versions, all of them didn't use mate-conf > anymore, in result there is no user who have mate-conf settings to convert. Well, then why are we putting data in /usr/share/MateConf, which is owned by mate-conf ? Someone needs to own that dir. $ yum provides /usr/share/MateConf mate-conf-1.4.0-21.fc18.x86_64 : MATE Desktop configuration tool Repo : fedora Matched from: Filename : /usr/share/MateConf > > ============================================================================= > > === > > [!]: Package uses nothing in %doc for runtime. > > > %{_datadir}/doc/mate/atril/atril.html > > > %{_datadir}/doc/mate/atril/atril_start_window.png > > > > These look like innocent documentation. You should include them with %doc. > > otherwise, you end up with both mate/ and mate-document-viewer/ in > > /usr/share/doc. > So i can use > %doc README COPYING NEWS AUTHORS atril.html atril_start_window.png > ???? > Or what do you suggest? Can you explain it more detail please? Ok. This is more complicated. The package installer thinks that it is a good idea to install documentaion in /usr/share/doc/. The location of the doc is packaging territory, and upstream should not really mess with that. I would contact them about it. Until then, we can mess around a little bit: in %install, add: # move installed doc to versioned directory mv $RPM_BUILD_ROOT%{_docdir}/mate \ $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version} then change the %files entry to: %doc %{_docdir}/%{name}-%{version}/atril/atril.html %doc %{_docdir}/%{name}-%{version}/atril/atril_start_window.png > > > > ============================================================================= > > === > > [!]: Package must own all directories that it creates. > > > > > %{_datadir}/mate/help/atril/ > > $ yum provides /usr/share/mate > > No Matches found > > > > Who owns %{_datadir}/mate/ and %{_datadir}/mate/atril/ ? > %{_datadir}/mate/ should owned by mate-desktop, because this is the major > and first package in MATE. Also the build order for MATE is mate-common, > mate-doc-utils, mate-desktop and then the rest. > But i noticed it isn't. And none of those packages owns %{_datadir}/mate/. It seems mate-doc-utils is the the first package to create this directory, but does not own it. We will need to have a bug created against that, and set it as a blocker to this bug. > > > %{_libdir}/caja/extensions-2.0/libatril-properties-page.so > > $ yum provides /usr/lib64/caja/ > > No Matches found > > $ yum provides /usr/lib/caja/ > > No Matches found > Caja is the internal name, the package name is mate-file-manager. > http://pkgs.fedoraproject.org/cgit/mate-file-manager.git/tree/mate-file- > manager.spec > Maybe the same prob here, i think %{_libdir}/caja/extensions-2.0 should also > own %{_libdir}/caja ??? Another bug against mate-file-manager telling them they do not own all the dirs they create. > > ... > > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > I did try to fix this with > # remove unused-direct-shlib-dependency > sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool > Do you know a other solution? I think this is just a false positive.
(In reply to comment #11) > Ok. This is more complicated. The package installer thinks that it is a good > idea to install documentaion in /usr/share/doc/. The location of the doc is > packaging territory, and upstream should not really mess with that. I would > contact them about it. > > Until then, we can mess around a little bit: > in %install, add: > > # move installed doc to versioned directory > mv $RPM_BUILD_ROOT%{_docdir}/mate \ > $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version} > > then change the %files entry to: > > %doc %{_docdir}/%{name}-%{version}/atril/atril.html > %doc %{_docdir}/%{name}-%{version}/atril/atril_start_window.png > Or if it's upstream's intention to have all mate-desktop documentation files under a common umbrella (/usr/share/doc/mate), someone needs to own that common umbrella.
Wolfgang, Let's have an updated spec/srpm that fixes the other issues, while Dan takes a look at his two dependent bugs.
New mock build: %changelog * Fri May 10 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-3 - remove -dvi, -djvu, -xps subpackages and move the libs to -libs subpackage - add Requires: %%{name}%%{?_isa} = %%{version}-%%{release} to -libs subpackage - remove sed commands for desktop file - add hicolor-icon-theme require - fix last changelog date - rename atril to mate-document-viewer in summarys and descriptions - to avoid rpmlint warnings - rename evince to mate-document-viewer in description - update description - fix mixed-use-of-spaces-and-tabs in spec file - move additional doc files to valid doc dir Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-document-viewer-1.6.0-3.fc20.src.rpm
OK, the big issues have gone away. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ================================================================================ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/mate-document- viewer-1.6.0/atril/atril.html See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles False positive. It only appears in base package. ================================================================================ - update-desktop-database is invoked when required Note: desktop file(s) in mate-document-viewer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache False positive. update-desktop-database is present in both %post and %postun. ================================================================================ [?]: Package requires other packages for directories it uses. Currently, the folloing lack proper Requires: %{_datadir}/MateConf/ If mate-conf is obsoleted, what do we do with this? %{_datadir}/mate/ (bug 961950) %{_libdir}/caja/ (bug 961992) ================================================================================ [?]: Requires correct, justified where necessary. Not evaluating until we figure out what to do with: %{_datadir}/MateConf/gsettings/atril.convert ================================================================================ [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4454400 bytes in /usr/share 378880 mate-document-viewer-devel-1.6.0-3.fc20.x86_64.rpm 4075520 mate-document- viewer-1.6.0-3.fc20.x86_64.rpm Have a look at what data can safely be moved to a noarch package, %{name}-data. Possible candidates: locale (2.4MB) %{_datadir}/mate/help/atril/ (1.1MB) maybe others ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [?]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: glib-compile-schemas is run if required Note: gschema file(s) in mate-document-viewer [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 34 files have unknown license. Detailed output of licensecheck in /home/mrnuke/924310-mate-document- viewer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in mate-document-viewer [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 153600 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4454400 bytes in /usr/share 378880 mate-document-viewer-devel-1.6.0-3.fc20.x86_64.rpm 4075520 mate-document- viewer-1.6.0-3.fc20.x86_64.rpm [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mate-document-viewer-1.6.0-3.fc20.x86_64.rpm mate-document-viewer-libs-1.6.0-3.fc20.x86_64.rpm mate-document-viewer-devel-1.6.0-3.fc20.x86_64.rpm mate-document-viewer-caja-1.6.0-3.fc20.x86_64.rpm mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer Seriosly fedora-review? Pass. mate-document-viewer-libs.x86_64: W: no-documentation mate-document-viewer-devel.x86_64: W: no-documentation mate-document-viewer-caja.x86_64: W: no-documentation These are fine. 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mate-document-viewer-devel mate-document-viewer-libs mate-document-viewer-caja mate-docu ment-viewer mate-document-viewer-devel.x86_64: W: no-documentation mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libfontconfig.so.1 mate-document-viewer-libs.x86_64: W: no-documentation mate-document-viewer-caja.x86_64: W: no-documentation mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer 4 packages and 0 specfiles checked; 0 errors, 18 warnings. # echo 'rpmlint-done:' A bunch of false positives that I bet will go away if I clear the mock cahe. Requires -------- mate-document-viewer-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) mate-document-viewer(x86-64) pkgconfig(atril-document-1.5.0) pkgconfig(gio-2.0) pkgconfig(gthread-2.0) pkgconfig(gtk+-2.0) mate-document-viewer-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libarchive.so.13()(64bit) libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdjvulibre.so.21()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgailutil.so.18()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libgxps.so.2()(64bit) libkpathsea.so.6()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpoppler-glib.so.8()(64bit) libpthread.so.0()(64bit) libspectre.so.1()(64bit) libstdc++.so.6()(64bit) libt1.so.5()(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) mate-document-viewer(x86-64) rtld(GNU_HASH) mate-document-viewer-caja (rpmlib, GLIBC filtered): libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcaja-extension.so.1()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libz.so.1()(64bit) mate-document-viewer(x86-64) mate-file-manager rtld(GNU_HASH) mate-document-viewer (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgailutil.so.18()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libmate-keyring.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) mate-document-viewer-libs(x86-64) rtld(GNU_HASH) Provides -------- mate-document-viewer-devel: mate-document-viewer-devel mate-document-viewer-devel(x86-64) pkgconfig(atril-document-1.5.0) pkgconfig(atril-view-1.5.0) mate-document-viewer-libs: libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) libcomicsdocument.so()(64bit) libdjvudocument.so()(64bit) libdvidocument.so()(64bit) libpdfdocument.so()(64bit) libpsdocument.so()(64bit) libtiffdocument.so()(64bit) libxpsdocument.so()(64bit) mate-document-viewer-libs mate-document-viewer-libs(x86-64) mate-document-viewer-caja: libatril-properties-page.so()(64bit) mate-document-viewer-caja mate-document-viewer-caja(x86-64) mate-document-viewer: mate-document-viewer mate-document-viewer(x86-64) mimehandler(application/oxps) mimehandler(application/pdf) mimehandler(application/postscript) mimehandler(application/vnd.ms-xpsdocument) mimehandler(application/x-bzdvi) mimehandler(application/x-bzpdf) mimehandler(application/x-bzpostscript) mimehandler(application/x-cb7) mimehandler(application/x-cbr) mimehandler(application/x-cbt) mimehandler(application/x-cbz) mimehandler(application/x-dvi) mimehandler(application/x-gzdvi) mimehandler(application/x-gzpdf) mimehandler(application/x-gzpostscript) mimehandler(image/tiff) mimehandler(image/vnd.djvu) mimehandler(image/x-bzeps) mimehandler(image/x-eps) mimehandler(image/x-gzeps) Unversioned so-files -------------------- mate-document-viewer-libs: /usr/lib64/atril/3/backends/libcomicsdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libdjvudocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libdvidocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpdfdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpsdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libtiffdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libxpsdocument.so mate-document-viewer-caja: /usr/lib64/caja/extensions-2.0/libatril-properties-page.so Source checksums ---------------- http://pub.mate-desktop.org/releases/1.6/mate-document-viewer-1.6.0.tar.xz : CHECKSUM(SHA256) this package : 40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf CHECKSUM(SHA256) upstream package : 40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/bin/fedora-review -b 924310
(In reply to comment #15) > OK, the big issues have gone away. > > ============================================================================= > === > [?]: Package requires other packages for directories it uses. > > Currently, the folloing lack proper Requires: > %{_datadir}/MateConf/ > If mate-conf is obsoleted, what do we do with this? > > %{_datadir}/mate/ (bug 961950) > %{_libdir}/caja/ (bug 961992) > > ============================================================================= > === > [?]: Requires correct, justified where necessary. > > Not evaluating until we figure out what to do with: > %{_datadir}/MateConf/gsettings/atril.convert > I will simply remove this file from the package, because MATE started with gsettings in f17/f18. So we can expect that there is no user wo have to convert his mateconf user settings in fedora. Agree? But i think this is a general issue with 60 % of MATE packages in fedora, because non of them has a require mate-conf anymore. I'm curious if Dan will own this directory with mate-desktop when he obsolete mate-conf in near future. > ============================================================================= > === > [?]: Large data in /usr/share should live in a noarch subpackage if package > is > arched. > Note: Arch-ed rpms have a total of 4454400 bytes in /usr/share 378880 > mate-document-viewer-devel-1.6.0-3.fc20.x86_64.rpm 4075520 > mate-document- > viewer-1.6.0-3.fc20.x86_64.rpm > > Have a look at what data can safely be moved to a noarch package, > %{name}-data. > Possible candidates: > locale (2.4MB) > %{_datadir}/mate/help/atril/ (1.1MB) > maybe others > I will create this subpackage. > Rpmlint (installed packages) > ---------------------------- > # rpmlint mate-document-viewer-devel mate-document-viewer-libs > mate-document-viewer-caja mate-docu > ment-viewer > mate-document-viewer-devel.x86_64: W: no-documentation > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6 > mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libatrilview.so.3.0.0 /lib64/libfontconfig.so.1 > > A bunch of false positives that I bet will go away if I clear the mock cahe. I know this rpmlint warning from other packages too. There are always the same libs which can't be fixed with the sed command. libgthread, libpango ........ Ok, updated Spec and SRPM comming soon.
I moved also the help dir to -data subpackage, which gives me a positiv result in fedora-review tool. %changelog * Sat May 11 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-4 - remove gsettings convert file - create -data noarch subpackage - move docs in -data subpackage - move help dir in -data subpackage - move locale in -data subpackage Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-document-viewer-1.6.0-4.fc20.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in mate-document-viewer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache False positive. ================================================================================ [x]: Package requires other packages for directories it uses. Nothing we can do about these two. We need the other packages to own their own dirs. ================================================================================ [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate- document-viewer-libs , mate-document-viewer-devel , mate-document-viewer- caja Really false positive. ================================================================================ [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). You forgot to update http://raveit65.fedorapeople.org/Mate/SPECS/mate-document-viewer.spec srpm has new spec. using that one for the review. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mate- document-viewer-libs , mate-document-viewer-devel , mate-document-viewer- caja [x]: glib-compile-schemas is run if required Note: gschema file(s) in mate-document-viewer [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 34 files have unknown license. Detailed output of licensecheck in /home/mrnuke/924310-mate-document- viewer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in mate-document-viewer [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 153600 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: mate-document-viewer-1.6.0-4.fc20.x86_64.rpm mate-document-viewer-libs-1.6.0-4.fc20.x86_64.rpm mate-document-viewer-devel-1.6.0-4.fc20.x86_64.rpm mate-document-viewer-caja-1.6.0-4.fc20.x86_64.rpm mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer mate-document-viewer-libs.x86_64: W: no-documentation mate-document-viewer-devel.x86_64: W: no-documentation mate-document-viewer-caja.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mate-document-viewer-devel mate-document-viewer-libs mate-document-viewer-caja mate-docu ment-viewer mate-document-viewer-devel.x86_64: W: no-documentation mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangocairo-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libatk-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpangoft2-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libpango-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfreetype.so.6 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrildocument.so.3.0.0 /lib64/libfontconfig.so.1 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgmodule-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgthread-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangocairo-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libgdk_pixbuf-2.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libpangoft2-1.0.so.0 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libfreetype.so.6 mate-document-viewer-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libatrilview.so.3.0.0 /lib64/libfontconfig.so.1 mate-document-viewer-libs.x86_64: W: no-documentation mate-document-viewer-caja.x86_64: W: no-documentation mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-previewer mate-document-viewer.x86_64: W: no-manual-page-for-binary atril-thumbnailer 4 packages and 0 specfiles checked; 0 errors, 18 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/mrnuke/924310-mate-document-viewer/srpm/mate-document-viewer.spec 2013-05-13 08:58:21.262466827 -0500 +++ /home/mrnuke/924310-mate-document-viewer/srpm-unpacked/mate-document-viewer.spec 2013-05-13 08:58:21.727466853 -0500 @@ -5,5 +5,5 @@ Name: mate-document-viewer Version: 1.6.0 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Document viewer License: GPLv2+ and LGPLv2+ and MIT @@ -37,5 +37,6 @@ BuildRequires: djvulibre-devel -Requires: %{name}-libs%{?_isa} = %{version}-%{release} +Requires: %{name}-libs%{?_isa} = %{version}-%{release} +Requires: %{name}-data = %{version}-%{release} Requires: hicolor-icon-theme @@ -55,5 +56,15 @@ %description libs -This package contains shared libraries needed for mate-document-viewer +This package contains shared libraries needed for mate-document-viewer. + + +%package data +Summary: Data files for the mate-document-viewer +Group: Applications/Publishing +BuildArch: noarch +Requires: %{name}%{?_isa} = %{version}-%{release} + +%description data +This package contains shared data needed for mate-document-viewer. @@ -116,4 +127,8 @@ rm -f $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/icon-theme.cache +# remove of gsetting,convert file, no need for this in fedora +# because MATE starts with gsetting in fedora. +rm -f $RPM_BUILD_ROOT%{_datadir}/MateConf/gsettings/atril.convert + %find_lang atril @@ -144,5 +159,5 @@ -%files -f atril.lang +%files %doc README COPYING NEWS AUTHORS %{_bindir}/* @@ -155,10 +170,7 @@ %{_datadir}/dbus-1/services/org.mate.atril.Daemon.service %{_datadir}/glib-2.0/schemas/org.mate.Atril.gschema.xml -%{_datadir}/MateConf/gsettings/atril.convert -%{_datadir}/mate/help/atril/ %{_datadir}/omf/atril/ -%doc %{_docdir}/%{name}-%{version}/atril/atril.html -%doc %{_docdir}/%{name}-%{version}/atril/atril_start_window.png %{_datadir}/thumbnailers/atril.thumbnailer +%exclude %{_docdir}/%{name}-%{version}/atril %files libs @@ -173,4 +185,9 @@ %{_libdir}/girepository-1.0/AtrilView-1.5.0.typelib +%files data -f atril.lang +%doc %{_docdir}/%{name}-%{version}/atril/atril.html +%doc %{_docdir}/%{name}-%{version}/atril/atril_start_window.png +%{_datadir}/mate/help/atril/ + %files devel %dir %{_includedir}/atril/ @@ -188,4 +205,11 @@ %changelog +* Sat May 11 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-4 +- remove gsettings convert file +- create -data noarch subpackage +- move docs in -data subpackage +- move help dir in -data subpackage +- move locale in -data subpackage + * Fri May 10 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-3 - remove -dvi, -djvu, -xps subpackages and move the libs to -libs subpackage Requires -------- mate-document-viewer-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) mate-document-viewer(x86-64) pkgconfig(atril-document-1.5.0) pkgconfig(gio-2.0) pkgconfig(gthread-2.0) pkgconfig(gtk+-2.0) mate-document-viewer-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libarchive.so.13()(64bit) libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdjvulibre.so.21()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgailutil.so.18()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libgxps.so.2()(64bit) libkpathsea.so.6()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpoppler-glib.so.8()(64bit) libpthread.so.0()(64bit) libspectre.so.1()(64bit) libstdc++.so.6()(64bit) libt1.so.5()(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) mate-document-viewer(x86-64) rtld(GNU_HASH) mate-document-viewer-caja (rpmlib, GLIBC filtered): libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcaja-extension.so.1()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libz.so.1()(64bit) mate-document-viewer(x86-64) mate-file-manager rtld(GNU_HASH) mate-document-viewer (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgailutil.so.18()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libmate-keyring.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libz.so.1()(64bit) mate-document-viewer-data mate-document-viewer-libs(x86-64) rtld(GNU_HASH) Provides -------- mate-document-viewer-devel: mate-document-viewer-devel mate-document-viewer-devel(x86-64) pkgconfig(atril-document-1.5.0) pkgconfig(atril-view-1.5.0) mate-document-viewer-libs: libatrildocument.so.3()(64bit) libatrilview.so.3()(64bit) libcomicsdocument.so()(64bit) libdjvudocument.so()(64bit) libdvidocument.so()(64bit) libpdfdocument.so()(64bit) libpsdocument.so()(64bit) libtiffdocument.so()(64bit) libxpsdocument.so()(64bit) mate-document-viewer-libs mate-document-viewer-libs(x86-64) mate-document-viewer-caja: libatril-properties-page.so()(64bit) mate-document-viewer-caja mate-document-viewer-caja(x86-64) mate-document-viewer: mate-document-viewer mate-document-viewer(x86-64) mimehandler(application/oxps) mimehandler(application/pdf) mimehandler(application/postscript) mimehandler(application/vnd.ms-xpsdocument) mimehandler(application/x-bzdvi) mimehandler(application/x-bzpdf) mimehandler(application/x-bzpostscript) mimehandler(application/x-cb7) mimehandler(application/x-cbr) mimehandler(application/x-cbt) mimehandler(application/x-cbz) mimehandler(application/x-dvi) mimehandler(application/x-gzdvi) mimehandler(application/x-gzpdf) mimehandler(application/x-gzpostscript) mimehandler(image/tiff) mimehandler(image/vnd.djvu) mimehandler(image/x-bzeps) mimehandler(image/x-eps) mimehandler(image/x-gzeps) Unversioned so-files -------------------- mate-document-viewer-libs: /usr/lib64/atril/3/backends/libcomicsdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libdjvudocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libdvidocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpdfdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libpsdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libtiffdocument.so mate-document-viewer-libs: /usr/lib64/atril/3/backends/libxpsdocument.so mate-document-viewer-caja: /usr/lib64/caja/extensions-2.0/libatril-properties-page.so Source checksums ---------------- http://pub.mate-desktop.org/releases/1.6/mate-document-viewer-1.6.0.tar.xz : CHECKSUM(SHA256) this package : 40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf CHECKSUM(SHA256) upstream package : 40d2dcc9dcfafff567dd23870202d826ddab305ed0626b4a890d88ef6b1b5ccf Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/bin/fedora-review -b 924310 This package is APPROVED.
Thank you Alex for review. New Package SCM Request ======================= Package Name: mate-document-viewer Short Description: Document viewer Owners: raveit65 Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
mate-document-viewer-1.6.0-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-document-viewer-1.6.0-5.fc18
mate-document-viewer-1.6.0-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mate-document-viewer-1.6.0-5.fc19
mate-document-viewer-1.6.0-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-document-viewer-1.6.0-5.fc17
mate-document-viewer-1.6.0-5.fc19 has been pushed to the Fedora 19 testing repository.
mate-document-viewer-1.6.0-5.fc18 has been pushed to the Fedora 18 stable repository.
mate-document-viewer-1.6.0-5.fc17 has been pushed to the Fedora 17 stable repository.
mate-document-viewer-1.6.0-5.fc19 has been pushed to the Fedora 19 stable repository.