Bug 927033 - repo group and consumer group association/unassociate api's have inconsistent return data
Summary: repo group and consumer group association/unassociate api's have inconsistent...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: API/integration
Version: 2.0.6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 2.2.0
Assignee: Sayli Karmarkar
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks: 950743
TreeView+ depends on / blocked
 
Reported: 2013-03-24 23:58 UTC by Justin Sherrill
Modified: 2015-03-23 01:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-10 15:44:51 UTC
Embargoed:


Attachments (Terms of Use)

Description Justin Sherrill 2013-03-24 23:58:13 UTC
Using:

pulp-server-2.0.6-1.noarch

and based on the docs:

https://pulp-dev-guide.readthedocs.org/en/latest/rest-api/repo/groups/members.html
& 
https://pulp-dev-guide.readthedocs.org/en/latest/rest-api/consumer/group/membership.html


These two sets of api calls do very similar things (associate/unassociate items with a group).  Their return values are completely different.

Repo Group associate/unassociate seems to return "list of repository IDs for all repositories in the group" (the state of the group after the add or remove).  

Consumer group associate/unassociate seems to return 'a list of matched consumer IDs'  (what was added or removed)

In every other way these two sets of api calls behave exactly the same.  It would be very nice if the return data was the same too!

-Justin

Comment 1 Sayli Karmarkar 2013-05-28 23:55:37 UTC
commit fd3c5b1dc8abd93d471b3b4f8ce49ed96c2ff9c1
Author: Sayli Karmarkar <skarmark>
Date:   Tue May 28 16:50:43 2013 -0700

    927033 - updating consumer group associate and unassociate calls to return a list of all consumers belonging to consumer group similar to repo group membership instead of just those satisfied by the search criteria

Comment 2 Sayli Karmarkar 2013-06-04 07:38:12 UTC
Merged to master.

Comment 3 Jeff Ortel 2013-06-06 16:20:11 UTC
build: 2.2.0-0.2.beta.

Some of these were likely included in an earlier build but found them this time with a better BZ query.

Comment 4 Sayli Karmarkar 2013-06-21 19:23:48 UTC
Updated consumer group associate and unassociate calls to return a list of all consumers belonging to consumer group similar to repo group membership instead of just those satisfied by the search criteria

For testing please test following api- 

https://pulp-dev-guide.readthedocs.org/en/latest/integration/rest-api/consumer/group/membership.html

The documentation is updated as well. 

Before this bugfix consumer group associate and unassociate apis were returning the consumer that matched criteria specified in the input to the api.

Comment 5 Sayli Karmarkar 2013-06-21 19:25:05 UTC
API documentation of how it worked before the bugfix - https://pulp-dev-guide.readthedocs.org/en/latest/rest-api/consumer/group/membership.html

Comment 6 Preethi Thomas 2013-06-25 17:23:06 UTC
verified

Comment 7 Preethi Thomas 2013-09-10 15:44:51 UTC
2.2 released
http://repos.fedorapeople.org/repos/pulp/pulp/stable/2.2/


Note You need to log in before you can comment on or make changes to this bug.