Bug 927422 - GlusterFileSystem.getDefaultBlockSize() is hardcoded
Summary: GlusterFileSystem.getDefaultBlockSize() is hardcoded
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: GlusterFS
Classification: Community
Component: gluster-hadoop
Version: mainline
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ---
Assignee: Jay Vyas
QA Contact: hcfs-gluster-bugs
URL:
Whiteboard:
: 927391 927411 (view as bug list)
Depends On:
Blocks: HCFS
TreeView+ depends on / blocked
 
Reported: 2013-03-25 21:13 UTC by Steve Watt
Modified: 2013-11-13 15:50 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-13 15:50:46 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Steve Watt 2013-03-25 21:13:24 UTC
Description of problem:

The DistributedFileSystem class reads the blocksize from the properties file

 defaultBlockSize = conf.getLong("dfs.block.size", DEFAULT_BLOCK_SIZE);

We should investigate what the impact is of hardcoding this value and whether we should implement the same behavior as the DistributedFileSystem class.

Comment 2 Jay Vyas 2013-04-29 19:45:47 UTC
Since we don't actually have blocks, I think that this is not a bug.

Comment 3 Jay Vyas 2013-04-29 19:59:58 UTC
*** Bug 927391 has been marked as a duplicate of this bug. ***

Comment 4 Jay Vyas 2013-04-29 20:00:25 UTC
Since we don't actually have blocks, I think that this is not a bug.

Comment 5 Jay Vyas 2013-04-29 20:01:40 UTC
Steve's Comments in 927391: 

"GlusterFileSystem.getFileStatus() first determines if the object is a file or a directory. If it is a file it returns a new FileStatus objection and passes in 0 for the third parameter, which is the block replication factor. This should be passing in the replica factor set on the volume as indicated by the same methods implementation in the DistributedFileSystem class. To date, we have seen no actual errors with the 0 replica setting, but we need to understand where this gets called by the computational layers, how it gets used and the impact of leaving this hardcoded."

So - clearly we need an understanding of how blcoks/replicas work in addition to a rationale for the block size = 0 .

Comment 6 Jay Vyas 2013-04-29 20:03:15 UTC
*** Bug 927411 has been marked as a duplicate of this bug. ***

Comment 7 Jay Vyas 2013-04-29 21:53:16 UTC
Marking this as low priority since it is research-oriented and doesnt' constitute a bug

Comment 8 Bradley Childs 2013-11-13 15:50:46 UTC
Dynamically determining the block size doesn't seem practical or overly beneficial. 

Per bug triage discussion, moving to close this bug.  We can reopen if we later find this is an issue with reproduce case.


Note You need to log in before you can comment on or make changes to this bug.