Bug 927504 - [ja_JP] [Admin Portal] Truncation 'Login' button and 'Dev.Size' column name in 'New Domain' dialog.
Summary: [ja_JP] [Admin Portal] Truncation 'Login' button and 'Dev.Size' column name i...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.2.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
: 3.2.0
Assignee: Daniel Erez
QA Contact: Yuko Katabami
URL:
Whiteboard: storage
: 949848 949850 (view as bug list)
Depends On:
Blocks: 948448
TreeView+ depends on / blocked
 
Reported: 2013-03-26 05:43 UTC by Lijun Li
Modified: 2016-02-10 20:21 UTC (History)
12 users (show)

Fixed In Version: sf16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Truncation 'Login' button and 'Dev.Size' column name in 'New Domain' dialog (70.50 KB, image/png)
2013-03-26 05:46 UTC, Lijun Li
no flags Details
Not fixed - Truncation Login button and unlocalized tooltips (57.77 KB, image/png)
2013-05-06 06:30 UTC, Lijun Li
no flags Details
Fixed - Image Login button and tooltips (53.87 KB, image/png)
2013-05-10 08:54 UTC, Lijun Li
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 13891 0 None None None Never
oVirt gerrit 13892 0 None None None Never
oVirt gerrit 14500 0 None None None Never

Description Lijun Li 2013-03-26 05:43:00 UTC
Description of problem:
In Storage tab, truncation 'Login' button and 'Dev.Size' column name in 'New Domain' dialog.

Version-Release number of selected component (if applicable):
rhevm-webadmin-portal-3.2.0-10.10.beta1.el6ev.noarch


How reproducible:
100%

Steps to Reproduce:
1. Login Admin Portal.
2. Select Storage tab and click New Domain button.
3. Click Targets>Luns->'-' Target Name.
  
Actual results:
Truncation 'Login' button and 'Dev.Size' column name in 'New Domain' dialog.

Expected results:
No truncation.

Additional info:

Comment 1 Lijun Li 2013-03-26 05:46:00 UTC
Created attachment 716336 [details]
Truncation 'Login' button and 'Dev.Size' column name in 'New Domain' dialog

Comment 2 Ayal Baron 2013-04-03 08:11:16 UTC
Einav, another one.
I think we should consider a general solution for this issue

Comment 3 Einav Cohen 2013-04-11 20:36:58 UTC
Regarding the button: currently, its width is set to be 52px hardcoded (see [1]) -  there is a chance that the 'width' attribute of this button should be removed completely (a similar solution for a similar problem was done in [2]) or extend the width to accommodate the longest possible string.
[the relevant column (that contains this button) might need to have its width extended accordingly as well]
[putting 'needinfo' on Derez for his thoughts]

Regarding the column: see bug 922731, comment #3


[1] SanStorageTargetToLunList.java, addLoginButton method:
...
loginButton.setWidth("52px"); //$NON-NLS-1$
...

[2] http://gerrit.ovirt.org/#/c/13194/

Comment 4 Daniel Erez 2013-04-13 09:50:09 UTC
(In reply to comment #3)
> Regarding the button: currently, its width is set to be 52px hardcoded (see
> [1]) -  there is a chance that the 'width' attribute of this button should
> be removed completely (a similar solution for a similar problem was done in
> [2]) or extend the width to accommodate the longest possible string.
> [the relevant column (that contains this button) might need to have its
> width extended accordingly as well]
> [putting 'needinfo' on Derez for his thoughts]
> 
> Regarding the column: see bug 922731, comment #3
> 
> 
> [1] SanStorageTargetToLunList.java, addLoginButton method:
> ...
> loginButton.setWidth("52px"); //$NON-NLS-1$
> ...
> 
> [2] http://gerrit.ovirt.org/#/c/13194/

In this case, removing the width could be sufficient along with a few style adjustments (since the button resides inside a complex widget). But the issue is far more problematic in other languages in which "Login" translation is very wide. We might need an alternative solution, e.g. an image button instead of text.

Comment 5 Daniel Erez 2013-04-15 08:50:56 UTC
*** Bug 949850 has been marked as a duplicate of this bug. ***

Comment 6 Daniel Erez 2013-04-15 08:51:13 UTC
*** Bug 949848 has been marked as a duplicate of this bug. ***

Comment 7 Lijun Li 2013-05-06 06:27:51 UTC
It's not fully fixed on sf15 build: 3.2.0-10.21.master.el6ev

'Dev.Size' column name truncation fixed but not fixed the truncation 'Login' button and unlocalized tooltips.

Please refer to the attached screenshot.

Moving to ASSIGNED.

Comment 8 Lijun Li 2013-05-06 06:30:22 UTC
Created attachment 743982 [details]
Not fixed - Truncation Login button and unlocalized tooltips

Comment 9 Lijun Li 2013-05-10 08:52:07 UTC
Verified, it's fixed on sf16 build: 3.2.0-10.25.beta3.el6ev

Please refer to the attached screenshot.

Comment 10 Lijun Li 2013-05-10 08:54:43 UTC
Created attachment 745996 [details]
Fixed - Image Login button and tooltips

Comment 11 Itamar Heim 2013-06-11 09:08:06 UTC
3.2 has been released

Comment 12 Itamar Heim 2013-06-11 09:08:10 UTC
3.2 has been released

Comment 13 Itamar Heim 2013-06-11 09:08:13 UTC
3.2 has been released

Comment 14 Itamar Heim 2013-06-11 09:36:41 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.