Bug 929005 - (awestruct) Review Request: rubygem-awestruct - A framework for creating static HTML sites
Review Request: rubygem-awestruct - A framework for creating static HTML sites
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Will Benton
Fedora Extras Quality Assurance
:
Depends On: 982679
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2013-03-28 21:29 EDT by Dan Allen
Modified: 2014-07-24 23:19 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-12-17 13:05:20 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Dan Allen 2013-03-28 21:29:21 EDT
Repository: https://github.com/awestruct/rubygem-awestruct-rpm
Spec URL: https://raw.github.com/awestruct/rubygem-awestruct-rpm/master/rubygem-awestruct.spec
SRPM URL: https://github.com/awestruct/rubygem-awestruct-rpm/raw/master/srpms/rubygem-awestruct-0.5.0-1.fc18.src.rpm
Description: Awestruct is a framework for creating static HTML sites.
Fedora Account System Username: mojavelinux

Note that this package depends on the acceptance of the rubygem-bootstrap-sass package tracked by: https://bugzilla.redhat.com/show_bug.cgi?id=920436
Comment 1 Will Benton 2013-11-01 15:32:34 EDT
There are a couple of issues with this package so far:

1.  Missing BuildRequires (some of these were given as Requires):  git, js, coffee-script, nokogiri, rubygem-git, rubygem-compass, rubygem-compass-960-plugin, rubygem-bootstrap-sass, rubygem-asciidoctor, rubygems-devel, rubygem-coffee-script, rubygem-hashery, rubygem-RedCloth, rubygem-slim, rubygem-redcarpet, rubygem-rdiscount, rubygem-mustache, rubygem-uglifier.
2.  spec/config_spec.rb requires both a Rakefile and a Gemfile in order to pass under rpmbuild (it still doesn't pass under mock and I'm trying to figure out why)

I've updated the spec with these changes (and a version bump); my revised version is here:  https://gist.github.com/willb/7270668.  Once you've fixed the test suite running under mock (either by figuring out where it's going wrong or by disabling config_spec.rb), send me an updated spec and I'll resume the review.

Thanks!
Comment 2 Will Benton 2013-12-10 12:55:38 EST
This review is stalled; I'd appreciate a response soon.
Comment 3 Will Benton 2013-12-17 13:05:20 EST
I'm closing this bug per the stalled package review process.  If someone else wants to pick it up, let me know and I'll review it.

Note You need to log in before you can comment on or make changes to this bug.