Bug 947449 - Review Request: perl-ExtUtils-Config - A wrapper for perl's configuration
Summary: Review Request: perl-ExtUtils-Config - A wrapper for perl's configuration
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 947454
TreeView+ depends on / blocked
 
Reported: 2013-04-02 13:01 UTC by Paul Howarth
Modified: 2013-04-24 16:55 UTC (History)
3 users (show)

Fixed In Version: perl-ExtUtils-Config-0.007-2.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-24 16:55:09 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2013-04-02 13:01:36 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-ExtUtils-Config/branches/fedora/perl-ExtUtils-Config.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-ExtUtils-Config/perl-ExtUtils-Config-0.007-2.fc20.src.rpm

Description:
ExtUtils::Config is an abstraction around the %Config hash.

Fedora Account System Username: pghmcfc

Comment 1 Petr Šabata 2013-04-08 14:33:08 UTC
This is apparently going to epel5, too.
Everything seems good to me, approving.

I like to require perl(strict) and perl(warnings) as well since there's no real difference between pragmas and modules.  The same applies to 'perl' itself -- it gets called during the build but is not guaranteed to be in the buildroot.
I understand some may view this as extreme; just wanted to note that :)

Comment 2 Paul Howarth 2013-04-08 14:41:12 UTC
(In reply to comment #1)
> This is apparently going to epel5, too.

Yes, I try to make everything EL-5 compatible unless there's some requirement that can't be satisfied there, such as requiring a later version of a module that's bundled with perl in EL-5.

> Everything seems good to me, approving.

Thanks.

> I like to require perl(strict) and perl(warnings) as well since there's no
> real difference between pragmas and modules.  The same applies to 'perl'
> itself -- it gets called during the build but is not guaranteed to be in the
> buildroot.
> I understand some may view this as extreme; just wanted to note that :)

Yes, I do think it's a bit extreme, but at least it's consistent.

I draw the line myself with modules/pragmas that are dual-lived: if they're dual-lived then I specify them explicitly, otherwise I don't. As for the perl dependency, well if perl(ExtUtils::MakeMaker) or its equivalent doesn't pull it in as a dependency then I think we'll have a lot of FTBFS packages. I can't really envisage any sane way of packaging perl where that dependency wouldn't be present.

Comment 3 Paul Howarth 2013-04-08 14:44:59 UTC
New Package SCM Request
=======================
Package Name: perl-ExtUtils-Config
Short Description: A wrapper for perl's configuration
Owners: pghmcfc
Branches: el5 el6 f17 f18 f19
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2013-04-08 15:02:38 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-04-08 18:08:25 UTC
perl-ExtUtils-Config-0.007-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-ExtUtils-Config-0.007-2.fc18

Comment 6 Fedora Update System 2013-04-08 18:08:41 UTC
perl-ExtUtils-Config-0.007-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-ExtUtils-Config-0.007-2.el6

Comment 7 Fedora Update System 2013-04-08 18:09:00 UTC
perl-ExtUtils-Config-0.007-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-ExtUtils-Config-0.007-2.el5

Comment 8 Fedora Update System 2013-04-08 18:09:14 UTC
perl-ExtUtils-Config-0.007-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-ExtUtils-Config-0.007-2.fc17

Comment 9 Fedora Update System 2013-04-08 18:09:31 UTC
perl-ExtUtils-Config-0.007-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-ExtUtils-Config-0.007-2.fc19

Comment 10 Fedora Update System 2013-04-18 02:27:03 UTC
perl-ExtUtils-Config-0.007-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 11 Fedora Update System 2013-04-18 02:45:15 UTC
perl-ExtUtils-Config-0.007-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 12 Fedora Update System 2013-04-20 19:32:19 UTC
perl-ExtUtils-Config-0.007-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 13 Fedora Update System 2013-04-24 16:47:10 UTC
perl-ExtUtils-Config-0.007-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 14 Fedora Update System 2013-04-24 16:47:55 UTC
perl-ExtUtils-Config-0.007-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.