Bug 947454 - Review Request: perl-ExtUtils-InstallPaths - Build.PL install path logic made easy
Summary: Review Request: perl-ExtUtils-InstallPaths - Build.PL install path logic made...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 947449
Blocks: 947455
TreeView+ depends on / blocked
 
Reported: 2013-04-02 13:09 UTC by Paul Howarth
Modified: 2013-05-02 20:42 UTC (History)
3 users (show)

Fixed In Version: perl-ExtUtils-InstallPaths-0.009-3.fc19
Clone Of:
Environment:
Last Closed: 2013-05-02 20:42:26 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2013-04-02 13:09:04 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-ExtUtils-InstallPaths/branches/fedora/perl-ExtUtils-InstallPaths.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-ExtUtils-InstallPaths/perl-ExtUtils-InstallPaths-0.009-2.fc20.src.rpm

Description:
This module tries to make install path resolution as easy as possible.

When you want to install a module, it needs to figure out where to install
things. The nutshell version of how this works is that default installation
locations are determined from ExtUtils::Config, and they may be individually
overridden by using the install_path attribute. An install_base attribute lets
you specify an alternative installation root like /home/foo and prefix does
something similar in a rather different (and more complicated) way. destdir
lets you specify a temporary installation directory like /tmp/install in case
you want to create bundled-up installable packages.

Fedora Account System Username: pghmcfc

Comment 1 Petr Šabata 2013-04-16 14:26:32 UTC
Alright, no issues, approving.

By the way, I see you explicitly buildrequire non-duallive modules, such as perl(Config).  While I certainly welcome that, it somewhat contradicts what you said the other day.  You could, to unify your style, either drop it or require the rest as well.

Comment 2 Paul Howarth 2013-04-16 15:18:08 UTC
(In reply to comment #1)
> Alright, no issues, approving.
> 
> By the way, I see you explicitly buildrequire non-duallive modules, such as
> perl(Config).  While I certainly welcome that, it somewhat contradicts what
> you said the other day.  You could, to unify your style, either drop it or
> require the rest as well.

A couple slipped through there. I'll get rid of the Config and File::Find buildreqs. Thanks for the review.

Comment 3 Paul Howarth 2013-04-16 15:19:34 UTC
New Package SCM Request
=======================
Package Name: perl-ExtUtils-InstallPaths
Short Description: Build.PL install path logic made easy
Owners: pghmcfc
Branches: el5 el6 f17 f18 f19
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2013-04-16 15:39:06 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-04-16 18:15:25 UTC
perl-ExtUtils-InstallPaths-0.009-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-ExtUtils-InstallPaths-0.009-3.el6

Comment 6 Fedora Update System 2013-04-16 18:15:41 UTC
perl-ExtUtils-InstallPaths-0.009-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-ExtUtils-InstallPaths-0.009-3.fc18

Comment 7 Fedora Update System 2013-04-16 18:15:51 UTC
perl-ExtUtils-InstallPaths-0.009-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-ExtUtils-InstallPaths-0.009-3.el5

Comment 8 Fedora Update System 2013-04-16 18:16:03 UTC
perl-ExtUtils-InstallPaths-0.009-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-ExtUtils-InstallPaths-0.009-3.fc17

Comment 9 Fedora Update System 2013-04-16 18:16:16 UTC
perl-ExtUtils-InstallPaths-0.009-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-ExtUtils-InstallPaths-0.009-3.fc19

Comment 10 Fedora Update System 2013-04-22 00:40:07 UTC
perl-ExtUtils-InstallPaths-0.009-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 11 Fedora Update System 2013-04-26 00:55:13 UTC
perl-ExtUtils-InstallPaths-0.009-3.fc17 has been pushed to the Fedora 17 stable repository.

Comment 12 Fedora Update System 2013-04-26 01:03:48 UTC
perl-ExtUtils-InstallPaths-0.009-3.fc18 has been pushed to the Fedora 18 stable repository.

Comment 13 Fedora Update System 2013-05-02 19:52:05 UTC
perl-ExtUtils-InstallPaths-0.009-3.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 14 Fedora Update System 2013-05-02 19:53:03 UTC
perl-ExtUtils-InstallPaths-0.009-3.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.