Description of problem: After installation of xscreensaver with all plugins in Fedora 18-XFCE the section 'Others' shows the xscreensaver-plugins Version-Release number of selected component (if applicable): Xscreensaver v5.21.2.fc18 Panel How reproducible: Use the Fedora-18 XFCE Edition. 64bit or 32bit doesn't matter. Steps to Reproduce: 1.yum install xscreensaver* -y 2.logout from your account 3.relogin 4.look into your xfce-panel Actual results: The section 'others' in the panel shows the xscreensaver-plugins Expected results: No entries in the panel Additional info:
This error is with the live-cd of Fedora 18-xfce repoducable.
xscreensaver is shipping those desktop files and Xfce is showing them. Per: http://standards.freedesktop.org/menu-spec/latest/apas03.html it seems Xfce does not yet support the "Screensaver" category, so those files should include a 'OnlyShowIn=GNOME' or something. Moving over to xscreensaver component for comment.
The files in question are in the xscreensaver-extras-gss and xscreensaver-gl-extras-gss package. You should not install them, they are only needed for compatibility with gnome-screensaver, to make the xscreensavers show up in gnome-screensaver-preferences and possibly KDE's screensaver caplet. Run "yum install xscreensaver" instead of "yum install xscreensaver*". There is a reason the *-gss packages are not pulled in by the xscreensaver meta package. However I think there are two problems here: 1. Even if installed they should not show up. We should exclude them from the menu in garcon. IIRC upstream Xfce uses a folder under Preferences and we remove it as part of our redhat-menus.patch. We need to exclude screensavers from the "Other" group in /etc/xdg/menus/xfce4-applications.menu. 2. The menu entries seem broken. They are created on the fly in the spec with a function called create_desktop(), see http://pkgs.fedoraproject.org/cgit/xscreensaver.git/tree/xscreensaver.spec#n671 The parsing seems broken for the files in the xscreensaver-gl-extras-gss package. The entries have names like »Foo" gl="yes"«. I'm not sure the files should be shown in the menu at all, regardless of the desktop. Given they are still displayed in gnome-screensaver-prpoperties they should probably have "NoDisplay=true", see http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html. Having screensavers in the menu is completely useless. Before I fix garcon, I'd like to hear what Mamoru thinks.
The format of desktop files in -gss packages imitates the one of screensaver desktop files in gnome-screensaver 2.14(!). In my recognition GNOME 3 no longer uses these desktop files: GNOME 3 "screensaver" shows only blank screen and does not launch any hacks. Now mate-screensaver can use these desktop files. KDE ships desktop files for xscreensaver in kdeartwork-screensavers rpm and so KDE probably does not use desktop files in xscreensaver-foo-gss (but can use xscreensaver hacks). So currently if mate-screensaver can use desktop files in xscreensaver-foo-gss even with adding "NoDisplay=true", I am okay with this. Note that screensaver desktop files in mate-screensaver do not have "NoDisplay=true", instead they have "OnlyShowIn=MATE;". I am not sure if which is preferable. Dan, some opinion?
By the way for broken entry name issue, I will fix later.
For now I will add OnlyShowIn=GNOME;MATE;
xscreensaver-5.21-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/xscreensaver-5.21-3.fc19
xscreensaver-5.21-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/xscreensaver-5.21-3.fc18
xscreensaver-5.21-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xscreensaver-5.21-3.fc17
Package xscreensaver-5.21-3.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing xscreensaver-5.21-3.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-6160/xscreensaver-5.21-3.fc17 then log in and leave karma (feedback).
I'm not sure why I was CC'd on this bug. MATE has its own screensaver package... "mate-screensaver" and does not depend on xscreensaver.
mate-screensaver (as well as gnome-screensaver 2.x) has mechanism to use xscreensaver hacks, see --with-xscreensaverhackdir option or so on mate-screensaver 1.6.0 (i.e. if xscreensaver-extras or so are optionally installed, mate-screensaver has mechanism to use those hacks) Note that you seems to have killed these options per: http://pkgs.fedoraproject.org/cgit/mate-screensaver.git/commit/?id=ce9d50a03ceaf0e9048dbfc2fd4722b34dd9de22 , however mate-screensaver can still use xscreensaver hacks, see: https://github.com/mate-desktop/mate-screensaver/blob/master/src/gs-theme-manager.c#L62 And xscreensaver-foo-gss packages installs desktop files under %_datadir/applications/screensavers so that mate-screensaver can use these desktop files.
Thanks for the clarification.
By the way, I think it is preferable that mate-screensaver explicitly specifies --with-xscreensaverdir and --with-xscreensaverhackdir again
Looking into it.. currently mate-desktop.org is down. :(
Can you rebuild xscreensaver on rawhide please?
5.21-3 already hit rawhide so I don't think more rebuild is needed (for this issue): http://permalink.gmane.org/gmane.linux.redhat.fedora.testers/105662
fc19 != rawhide https://koji.fedoraproject.org/koji/packageinfo?packageID=4259
Dan, please check the latest package for rawhide by koji latest-pkg command.
And again, 5.21-3 already appears on rawhide.
$ cat /etc/redhat-release Fedora release 20 (Rawhide) # yum clean all Loaded plugins: fastestmirror, langpacks, refresh-packagekit Cleaning repos: rawhide Cleaning up everything Cannot remove rpmdb file /var/lib/yum/rpmdb-indexes/obsoletes Cannot remove rpmdb file /var/lib/yum/rpmdb-indexes/pkgtups-checksums Cannot remove rpmdb file /var/lib/yum/rpmdb-indexes/file-requires Cannot remove rpmdb file /var/lib/yum/rpmdb-indexes/conflicts Cannot remove rpmdb file /var/lib/yum/rpmdb-indexes/version Cleaning up list of fastest mirrors $ yum info xscreensaver Loaded plugins: fastestmirror, langpacks, refresh-packagekit Loading mirror speeds from cached hostfile * rawhide: mirrors.kernel.org Installed Packages Name : xscreensaver Arch : x86_64 Epoch : 1 Version : 5.21 Release : 2.fc19 Size : 0.0 Repo : installed From repo : rawhide Summary : X screen saver and locker URL : http://www.jwz.org/xscreensaver/ License : MIT Description : A modular screen saver and locker for the X Window System. : More than 200 display modes are included in this package. : : This is a metapackage for installing all default packages : related to XScreenSaver. Again, Please build this on *FC20* $ koji latest-build rawhide xscreensaver Build Tag Built by ---------------------------------------- -------------------- ---------------- xscreensaver-5.21-3.fc19 f20 mtasaka
Speaking of which, I'm not sure why you're not getting autoqa errors either. Anyways this causes conflicts (2 screensaver entries appear in system menu) with mate-screensaver with the hack flags added and I'm considering adding a conflicts to mate-screensaver for xscreensaver. Opening the 2nd screensaver menu asks me to start xscreensaver daemon (which I don't want to do) since I have my own daemon for that already. All I asked you to do was git pull -> fedpkg switch branch master -> git merge master f19 -> fedpkg push -> fedpkg build. Go install mate and test and fix it yourself. It's not my problem anymore and I'm tired of bickering with you about rawhide. Here is the build: https://koji.fedoraproject.org/koji/taskinfo?taskID=5284402
(In reply to comment #22) ...snip... > Anyways this causes conflicts (2 screensaver entries appear in system menu) > with mate-screensaver with the hack flags added and I'm considering adding a > conflicts to mate-screensaver for xscreensaver. ...snip... Conflicts are not a good answer at all. Please see: https://fedoraproject.org/wiki/Packaging:Conflicts
(In reply to comment #23) > (In reply to comment #22) > ...snip... > > Anyways this causes conflicts (2 screensaver entries appear in system menu) > > with mate-screensaver with the hack flags added and I'm considering adding a > > conflicts to mate-screensaver for xscreensaver. > ...snip... > > Conflicts are not a good answer at all. Please see: > https://fedoraproject.org/wiki/Packaging:Conflicts Okay, but that doesn't really help the actual conflict right now.
(In reply to comment #22) > Anyways this causes conflicts (2 screensaver entries appear in system menu) > with mate-screensaver with the hack flags added and I'm considering adding a > conflicts to mate-screensaver for xscreensaver. See bug 530318 . gnome-screensaver 2.x has always added gnome-screensaver-hide-xscreensaver.menu and mate-screensaver should follow that.
Why isn't this fixed upstream 4 years later yet?
Upstream? xscreensaver won't have this file of course, I am not sure about gnome-screensaver upstream (note that of course gnome-screensaver 2.x is out of date for gnome-screensaver). I don't know about mate-screensaver upstream. If you want you can ask mate-screensaver upstream.
I am speaking with them now.
(In reply to comment #28) > I am speaking with them now. Okay, thank you.
xscreensaver-5.21-5.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
xscreensaver-5.21-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
xscreensaver-5.21-5.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
Thank you. The problem is solved.