Spec URL: https://aalvarez.web.cern.ch/aalvarez/fedora/edg-mkgridmap.spec SRPM URL: https://aalvarez.web.cern.ch/aalvarez/fedora/edg-mkgridmap-4.0.0-2.src.rpm Description: edg-mkgridmap is a tool to build the grid-mapfile from VO servers, taking into account both VO and local policies. Fedora Account System Username: aalvarez rpmlint output -------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Build on EPEL6 -------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=5313476 Build on Fedora 20 ------------------ http://koji.fedoraproject.org/koji/taskinfo?taskID=5313497
Hi, I take the responsability ofthis review. I get a failure on EL5, you don't want to pacakge this software for EL5 ? http://koji.fedoraproject.org/koji/taskinfo?taskID=5346381 First informal review : - your patch for forcing the %doc macro is not needed, you can just use the %{_docdir} macro. - The %dir need to be used to define the ownership of %{_libexecdir}/edg-mkgridmap to your package Regards, Adrien
Hi, It wasn't building in EL5 because I did a rpmbuild instead of a rpmbuild-md5. Sorry about that. I attach the new spec and srpm with the fix for the directory. I think the patch is appropriate, since the installation location in the Makefile is /usr/share/doc/edg-mkgridmap, without the version. Spec URL: https://aalvarez.web.cern.ch/aalvarez/fedora/edg-mkgridmap.spec SRPM URL: https://aalvarez.web.cern.ch/aalvarez/fedora/edg-mkgridmap-4.0.0-3.src.rpm EL5: http://koji.fedoraproject.org/koji/taskinfo?taskID=5346505 EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=5346507 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5346509
> I attach the new spec and srpm with the fix for the directory. I think the patch is appropriate, since the installation location in the Makefile is /usr/share/doc/edg-mkgridmap, without the version. That's fine for me, I was just thinking that you deleted the standard install of doc just in order to use the %doc macro. Formal review : OK: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. rpmlint edg-mkgridmap-4.0.0-3.* edg-mkgridmap.noarch: W: manpage-not-compressed bz2 /usr/share/man/man5/edg-mkgridmap.conf.5.gz edg-mkgridmap.noarch: W: manpage-not-compressed bz2 /usr/share/man/man8/edg-mkgridmap.8.gz 2 packages and 0 specfiles checked; 0 errors, 2 warnings. -> minor warnings, ignored OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. -> Source tarballs are made on the fly, md5sum can't match -> done with diff diff edg-mkgridmap/ edg-mkgridmap-4.0.0-3.src/edg-mkgridmap/ diff edg-mkgridmap/configure.in edg-mkgridmap-4.0.0-3.src/edg-mkgridmap/configure.in 3c3 < CVS_TAG='$Name: $' --- > CVS_TAG='$Name: v4_0_0 $' -> result acceptable OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. -> EL5 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5391300 -> EL6 : http://koji.fedoraproject.org/koji/taskinfo?taskID=5391302 -> rawhide : http://koji.fedoraproject.org/koji/taskinfo?taskID=5391296 OK: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. N/A: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. N/A: Packages must NOT bundle copies of system libraries. OK: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. N/A: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. N/A: Static libraries must be in a -static package. OK: Development files must be in a -devel package. OK: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} N/A: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. N/A: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. OK: All filenames in rpm packages must be valid UTF-8. OK: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. OK: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK: The reviewer should test that the package builds in mock. mock -r epel-5-x86_64 edg-mkgridmap-4.0.0-3.src.rpm INFO: Done(edg-mkgridmap-4.0.0-3.src.rpm) Config(epel-5-x86_64) 2 minutes 10 seconds INFO: Results and/or logs in: /var/lib/mock/epel-5-x86_64/result OK: The package should compile and build into binary rpms on all supported architectures. OK: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. /usr/sbin/edg-mkgridmap --help edg-mkgridmap [--help] [--version] [--conf=<config_file>] [--output[=<output_file>]] [--quiet] [--verbose] [--safe] [--nosafe] [--cache] [--nocache] [--proxy] [--noproxy] [--usermode] man edg-mkgridmap NAME edg-mkgridmap - a tool to build the grid-mapfile --> OK N/A: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. N/A: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. N/A: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. -> man page provided Package accepted :)
New Package SCM Request ======================= Package Name: edg-mkgridmap Short Description: Tool to build the grid map-file from VO servers Owners: aalvarez Branches: el5 el6 f17 f18 f19 InitialCC: aalvarez
Git done (by process-git-requests).
> %dir %{_libexecdir}/edg-mkgridmap > %{_libexecdir}/edg-mkgridmap > %{_libexecdir}/edg-mkgridmap/edg-mkgridmap.pl https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership There's some confusion in this %files section. If %{_libexecdir}/edg-mkgridmap is a directory, the %files entry %{_libexecdir}/edg-mkgridmap includes the directory (as %dir) *and* everything in it, i.e. the entire tree of files and directories with proper %dir attributes where necessary. So, instead of the three lines as present, you either want %dir %{_libexecdir}/edg-mkgridmap %{_libexecdir}/edg-mkgridmap/edg-mkgridmap.pl to be explicit about dir ownership and the Perl script. Or just %{_libexecdir}/edg-mkgridmap/ to include the full directory tree. The trailing slash is optional, but increases spec file readability (by making more clear that it's a dir).