RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 958051 - vdagent: check validity when iterating the _displays vector
Summary: vdagent: check validity when iterating the _displays vector
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: spice-vdagent-win
Version: ---
Hardware: Unspecified
OS: Windows
unspecified
medium
Target Milestone: rc
: ---
Assignee: Uri Lublin
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: 975442
TreeView+ depends on / blocked
 
Reported: 2013-04-30 09:05 UTC by Uri Lublin
Modified: 2019-10-10 14:19 UTC (History)
6 users (show)

Fixed In Version: vdagent-win-3.3-1
Doc Type: Bug Fix
Doc Text:
There are were cases where the _displays vector was being iterated, and some of the vector entries were NULL. This caused the agent to be aborted and restarted by the service several times. This has been fixed, now the agent enables virtual machines with multiple monitors to show all monitors correctly.
Clone Of:
: 975442 (view as bug list)
Environment:
Last Closed: 2014-01-21 14:43:28 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2014:0063 0 normal SHIPPED_LIVE spice-vdagent-win bug fix and enhancement update 2014-01-21 19:41:18 UTC

Description Uri Lublin 2013-04-30 09:05:08 UTC
Description of problem:
In the code, there are two cases where the _displays vector is being iterated.
Some of the vector entries may be NULL, so add code to check for it.

I encountered the problem when running a Windows XP guest with 4 QXL devices, each with both ram_size and vram_size set to 64MB. The guest could only use 3 of them.
The 4'th device could not be used due to "out of resources" problem.
The 4'th had NULL in its _displays entry.

Version-Release number of selected component (if applicable):
vdagent-win-0.1-17 (probably happens with earlier versions too)

How reproducible:
Always

Steps to Reproduce:
1. Run a Windows XP guest with 4 QXL devices, each with ram_size=64MB and vram_size=64MB (different size may work too)
2. Make sure from in-guest display-settings that only 3 QXL devices are available. (Also possible to see it with device-manager)
3. Install vdagent-win-0.1-17, if not already installed
4. Run service-manager and try to start RHEV Spice Agent

Actual results:
Agent aborts, restarted by the service, aborts ... for a few times.

Expected results:
Agent runs successfully.

Comment 1 Arnon Gilboa 2013-04-30 09:34:47 UTC
Nice catch, waiting for your patch.

Comment 2 Uri Lublin 2013-04-30 12:44:30 UTC
A patch you say ? I sent it your way:
http://lists.freedesktop.org/archives/spice-devel/2013-April/013223.html

Comment 3 Marc-Andre Lureau 2013-05-03 12:05:55 UTC
Things will turn bad on client side if the agent is running but all monitors are not QXL devices: the mapping  channel-monitor is no longer be correct..

I think it would make sense to fail starting the agent, and show a big fat warning dialog about the issue.

Comment 6 Arnon Gilboa 2013-06-19 13:03:33 UTC
revert change (should have been in z-stream bug 975442)

Comment 10 errata-xmlrpc 2014-01-21 14:43:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-0063.html


Note You need to log in before you can comment on or make changes to this bug.