Bug 959800 - PRD33 - notifier packaging re-work
Summary: PRD33 - notifier packaging re-work
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-notification-service
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.3.0
Assignee: Alon Bar-Lev
QA Contact: Ilanit Stein
URL:
Whiteboard: infra
Depends On: 952297
Blocks: 976171
TreeView+ depends on / blocked
 
Reported: 2013-05-05 20:57 UTC by Alon Bar-Lev
Modified: 2016-02-10 19:27 UTC (History)
10 users (show)

Fixed In Version: is1
Doc Type: Release Note
Doc Text:
The engine-notifierd has been renamed ovirt-engine-notifier, and its configuration files are now located at /etc/ovirt-engine/notifier/notifier.con.d/*.conf.
Clone Of:
: 976171 (view as bug list)
Environment:
Last Closed: 2014-01-21 22:13:18 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 14375 0 None None None Never
oVirt gerrit 14376 0 None None None Never
oVirt gerrit 14377 0 None None None Never
oVirt gerrit 14378 0 None None None Never
oVirt gerrit 14448 0 None None None Never

Description Alon Bar-Lev 2013-05-05 20:57:11 UTC 
Following the re-work of ovirt-engine service (bug#952297), we should align the notifier service to use the same infrastructure to ease maintenance.

Highlights:

1. Rename engine-notifierd to ovirt-engine-notifier to be consistent with service names of product.

2. Use conf.d convention for configuration files at /etc/ovirt-engine/notifier/notifier.conf.d/*.conf

3. Use the same service infrastructure of ovirt-engine to support sysv and systemd.

4. Eliminate duplicate parameters validation between service shell code and java code.

5. Cleanup some major issues in code structure.
Comment 1 Alon Bar-Lev 2013-05-05 20:59:05 UTC 
notifier: switch to log4j

for some reason no logs using current logger.

also fix log4j.xml as it complains about format.

Change-Id: I35de5d5a97ccd4f7bb80739fdb328de2e0ce6bd9
Signed-off-by: Alon Bar-Lev <alonbl>
Comment 2 Alon Bar-Lev 2013-05-05 20:59:37 UTC 
notifier: handle port correctly

1. separate between plain and ssl ports.
2. actually set plain port.

Change-Id: Ibcfa79849856dc3c2b3aaa9d0dd8652be04c788b
Signed-off-by: Alon Bar-Lev <alonbl>
Comment 3 Alon Bar-Lev 2013-05-05 21:00:18 UTC 
notifier: use LocalConfig as configuration file

gives the advantage of defaults and conf.d structure.

Change-Id: Iea3d8a9887d76920c51d26467c634912e64242dd
Signed-off-by: Alon Bar-Lev <alonbl>
Comment 4 Alon Bar-Lev 2013-05-05 21:00:47 UTC 
notifier: remove NotificationConfigurator as superseded by LocalConfig

cleanup validations of parameters to be acquired the LocalConfig way.

move most of validation to main function in more structural manner.

Change-Id: I9f8ebea59fabac945b95b6422d1bfbf8a2b1d208
Signed-off-by: Alon Bar-Lev <alonbl>
Comment 5 Alon Bar-Lev 2013-05-05 21:02:03 UTC 
notifier: move to the new service infrastructure

rename service to ovirt-engine-notifier to match other services.

remove redundant parameter validations in shell script as there is
duplicate java logic.

Change-Id: I2aadeca8b3017dad4107939c7c624ef020347b94
Signed-off-by: Alon Bar-Lev <alonbl>
Comment 6 Alon Bar-Lev 2013-05-05 21:03:56 UTC 
What I have tested:

1. Service start/stop.

2. Unit tests pass.

3. Configuration is loaded correctly.

What I have not tested:

Application logic.
Comment 8 Ilanit Stein 2013-07-17 07:20:44 UTC 
Verified on is5, by TCMS test case 285276
Comment 9 Itamar Heim 2014-01-21 22:13:18 UTC 
Closing - RHEV 3.3 Released
Comment 10 Itamar Heim 2014-01-21 22:21:13 UTC 
Closing - RHEV 3.3 Released
Note You need to log in before you can comment on or make changes to this bug.