Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
First Last Prev Next    This bug is not in your last search results.
Bug 959800 - PRD33 - notifier packaging re-work
PRD33 - notifier packaging re-work
Status: CLOSED CURRENTRELEASE
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-notification-service (Show other bugs)
3.3.0
Unspecified Unspecified
unspecified Severity unspecified
: ---
: 3.3.0
Assigned To: Alon Bar-Lev
Ilanit Stein
infra
: Improvement
Depends On: 952297
Blocks: 976171
  Show dependency tree / graph
 
Reported: 2013-05-05 16:57 EDT by Alon Bar-Lev
Modified: 2016-02-10 14:27 EST (History)
10 users (show)

See Also:
Fixed In Version: is1
Doc Type: Release Note
Doc Text:
The engine-notifierd has been renamed ovirt-engine-notifier, and its configuration files are now located at /etc/ovirt-engine/notifier/notifier.con.d/*.conf.
Story Points: ---
Clone Of:
: 976171 (view as bug list)
Environment:
Last Closed: 2014-01-21 17:13:18 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: Infra
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


External Trackers
Tracker ID Priority Status Summary Last Updated
oVirt gerrit 14375 None None None Never
oVirt gerrit 14376 None None None Never
oVirt gerrit 14377 None None None Never
oVirt gerrit 14378 None None None Never
oVirt gerrit 14448 None None None Never

  None (edit)
Description Alon Bar-Lev 2013-05-05 16:57:11 EDT 
Following the re-work of ovirt-engine service (bug#952297), we should align the notifier service to use the same infrastructure to ease maintenance.

Highlights:

1. Rename engine-notifierd to ovirt-engine-notifier to be consistent with service names of product.

2. Use conf.d convention for configuration files at /etc/ovirt-engine/notifier/notifier.conf.d/*.conf

3. Use the same service infrastructure of ovirt-engine to support sysv and systemd.

4. Eliminate duplicate parameters validation between service shell code and java code.

5. Cleanup some major issues in code structure.
Comment 1 Alon Bar-Lev 2013-05-05 16:59:05 EDT 
notifier: switch to log4j

for some reason no logs using current logger.

also fix log4j.xml as it complains about format.

Change-Id: I35de5d5a97ccd4f7bb80739fdb328de2e0ce6bd9
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
Comment 2 Alon Bar-Lev 2013-05-05 16:59:37 EDT 
notifier: handle port correctly

1. separate between plain and ssl ports.
2. actually set plain port.

Change-Id: Ibcfa79849856dc3c2b3aaa9d0dd8652be04c788b
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
Comment 3 Alon Bar-Lev 2013-05-05 17:00:18 EDT 
notifier: use LocalConfig as configuration file

gives the advantage of defaults and conf.d structure.

Change-Id: Iea3d8a9887d76920c51d26467c634912e64242dd
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
Comment 4 Alon Bar-Lev 2013-05-05 17:00:47 EDT 
notifier: remove NotificationConfigurator as superseded by LocalConfig

cleanup validations of parameters to be acquired the LocalConfig way.

move most of validation to main function in more structural manner.

Change-Id: I9f8ebea59fabac945b95b6422d1bfbf8a2b1d208
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
Comment 5 Alon Bar-Lev 2013-05-05 17:02:03 EDT 
notifier: move to the new service infrastructure

rename service to ovirt-engine-notifier to match other services.

remove redundant parameter validations in shell script as there is
duplicate java logic.

Change-Id: I2aadeca8b3017dad4107939c7c624ef020347b94
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
Comment 6 Alon Bar-Lev 2013-05-05 17:03:56 EDT 
What I have tested:

1. Service start/stop.

2. Unit tests pass.

3. Configuration is loaded correctly.

What I have not tested:

Application logic.
Comment 8 Ilanit Stein 2013-07-17 03:20:44 EDT 
Verified on is5, by TCMS test case 285276
Comment 9 Itamar Heim 2014-01-21 17:13:18 EST 
Closing - RHEV 3.3 Released
Comment 10 Itamar Heim 2014-01-21 17:21:13 EST 
Closing - RHEV 3.3 Released
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.