Bug 959882 - [rhevm] - Upgrade - Incorrect Upgrade Message while async tasks running (System Tasks name and empty lines)
Summary: [rhevm] - Upgrade - Incorrect Upgrade Message while async tasks running (Syst...
Keywords:
Status: CLOSED DUPLICATE of bug 951092
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-setup
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Eli Mesika
QA Contact: Pavel Stehlik
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-06 07:49 UTC by David Botzer
Modified: 2016-02-10 19:43 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-19 10:34:53 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
system-task (72.50 KB, application/x-gzip)
2013-05-06 07:49 UTC, David Botzer
no flags Details
engine.log (589.46 KB, application/octet-stream)
2013-05-19 07:29 UTC, David Botzer
no flags Details
upgrade-log (95.57 KB, application/octet-stream)
2013-05-19 07:29 UTC, David Botzer
no flags Details

Description David Botzer 2013-05-06 07:49:18 UTC
Created attachment 744008 [details]
system-task

Description of problem:
Incorrect Upgrade Message while async tasks running (System Tasks name and empty lines)

Version-Release number of selected component (if applicable):
3.2/sf14

How reproducible:
Always

Steps to Reproduce:
1.Install rhevm sf13
2.Create some VMs and Create template from one VM
3.Upgrade SF13 to SF14 (No reports, only rhevm), while async task running
  
Actual results:
System tasks shows nothing, and too much empty lines
See output below

Expected results:
Should show the name of the task that is running
::Perhaps create template doesnt have a name or else


Additional info:

Sandro Bonazzola, added:
Seems strange to me having only 4 blank lines there.
I would have expected something written there:
MSG_TASKS_COMPENSATIONS = "\n\nSystem Tasks:\n%s\n%s\n\n"
where the 2 %s are runningTasks and compensations.
-----------------------


Would you like to proceed? (yes|no): y
Stopping ovirt-engine service...                     [ DONE ]
Stopping DB related services...                      [ DONE ]
Cleaning async tasks...                              [ DONE ]

Info: The following tasks have been found running in the system:

System Tasks:




[ May 01 16:52:40 ] Would you like to proceed and try to stop tasks
automatically?
(Answering 'no' will stop the upgrade)? (yes|no): y

[ May 01 16:53:13 ] System will try to clear tasks during the next 3
minutes.

Comment 1 Barak 2013-05-12 12:53:03 UTC
What did the async_tasks table contain during the upgrade (direct SQL output is required).

What did the business_entity_snapshots table (compensation) table contained during the upgrade ?

Comment 2 David Botzer 2013-05-16 06:22:31 UTC
Will get back to you with SF17

Comment 3 David Botzer 2013-05-16 07:16:27 UTC
I upgraded SF16 to SF17
and while creating template from a vm, I ran upgrade ->

async_tasks table contained - partial SQL table, see Attached TXT
After upgrade it was cleared

business_entity_snapshots table (compensation) table contained - NOTHING
after upgrade - NOTHING

The template was locked

===========
"ef5875e2-5f09-40b5-899c-d9b144a88914";201;2;0;"{
  "@class" : "org.ovirt.engine.core.common.action.AddVmTemplateParameters",
  "commandId" : [ "org.ovirt.engine.core.compat.Guid", {
    "uuid" : "7f850bab-c84f-4ffa-85b8-e42b3f13c6f0"
  } ],
  "httpSessionId" : null,
  "parametersCurrentUser" : [ "org.ovirt.engine.core.common.users.VdcUser", {
    "groupIds" : "",
    "password" : null,
    "domainControler" : "internal",
    "browser" : null,
    "groupNames" : "",
    "firstName" : "admin",
    "surName" : null,
    "admin" : true,
    "fqn" : "admin@internal",
    "userId" : [ "org.ovirt.engine.core.compat.Guid", {
      "uuid" : "fdfc627c-d875-11e0-90f0-83df133b58cc"
    } ],
    "userName" : "admin@internal"
  } ],
  "compensationEnabled" : false,
  "parentCommand" : "Unknown",
  "commandType" : "Unknown",
  "multipleAction" : false,
  "entityId" : [ "org.ovirt.engine.core.compat.Guid", {
    "uuid" : "413c469a-e4b3-4f99-9065-90ad8cf43cf9"
  } ],
  "taskGroupSuccess" : true,
  "taskIds" : null,
  "executionIndex" : 0,
  "correlationId" : "741b05e3",
  "removeTemplateFromDb" : false,
  "vmTemplateId" : [ "org.ovirt.engine.core.compat.Guid", {
    "uuid" : "413c469a-e4b3-4f99-9065-90ad8cf43cf9"
  } ],
  "quotaId" : null,
  "destinationStorageDomainId" : null,
  "publicUse" : true,
  "name" : null,
  "description" : null,
  "checkDisksExists" : false,
  "storageDomainsList" : null,
  "shouldBeLogged" : true,
  "executionReason" : "REGULAR_FLOW",
  "transactionScopeOption" : "Required",
  "sessionId" : "mxX4i68q-U90BRNSYyfEclvT"
}";"org.ovirt.engine.core.common.action.AddVmTemplateParameters"

Comment 5 David Botzer 2013-05-19 07:27:52 UTC
SF17 -
I reproduced, this time without reports installed,

I didnt perform any brute stop, during upgrade.
I am asked to stop async Y/N - Yes to stop and continue upgrade
-----

async_tasks table contained the task in progress - creating template from vm
After upgrade it was cleared

business_entity_snapshots table (compensation) table contained - NOTHING
after upgrade - NOTHING
--------

Info: The following tasks have been found running in the system: 

System Tasks:

[ May 19 10:23:26 ] Would you like to proceed and try to stop tasks automatically?
(Answering 'no' will stop the upgrade)? (yes|no): y

[ May 19 10:23:28 ] System will try to clear tasks during the next 3 minutes.

Pre-upgrade validations...                           [ DONE ]
Backing Up Database...                               [ DONE ]
Rename Database...                                   [ ERROR ]
Error: Database rename failed. Check that there are no active connections to the DB and try again.
Starting ovirt-engine service...                     [ DONE ]
Error: Upgrade failed.
please check log at /var/log/ovirt-engine/ovirt-engine-upgrade_2013_05_19_10_23_15.log

Comment 6 David Botzer 2013-05-19 07:29:27 UTC
Created attachment 749975 [details]
engine.log

engine.log upgrade sf16 to sf17 while running async task - create template

Comment 7 David Botzer 2013-05-19 07:29:52 UTC
Created attachment 749976 [details]
upgrade-log

Comment 8 Alex Lourie 2013-05-19 10:34:53 UTC

*** This bug has been marked as a duplicate of bug 951092 ***


Note You need to log in before you can comment on or make changes to this bug.