Bug 960689 - Provide a more useful error message when user fails to set up EFI system partition correctly for UEFI install
Summary: Provide a more useful error message when user fails to set up EFI system part...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 19
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1023159 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-07 17:04 UTC by Adam Williamson
Modified: 2014-01-28 16:51 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-28 01:14:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2013-05-07 17:04:20 UTC
If you do a UEFI install of Fedora and use custom partitioning, and you don't set up the EFI system partition correctly - you must have a partition of type EFI System Partition mounted at /boot/efi - then, after some apparently unnecessary running around (see #960684), you see the error "you have not created a bootloader stage1 target device", which almost certainly means less than nothing to you.

Compare the case where you do a BIOS install to a GPT disk and don't create a BIOS boot partition, where you get this rather useful error:

"Your BIOS-based system needs a special partition to boot with Fedora's new disk label format (GPT). To continue, please create a 1MB 'BIOS Boot' type partition."

OK, we need to reword that to reflect that we don't default to GPT any more, but it tells you what's going on.

We ought to be able to detect the UEFI case like we do the BIOS boot case, and display a specific, nice error message rather than the useless 'bootloader stage1 target device' message. That'd be nice. Can we do that?

Comment 1 Chris Murphy 2013-06-02 13:58:47 UTC
For UEFI computers, the installer should create the EFI System partition rather than ask the user to do it. It's esoteric knowledge, and each GPT disk should have an ESP which Manual Partitioning can't even do as far as I know.

Comment 2 Adam Williamson 2013-06-02 16:50:09 UTC
Why do you say that? I haven't tried it, but EFI System Partition is just a type in custom part, presumably you can create as many partitions of that type as you like...

Comment 3 Chris Murphy 2013-06-02 17:10:36 UTC
You can't, because newui doesn't create partitions. It creates mount points (which may be partitions, LVs, or btrfs subvolumes). Since I have no mount point to specify for additional EFI System partitions on additional disks, I have no way of creating them through the installer.

BIOS Boot, and EFI System partitions are in the same category as the MBR gap, it's silly to ask them to create any of these things, even in Manual Partitioning.

Comment 4 Adam Williamson 2013-06-02 17:33:46 UTC
Call it /frobdingnagian and just remove the mount point after creating it...or after installing...a mount point's just a mount point, after all.

Comment 5 Chris Murphy 2013-06-02 17:55:20 UTC
It's a work around for a deficiency: the user has to lie to the installer, and then back out of the lie once he gets what he wants, which is something he shouldn't have to do in the first place. And while the EFI spec doesn't require the ESP be the first partition, ideally it should be.

Comment 6 Adam Williamson 2014-01-28 01:14:16 UTC
Oh, hey, look, I just fixed my own bug.

https://git.fedorahosted.org/cgit/blivet.git/commit/?id=c81cbd05a5e29b1c82706fc5a3b09424c087ba0d

Comment 7 Adam Williamson 2014-01-28 16:51:34 UTC
*** Bug 1023159 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.