Spec URL: http://smani.fedorapeople.org/mingw-giflib.spec SRPM URL: http://smani.fedorapeople.org/mingw-giflib-4.1.6-1.fc20.src.rpm Description: MinGW Windows giflib library Fedora Account System Username: smani
Taking for review Only one remark: The mingw_build_win32/mingw_build_win64 globals don't have to be set any more
The BR: mingw32-filesystem mingw64-filesystem needs to be versioned to >= 95
Spec URL: http://smani.fedorapeople.org/mingw-giflib.spec SRPM URL: http://smani.fedorapeople.org/mingw-giflib-4.1.6-2.fc20.src.rpm * Sun May 19 2013 Sandro Mani <manisandro> - 4.1.6-2 - Remove mingw_build_win32/64 macros - Properly version mingw32-filesystem BuildRequires
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5582835 $ rpmlint mingw-giflib.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-giflib-4.1.6-2.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-giflib-4.1.6-2.fc19.noarch.rpm mingw32-giflib-static-4.1.6-2.fc19.noarch.rpm mingw32-giflib-tools-4.1.6-2.fc19.noarch.rpm mingw64-giflib-4.1.6-2.fc19.noarch.rpm mingw64-giflib-static-4.1.6-2.fc19.noarch.rpm mingw64-giflib-tools-4.1.6-2.fc19.noarch.rpm mingw32-giflib-static.noarch: W: no-documentation mingw32-giflib-tools.noarch: W: no-documentation mingw64-giflib-static.noarch: W: no-documentation mingw64-giflib-tools.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpm --query --requires mingw32-giflib rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 95 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-giflib rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 95 mingw64(kernel32.dll) mingw64(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-giflib-static mingw32-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-giflib-static mingw64-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-giflib-tools mingw32-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 95 mingw32(kernel32.dll) mingw32(libgif-4.dll) mingw32(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-giflib-tools mingw64-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 95 mingw64(kernel32.dll) mingw64(libgif-4.dll) mingw64(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-giflib mingw32-giflib = 4.1.6-2.fc19 mingw32(libgif-4.dll) $ rpm --query --provides mingw64-giflib mingw64-giflib = 4.1.6-2.fc19 mingw64(libgif-4.dll) $ rpm --query --provides mingw32-giflib-static mingw32-giflib-static = 4.1.6-2.fc19 $ rpm --query --provides mingw64-giflib-static mingw64-giflib-static = 4.1.6-2.fc19 $ rpm --query --provides mingw32-giflib-tools mingw32-giflib-tools = 4.1.6-2.fc19 $ rpm --query --provides mingw64-giflib-tools mingw64-giflib-tools = 4.1.6-2.fc19 $ wget --quiet http://downloads.sourceforge.net/giflib/giflib-4.1.6.tar.bz2 -O - | md5sum 7125644155ae6ad33dbc9fc15a14735f - $ md5sum giflib-4.1.6.tar.bz2 7125644155ae6ad33dbc9fc15a14735f giflib-4.1.6.tar.bz2 + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [+] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [!] Requires of the binary mingw32 and mingw64 packages are equal The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64 package doesn't. I've also seen this on various other packages so we can ignore this for now ================================================ The package mingw-giflib is APPROVED by epienbro ================================================
Thanks Erik! New Package SCM Request ======================= Package Name: mingw-giflib Short Description: MinGW Windows giflib library Owners: smani Branches: f18 f19 InitialCC:
Git done (by process-git-requests).
mingw-giflib-4.1.6-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-giflib-4.1.6-2.fc19
mingw-giflib-4.1.6-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-giflib-4.1.6-2.fc18
mingw-giflib-4.1.6-2.fc19 has been pushed to the Fedora 19 testing repository.
mingw-giflib-4.1.6-2.fc18 has been pushed to the Fedora 18 stable repository.
mingw-giflib-4.1.6-2.fc19 has been pushed to the Fedora 19 stable repository.