Bug 963897 - lxdm is misusing the preset file logic of systemd
Summary: lxdm is misusing the preset file logic of systemd
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: lxdm
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-16 18:19 UTC by Lennart Poettering
Modified: 2015-02-18 13:53 UTC (History)
2 users (show)

Fixed In Version: systemd-204-6.fc19
Clone Of:
Environment:
Last Closed: 2015-02-18 13:53:55 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lennart Poettering 2013-05-16 18:19:02 UTC
This call tells me that lxdm.rpm is providing a preset file:

$ repoquery -q --qf="%{name}" --whatprovides '*/lib/systemd/system-preset/*.preset' | sort -u
...
lxdm
...

It shouldn't do that. Preset files are something that the distribution, spins of the distribution or administrators write. They policy that is applied to the OS, and should not be shipped by any normal RPMS. 

For Fedora, additions to the preset file must be kept in systemd.rpm and need to be accepted by FPC.

Please remove the preset file from the RPM. Thanks!

Comment 1 Christoph Wickert 2013-05-16 19:20:55 UTC
If I remove the preset file, how do I get it into the systemd package? Is there a documented process I can follow?

What about spins, how to they get their own preset files?

Comment 2 Lennart Poettering 2013-05-17 16:02:01 UTC
Quoting: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

"If your package includes one or more systemd units that need to be enabled by default on package installation, they need to be covered by the default Fedora preset policy. The default fedora preset policy is shipped as part of systemd.rpm. If your unit files are missing from this list, please file a bug against the systemd package. Only services covered by the policy on which services that may be enabled by default on package installation are eligible for this, and you will need to receive special permission from FESCo to have a package start a service by default if it is not covered by the existing policy."

The existing policy you find here:

https://fedoraproject.org/wiki/Starting_services_by_default

I have now idea really how spins are built. I'd recommend them to ship their own preset files. That said if lxdm is listed in the default preset file it is enabled anyway by default, so this isn't even necessary...

Comment 3 Christoph Wickert 2013-05-23 07:32:45 UTC
I wasn't asking about the packaging site of things but about the process. How do I get something into the systemd package? Who is the one I need to talk to? How do we coordinate the update for systemd and lxdm to avoid afile conflict?

In bug 963899 Rex followed your advice, as a result, lightdm no longer starts.

Comment 4 Christoph Wickert 2013-06-03 14:45:11 UTC
Lennart, can you please get back to me?

Comment 5 Lennart Poettering 2013-06-04 09:33:08 UTC
File a bug against systemd, of course, with patch that adds this to the display manager preset file would be best.

Comment 6 Christoph Wickert 2013-06-04 11:24:24 UTC
Both lightdm and lxdm are in that file for ages, you added it last year back in September. Still, lightdm did not start after Rex dropped it's preset file. How comes?

And what should we do about the "disable gdm.service" part of the current preset file?

Comment 7 Lennart Poettering 2013-06-06 10:33:38 UTC
Hmm, I guess 

https://bugzilla.redhat.com/show_bug.cgi?id=903690#c7

is the explanation here. Will fix this shortly.

Comment 8 Fedora Update System 2013-06-06 10:39:07 UTC
systemd-204-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/systemd-204-5.fc19

Comment 9 Fedora Update System 2013-06-06 12:44:33 UTC
systemd-204-6.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/systemd-204-6.fc19

Comment 10 Christoph Wickert 2013-06-06 13:11:08 UTC
"You are not authorized to access bug #903690. :("

Anything left for me to do other than dropping the preset file?

Comment 11 Fedora Update System 2013-06-06 17:30:35 UTC
Package systemd-204-6.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-204-6.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-10202/systemd-204-6.fc19
then log in and leave karma (feedback).

Comment 12 Fedora Update System 2013-06-08 03:36:53 UTC
systemd-204-6.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Lennart Poettering 2013-06-10 13:27:03 UTC
The bug shouldn't have been closed by bodhi. Reopening.

Comment 14 Fedora End Of Life 2015-01-09 22:07:18 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 15 Fedora End Of Life 2015-02-18 13:53:55 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.