Bug 965160 - Bundled library: tcpdf in moodle
Summary: Bundled library: tcpdf in moodle
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: moodle
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 964412
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-20 15:00 UTC by Remi Collet
Modified: 2013-05-20 16:58 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-20 16:58:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Remi Collet 2013-05-20 15:00:07 UTC
Moodle provides a bundled copy of tcpdf while system library is now available.

Comment 1 Gwyn Ciesla 2013-05-20 15:25:30 UTC
This looks like there are some files in moodle's tcpdf that aren't in php-tcpdf, do you have any insight here?

This is moodle/lib/tcpdf from 2.5:

2dbarcodes.php  CHANGELOG.TXT  config          encodings_maps.php  htmlcolors.php  pdf417.php  readme_moodle.txt  spotcolors.php  tcpdf.crt  tcpdf_filters.php  tcpdf_parser.php  unicode_data.php
barcodes.php    composer.json  datamatrix.php  fonts               LICENSE.TXT     qrcode.php  README.TXT         sRGB.icc        tcpdf.fdf  tcpdf.p12          tcpdf.php

Comment 2 Remi Collet 2013-05-20 16:10:17 UTC
After a quick look.

Moodle 2.5 bundles php-tcpdf 5.9.209 (not so old, 2013-03-14).

Using system php-tcpdf shoud work "out of the box", just need to edit the moodle/lib/pdflib.php to fix paths.

The package need to requires:
php-tcpdf
php-tcpdf-gnu-free-serif-fonts
php-tcpdf-gnu-free-sans-fonts
php-tcpdf-gnu-free-mono-fonts

Most important changes between 5.9 and 6.0 was the "big" tcpdf class being split. So some call to $this->foo() have to be changed to, p.e. tcpdf_static::foo(), but I don't see any of them (very quick look).

In all case, all changes should happen in pdflib.php.

Of course, this must be tried.

Comment 3 Gwyn Ciesla 2013-05-20 16:16:18 UTC
Excellent, thanks.  I'll implement the above in 2.5 in rawhide only, and we'll go from there.


Note You need to log in before you can comment on or make changes to this bug.