Red Hat Bugzilla – Bug 967392
group name and display name not used consistently
Last modified: 2018-03-19 00:18:47 EDT
Currently the jobs grid shows group names in the Group column, but when you click through to the job page the Group field shows the display name instead of the group name. To keep consistency across all parts of the UI, we should always show just the group name.
It's worth noting that users are always display as their user name, the real name is not shown. So this would bring groups in line with how we treat users.
We could show the group's display name in the title text for the link. We can do that consistently across the UI as well, without worrying about the space it would take up in grid columns. We could do the same for users as well (always show user name, with real name in the title text).
*** Bug 1021368 has been marked as a duplicate of this bug. ***
As noted in bug 1021368, the display names are not guaranteed to be unique, so using them is the primary means of display anywhere is not only inconsistent, but also potentially ambiguous.
Showing the underlying username or groupname by default, with the "Display Name" in a tooltip would also address that (although it makes "Display Name" a misnomer for that field - perhaps the label should be changed to "Full Name" and/or "Summary"?
If only chose "Use old, deprecated job and recipe pages", this issue still exists.
In new job/recipe pages, the Group column both show groupname.
If this problem only exists on the old job page, we can close this bug.
We think that all the other views don't have this problem anymore, but whoever takes this bug is encouraged to double check.
(In reply to Roman Joost from comment #4)
> If this problem only exists on the old job page, we can close this bug.
> We think that all the other views don't have this problem anymore, but
> whoever takes this bug is encouraged to double check.
Double checked on Beaker 24.0.git.242.608161a.
It's only exists in old job page.
In new Job page, both Group column(*/jobs) and Job detail page show group name *not* display name.
I prefer close this bug, I think very few people still use old Job page.
After traversal all pages in Beaker. I found 3 places used group name. And in step 3 group name/display not used consistently.
I prefer we can fix it. If you feel this need fix, I can handle it.
1. Make some change in group check blew pages.
In these page used *group name*
2. Check other pages.
These page used *group name*
3. In this page, Under Use custom access policy, used *group name*
But in Activity
Used *display name*
Specifically, the only place left where we are identifying groups by their display name appears to be in the system activity records for adding/removing access policy rules, which look like this:
dowang HTTP 2017-01-17 16:54:07 +10:00 Access Policy Rule Added <grant view to dowang-test-displayname>
dowang HTTP 2017-01-17 16:52:59 +10:00 Access Policy Rule Removed <grant view to dowang-test-displayname>
Normally I am loathe to change these because it will break the ability to do historical data mining if the structure of the activity entries has changed over time... *but* that's just the repr() of the SystemAccessPolicyRule object which was a bit of laziness on my part. The repr() is really already subject to change at any time *and* not very parseable either to boot.
So it's probably worth fixing (and covering with a test case for the future).
The other cases where we try to jam structured data into activity records is for distro tree--lab controller maps, which the values look like:
separated by space, although those are also unusable for a different reason (bug 968715)... and the field names for install options, which look like:
So perhaps the best option is use colons to separate the pieces of the value here for the access policy rules.
And then we can finally consider this bug done.
The tests have revealed one other place where we are using group display name, which is in the activity records for system pools, when the pool owner is a group. However I think we are better off just changing this to use group name too, even though it does make historical data mining of the activity records harder.
Oops wrong link... I meant:
Verified on https://beaker-devel.app.eng.bos.redhat.com/
Group name now appears in the following pages
1. system activity records for adding/removing access policy rules
achatter HTTP 2017-09-20 15:14:33 +10:00 Access Policy Rule Added Group:beakerdevs:view
2. activity records for system pools
achatter HTTP 2017-09-20 15:17:27 +10:00 beaker-dogfood Access Policy Rule Added Group:beakerdevs:view
Beaker 25.0 has been released.
Release notes are available upstream: https://beaker-project.org/docs/whats-new/release-25.html