Description of problem: Platform BZ for https://issues.jboss.org/browse/JBPM-4019 Steps to Reproduce: 1. Write a DataObject and 2 Tasks. 2. Write incoming association to the DataObject and outgoing association from the DataObject. 3. Save # screenshots in JBPM-4019 would explain a lot. Actual results: DataObject turns into DataInput (= with Input icon inside) Expected results: DataObject appearance stays the same.
I believe data associations on data objects are currently not supported. While I don't think we can add support for this in BPMS 6.0, we should probably look at not allowing these data associations to be drawn in the first place (as they are not supported).
Tihomir Surdilovic <tsurdilo> made a comment on jira JBPM-4019 I don't understand the issue here. The Data Object stays a Data Object, with just its type set to Input / Output depending how it is used. In case of both input and output as in this example Input is chosen by default. There are no data associations properties in the data object nodes, but the connected tasks in this example get dynamically inserted the property data inputs/outputs and assignments which seem correct to me. Please explain what the issue is here :) Thanks.
Toshiya Kobayashi <tkobayas> made a comment on jira JBPM-4019 Hi Tiho, Well, the customer's concern is just about the appearance. They expect that the DataObject with incoming+outgoing connections should not have the input/output icon inside. It may not be clearly stated in BPMN 2.0 but it sounds reasonable to me. What do you think?
Tihomir Surdilovic <tsurdilo> made a comment on jira JBPM-4019 I think that is OK. I will remove the embedded image asap.
Toshiya Kobayashi <tkobayas> made a comment on jira JBPM-4019 Thanks Tiho. Just in case, I rephrase the expected results. - If a DataObject has an outgoing connection, it has Input icon inside. (It's already implemented so) - If a DataObject has an incoming connection, it has Output icon inside. (It's already implemented so) - If a DataObject has both incoming and outgoing connections, it has no icon inside. (This is the request of this JIRA)
Tihomir Surdilovic <tsurdilo> updated the status of jira JBPM-4019 to Resolved
Tihomir Surdilovic <tsurdilo> made a comment on jira JBPM-4019 fix in master
Is this issue valid for ER2? This issue is ON_QA with ER2 but target release is ER3. State in ER2: - Data Object does not contain any icon for all states (Input, Output, Input/Output) - this solution does not correspond with comment #6.
Created attachment 792034 [details] dataobject_600er2.png
Hi Sona, You can change the icon by DataObject's property "Input/Output". I have attached dataobject_600er2.png. I think it's okay for this BZ. But hmm, if Tiho intends that it should happens automatically, he may want to fix. WDYT? Tiho.
Ok. So for ER2: - the user can choose an icon which does not reflected actual state. - the icon has no effect on direction of association. - BPMN2 source code depends on flow elements on canvas. This behaviour can lead to inconsistence between BPMN2 source code and visual information.
I think would be best to hide the Input/Output property then on Data Objects then? WDYT? Thanks.
Does Designer change Input/Output icons automatically? Like: - if user append a data object to task than the Input icon is shown - if user add/remove an association to/from the data object than its icon depends on direction of all associations: - incoming direction - INPUT ICON - outgoing direction - OUTPUT ICON - both direction - ANY ICON - undirected - ANY ICON Or you remove icons from data object? In case that Designer does not change icons automatically I suggest to leave Input/Output property in Properties Bar and add validation issue "Input/Output property does not reflected a state of data object."
Hi Tiho, You seemed to comment-out the automatic icon setting logic in this commit. https://github.com/droolsjbpm/jbpm-designer/commit/65017f4ec16b6774395f2cc6f1488e762571a974 +// if(outgoingAssociaton != null && incomingAssociation == null) { +// properties.put("input_output", "Input"); +// } +// +// if(outgoingAssociaton == null && incomingAssociation != null) { +// properties.put("input_output", "Output"); +// } I'm not sure if it can be a problem for JBPM-4020 (A Data Object associated with a Sequence Flow) but can you just uncomment the lines? Then hiding the Input/Output property would sound fine.
@Toshiya: uncommented those lines and hide the Input/Output property. Thanks.
Re-enabling data object post 6.0.1.GA https://bugzilla.redhat.com/show_bug.cgi?id=1042524