Spec URL: http://cicku.me/perl-Perl6-Slurp.spec SRPM URL: http://cicku.me/perl-Perl6-Slurp-0.051003-1.fc20.src.rpm Description: slurp takes: a filename, a filehandle, a typeglob reference, an IO::File object, or a scalar reference, converts it to an input stream (using open() if necessary), and reads in the entire stream. If slurp fails to set up or read the stream, it throws an exception. Fedora Account System Username: cicku
Review: + mock build is successful for f20 + rpmlint on rpms gave perl-Perl6-Slurp.noarch: W: spelling-error Summary(en_US) Implemention -> Implement ion, Implement-ion, Implementation perl-Perl6-Slurp.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament perl-Perl6-Slurp.noarch: W: spelling-error %description -l en_US filehandle -> file handle, file-handle, mishandle perl-Perl6-Slurp.noarch: W: spelling-error %description -l en_US typeglob -> type glob, type-glob, logotype perl-Perl6-Slurp.src: W: spelling-error Summary(en_US) Implemention -> Implement ion, Implement-ion, Implementation perl-Perl6-Slurp.src: W: spelling-error %description -l en_US filename -> file name, file-name, filament perl-Perl6-Slurp.src: W: spelling-error %description -l en_US filehandle -> file handle, file-handle, mishandle perl-Perl6-Slurp.src: W: spelling-error %description -l en_US typeglob -> type glob, type-glob, logotype 2 packages and 0 specfiles checked; 0 errors, 8 warnings. ==> Ignore this + Source verified with upstream as (sha256sum) srpm tarball: 49fdcbb37b7a0fd1bf043970cfe42913080b1e3bf794a03b103c14480d48d60a upstream tarball: 49fdcbb37b7a0fd1bf043970cfe42913080b1e3bf794a03b103c14480d48d60a - License "Freely redistributable without restriction" looks invalid. + rest follows packaging guidelines + make test is successful with output All tests successful. Files=13, Tests=183, 1 wallclock secs ( 0.06 usr 0.01 sys + 0.26 cusr 0.03 csys = 0.36 CPU) + This package Provides: perl(Perl6::Slurp) = 0.051003 perl-Perl6-Slurp = 0.051003-1.fc20 Requires: perl >= 0:5.008 perl(Carp) perl(Scalar::Util) perl(strict) perl(warnings) suggestions: 1)Look https://fedoraproject.org/wiki/Packaging:Perl#License_tag and you will see license for this package is "GPL+ or Artistic"
Hi, I want to know if I need to add Requires of perl(strict) As a review did by ppisar(https://bugzilla.redhat.com/show_bug.cgi?id=979648), he recommended me to add this. Although I don't think it's a problem, because strict is in perl main package now. NEW SPEC URL: http://cicku.me/perl-Perl6-Slurp.spec NEW SRPM URL: http://cicku.me/perl-Perl6-Slurp-0.051003-2.fc20.src.rpm
I don't think you need to add perl(strict) requires. APPROVED above srpm.
New Package SCM Request ======================= Package Name: perl-Perl6-Slurp Short Description: Implemention of the Perl 6 'slurp' built-in Owners: cicku Branches: f18 f19 InitialCC:
Git done (by process-git-requests).
perl-Perl6-Slurp-0.051003-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Perl6-Slurp-0.051003-2.fc19
perl-Perl6-Slurp-0.051003-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Perl6-Slurp-0.051003-2.fc18
perl-Perl6-Slurp-0.051003-2.fc18 has been pushed to the Fedora 18 testing repository.
perl-Perl6-Slurp-0.051003-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-Perl6-Slurp-0.051003-2.fc18 has been pushed to the Fedora 18 stable repository.