looks some issues in make test. Its failing to find Fatal.pm

Hi, can you paste the full log? 

I don't submit FTBFS RPM, first all these RPM can be built on my rawhide instance, then I will submit a review request.

for f20, http://koji.fedoraproject.org/koji/taskinfo?taskID=5596740

for f19, http://koji.fedoraproject.org/koji/taskinfo?taskID=5596739

Well, obviously the package dependencies are incorrect.
Also, please always require modules via the perl virtual provides, not by package names (like perl-Template-Toolkit in your case here).

For historical reason..... Ah....You know... 


Will fix later.

(In reply to Petr Šabata from comment #4)
This package is a bit like wwwtools, I cannot use virtual provide. yum cannot find it. The only solution is to keep perl-Template-Toolkit instead of perl(Template::Toolkit)


NEW SPEC URL: http://cicku.me/perl-Text-Xslate.spec
NEW SRPM URL: http://cicku.me/perl-Text-Xslate-2.0007-2.fc20.src.rpm

That's because that package doesn't provide a module with that name.  This is a nice example how package names and modules in them don't match (and often change over time) and exactly why virtual provides should always be used.

Just build-require the modules you actually use.  Here it is, judging by a quick glance, perl(Template) and perl(Template::Plugin::String).

And the dependencies still need more work.  Look at what is used (the 'use', 'require', and 'no' clauses) in the test suite (./t), the tested code (most or all modules in ./lib and ./src; the XS part is more tricky, though), and the build suite (Makefile.PM and ./inc in your case).

I don't know how you find the required dependencies now but this method is reliable and actually reflects reality.

NEW SPEC URL: http://cicku.me/perl-Text-Xslate.spec
NEW SRPM URL: http://cicku.me/perl-Text-Xslate-2.0009-1.fc20.src.rpm

Why the needinfo on me?  Do you want me to review the package?

No, because you've commented and I want you to check if deps are OK.

If you want to review, welcome.(optional)

Alright, I'll take a look.

When ready please leave a comment.

Thanks.

You haven't look at the code at all, have you?
As usually, items marked as FIX are needed for the review; TODO are (strongly) recommended.

TODO: BR perl (called in spec)
TODO: Run-require perl(B)
FIX: BR perl(base)
FIX: BR perl(Carp)
FIX: BR perl(CGI)
TODO: BR perl(Config)
FIX: BR perl(constant)
FIX: BR perl(Cwd)
FIX: BR perl(Data::Dumper)
FIX: Run-require perl(Data::Dumper)
FIX: BR perl(Devel::StackTrace)
FIX: BR perl(Digest::MD5)
FIX: Run-require perl(Digest::MD5)
FIX: BR perl(Encode)
FIX: Run-require perl(Encode)
FIX: BR perl(Exporter)
FIX: BR perl(ExtUtils::MM_Unix)
FIX: BR perl(Fatal)
TODO: BR perl(Fcntl)
TODO: BR perl(File::Basename)
TODO: BR perl(File::Copy)
TODO: BR perl(File::Find)
FIX: BR perl(File::Path)
FIX: Run-require perl(File::Path)
FIX: BR perl(File::Spec)
TODO: BR perl(File::stat)
TODO: BR perl(FindBin)
FIX: BR perl(Getopt::Long)
TODO: BR perl(if)
FIX: BR perl(lib)
FIX: BR perl(List::Util)
FIX: BR perl(Mouse::Role)
FIX: BR perl(Mouse::Util::TypeConstraints)
TODO: BR perl(overload)
FIX: BR perl(Plack::Builder)
FIX: BR perl(Plack::Response)
FIX: BR perl(Plack::Test)
TODO: BR perl(SelectSaver)
TODO: BR perl(strict)
FIX: BR perl(threads)
TODO: BR perl(Tie::Array)
TODO: BR perl(Tie::Hash)
TODO: BR perl(Time::localtime)
TODO: BR perl(utf8)
TODO: BR perl(vars)
TODO: BR perl(warnings)
FIX: BR perl(XSLoader)
FIX: Run-equire perl(XSLoader)

Some of those are used in optional tests (such as Plack::*) but given your current dependency list, it seems like you wanted to run those therefore I've included them too.

TODO: Package the 'example' directory as documentation.  There's a lot of useful stuff there.

TIP: Since you define the %pkgname macro, you could also use it in URL (or possibly even Name).

TODO: Remove the perl(autodie) BR.  You need the Fatal module, so just BR that (mentioned boave).

The rest of the package is okay.

Finally cleanup this tough package...

It seems that BR some modules in perl package itself is needed now, right?

NEW SPEC URL: http://cicku.me/perl-Text-Xslate.spec
NEW SRPM URL: http://cicku.me/perl-Text-Xslate-3.1.0-1.fc21.src.rpm

(In reply to Christopher Meng from comment #14)
> It seems that BR some modules in perl package itself is needed now, right?

Indeed, there's basically no difference between them.

I've gone through the new version code and I'm going to approve this now but:
- Some of the explicit Requires can be dropped as rpmbuild will detect them automagically (Data::MessagePack, parent, Mouse)
- You can add BR perl(B) to be complete

You can do those changes after the import.

Thanks!

New Package SCM Request
=======================
Package Name: perl-Text-Xslate
Short Description: Scalable template engine
Owners: cicku
Branches: f20 epel7
InitialCC: perl-sig

Git done (by process-git-requests).

perl-Text-Xslate-3.1.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Text-Xslate-3.1.1-1.fc20

perl-Text-Xslate-3.1.1-1.fc20 has been pushed to the Fedora 20 testing repository.

perl-Text-Xslate-3.1.1-1.fc20 has been pushed to the Fedora 20 stable repository.