Spec URL: http://cicku.me/patool.spec SRPM URL: http://cicku.me/patool-1.2-1.fc20.src.rpm Description: Various archive types can be created, extracted, tested, listed, compared, searched and repacked with patool. The advantage of patool is its simplicity in handling archive files without having to remember a myriad of programs and options. The archive format is determined by the file(1) program and as a fallback by the archive file extension. patool supports 7z (.7z), ACE (.ace), ADF (.adf), ALZIP (.alz), APE (.ape), AR (.a), ARC (.arc), ARJ (.arj), BZIP2 (.bz2), CAB (.cab), COMPRESS (.Z), CPIO (.cpio), DEB (.deb), DMS (.dms), FLAC (.flac), GZIP (.gz), LRZIP (.lrz), LZH (.lha, .lzh), LZIP (.lz), LZMA (.lzma), LZOP (.lzo), RPM (.rpm), RAR (.rar), RZIP (.rz), SHN (.shn), TAR (.tar), XZ (.xz), ZIP (.zip, .jar) and ZOO (.zoo) formats. It relies on helper applications to handle those archive formats (for example bzip2 for BZIP2 archives). The archive formats TAR, ZIP, BZIP2 and GZIP are supported natively and do not require helper applications to be installed. Fedora Account System Username: cicku
I'm looking for review this package.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/sagitter/981834-patool/licensecheck.txt patool is licensed with a GPLv3+. Please, fix it. [!]: Package consistently uses macro is (instead of hard-coded directory names). Consider to use %{name} macro more frequently. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Package must own all directories that it creates. - %{python_sitelib}/patoolib/ This dir and its subdir (patoolib/programs) are not owned by the package. Please, fix this issue. - Also, %{python_sitelib}/*Patool* %{python_sitelib}/patoolib/* %{python_sitelib}/patoolib/programs/* the directories above contain all .py[co]/.egg-info files, I prefer to list them explicitely in '%files' section. See http://fedoraproject.org/wiki/Packaging:Python - '/etc/bash_completion.d/patool.bash-completion' file is not listed explicitely and needs to be managed properly. See http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files [x]: Package does not own files or directories owned by other packages. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 51200 bytes in 3 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Consider to perform some tests. A 'tests' directory is available in main directory. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: patool-1.2-1.fc20.noarch.rpm patool.noarch: W: spelling-error %description -l en_US adf -> add, ad, fad patool.noarch: W: spelling-error %description -l en_US alz -> ale, alt, all patool.noarch: W: spelling-error %description -l en_US arj -> ark, jar, are patool.noarch: W: spelling-error %description -l en_US cpio -> CPI patool.noarch: W: spelling-error %description -l en_US dms -> ms, dims, dams patool.noarch: W: spelling-error %description -l en_US flac -> flax, lac, flack patool.noarch: W: spelling-error %description -l en_US gz -> g, z, gs patool.noarch: W: spelling-error %description -l en_US lrz -> Lr patool.noarch: W: spelling-error %description -l en_US lha -> la, ha, lea patool.noarch: W: spelling-error %description -l en_US lzh -> Luz patool.noarch: W: spelling-error %description -l en_US lz -> l, z, ls patool.noarch: W: spelling-error %description -l en_US lzma -> lama patool.noarch: W: spelling-error %description -l en_US lzo -> lo, loo, Luzon patool.noarch: W: spelling-error %description -l en_US rar -> arr, ear, tar patool.noarch: W: spelling-error %description -l en_US rz -> r, z, re patool.noarch: W: spelling-error %description -l en_US shn -> sh, shin, shun patool.noarch: W: spelling-error %description -l en_US xz -> xx, x, z patool.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively patool.noarch: W: non-conffile-in-etc /etc/bash_completion.d/patool.bash-completion 1 packages and 0 specfiles checked; 0 errors, 19 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint patool patool.noarch: W: spelling-error %description -l en_US adf -> add, ad, fad patool.noarch: W: spelling-error %description -l en_US alz -> ale, alt, all patool.noarch: W: spelling-error %description -l en_US arj -> ark, jar, are patool.noarch: W: spelling-error %description -l en_US cpio -> CPI patool.noarch: W: spelling-error %description -l en_US dms -> ms, dims, dams patool.noarch: W: spelling-error %description -l en_US flac -> flax, lac, flack patool.noarch: W: spelling-error %description -l en_US gz -> g, z, gs patool.noarch: W: spelling-error %description -l en_US lrz -> Lr patool.noarch: W: spelling-error %description -l en_US lha -> la, ha, lea patool.noarch: W: spelling-error %description -l en_US lzh -> Luz patool.noarch: W: spelling-error %description -l en_US lz -> l, z, ls patool.noarch: W: spelling-error %description -l en_US lzma -> lama patool.noarch: W: spelling-error %description -l en_US lzo -> lo, loo, Luzon patool.noarch: W: spelling-error %description -l en_US rar -> arr, ear, tar patool.noarch: W: spelling-error %description -l en_US rz -> r, z, re patool.noarch: W: spelling-error %description -l en_US shn -> sh, shin, shun patool.noarch: W: spelling-error %description -l en_US xz -> xx, x, z patool.noarch: W: spelling-error %description -l en_US natively -> naively, negatively, tentatively patool.noarch: W: non-conffile-in-etc /etc/bash_completion.d/patool.bash-completion 1 packages and 0 specfiles checked; 0 errors, 19 warnings. # echo 'rpmlint-done:' Requires -------- patool (rpmlib, GLIBC filtered): /usr/bin/python python(abi) Provides -------- patool: patool Source checksums ---------------- http://github.com/downloads/wummel/patool/patool-1.2.tar.gz : CHECKSUM(SHA256) this package : 2647e71c4f9506344c96c753ff1b5dc4d66bf0436ce2a8cb82b1139eb37a43ed CHECKSUM(SHA256) upstream package : 2647e71c4f9506344c96c753ff1b5dc4d66bf0436ce2a8cb82b1139eb37a43ed Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-i386 Command line :/bin/fedora-review -m fedora-rawhide-i386 -b 981834
THe toplevel dir is included, not sure about why you said that RPM had unowned dirs. Can you tell me? FYI I update the egginfo in files. No %check now, because check will fail. Please ignore. Spec URL: http://cicku.me/patool.spec SRPM URL: http://cicku.me/patool-1.2-2.fc20.src.rpm
(In reply to Christopher Meng from comment #3) > THe toplevel dir is included, not sure about why you said that RPM had > unowned dirs. Can you tell me? I refer to its subdirectory named 'programs'. See http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory > > No %check now, because check will fail. Please ignore. Why it fails ? How have you ran the tests ?
Well, When you write something like this: %dir %{python_sitelib}/patoolib/programs %{python_sitelib}/patoolib/ warning: File listed twice: /usr/lib/python2.7/site-packages/patoolib/programs So I think that "%{python_sitelib}/patoolib/" has included "programs" subdir. Test failed with "make test". https://github.com/wummel/patool/issues/4
(In reply to Christopher Meng from comment #5) > Well, > > When you write something like this: > > %dir %{python_sitelib}/patoolib/programs > %{python_sitelib}/patoolib/ > > warning: File listed twice: > /usr/lib/python2.7/site-packages/patoolib/programs > > So I think that "%{python_sitelib}/patoolib/" has included "programs" subdir. In this way ... %dir %{python_sitelib}/patoolib %{python_sitelib}/patoolib/*.py %{python_sitelib}/patoolib/*.pyc %{python_sitelib}/patoolib/*.pyo %dir %{python_sitelib}/patoolib/programs %{python_sitelib}/patoolib/programs/*.py %{python_sitelib}/patoolib/programs/*.pyc %{python_sitelib}/patoolib/programs/*.pyo ? > > Test failed with "make test". > > https://github.com/wummel/patool/issues/4 In their test suit, all tests seem be okay: https://travis-ci.org/wummel/patool/jobs/8517831. Also, it considers various installations of nonfree packages to performe all tests. This issue must be analyzed in my opinion.
(In reply to Antonio Trande from comment #6) Do we need to include the subdir? Many packages only contain the toplevel one. I don't think we need to include the subdir as all packages reviewed are passed. For the test, I'll ask Spot to handle. Thanks.
rpmls patool-1.2-2.fc20.noarch.rpm -rw-r--r-- /etc/bash_completion.d/patool.bash-completion -rwxr-xr-x /usr/bin/patool -rw-r--r-- /usr/lib/python2.7/site-packages/Patool-1.2-py2.7.egg-info -rw-r--r-- /usr/lib/python2.7/site-packages/_Patool_configdata.py -rw-r--r-- /usr/lib/python2.7/site-packages/_Patool_configdata.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/_Patool_configdata.pyo drwxr-xr-x /usr/lib/python2.7/site-packages/patoolib -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/__init__.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/__init__.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/__init__.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/configuration.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/configuration.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/configuration.pyo drwxr-xr-x /usr/lib/python2.7/site-packages/patoolib/programs -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/__init__.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/__init__.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/__init__.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/ar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/ar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/ar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/arc.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/arc.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/arc.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/archmage.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/archmage.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/archmage.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/arj.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/arj.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/arj.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bsdcpio.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bsdcpio.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bsdcpio.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bsdtar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bsdtar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bsdtar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bzip2.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bzip2.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/bzip2.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/cabextract.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/cabextract.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/cabextract.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/chmlib.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/chmlib.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/chmlib.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/clzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/clzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/clzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/compress.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/compress.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/compress.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/cpio.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/cpio.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/cpio.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/dpkg.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/dpkg.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/dpkg.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/flac.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/flac.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/flac.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/genisoimage.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/genisoimage.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/genisoimage.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/gzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/gzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/gzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/isoinfo.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/isoinfo.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/isoinfo.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lbzip2.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lbzip2.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lbzip2.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lcab.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lcab.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lcab.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lha.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lha.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lha.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lhasa.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lhasa.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lhasa.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lrzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lrzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lrzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzma.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzma.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzma.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzop.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzop.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/lzop.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/mac.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/mac.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/mac.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/nomarch.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/nomarch.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/nomarch.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/p7azip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/p7azip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/p7azip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/p7zip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/p7zip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/p7zip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pbzip2.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pbzip2.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pbzip2.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pdlzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pdlzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pdlzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pigz.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pigz.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/pigz.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/plzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/plzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/plzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_bz2.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_bz2.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_bz2.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_echo.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_echo.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_echo.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_gzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_gzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_gzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_lzma.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_lzma.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_lzma.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_tarfile.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_tarfile.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_tarfile.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_zipfile.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_zipfile.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/py_zipfile.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rpm.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rpm.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rpm.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rpm2cpio.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rpm2cpio.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rpm2cpio.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/rzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/shar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/shar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/shar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/shorten.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/shorten.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/shorten.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/star.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/star.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/star.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/tar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/tar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/tar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unace.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unace.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unace.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unadf.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unadf.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unadf.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unalz.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unalz.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unalz.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/uncompress.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/uncompress.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/uncompress.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unrar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unrar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unrar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unshar.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unshar.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unshar.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unzip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unzip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/unzip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/xdms.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/xdms.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/xdms.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/xz.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/xz.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/xz.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zip.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zip.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zip.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zoo.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zoo.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zoo.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zopfli.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zopfli.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/programs/zopfli.pyo -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/util.py -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/util.pyc -rw-r--r-- /usr/lib/python2.7/site-packages/patoolib/util.pyo drwxr-xr-x /usr/share/doc/patool-1.2 -rw-r--r-- /usr/share/doc/patool-1.2/COPYING -rw-r--r-- /usr/share/doc/patool-1.2/README.txt -rw-r--r-- /usr/share/doc/patool-1.2/changelog.txt -rw-r--r-- /usr/share/man/man1/patool.1.gz
Since this program only natively handles TAR, ZIP, BZIP2 and GZIP, and relies on external helper applications for all the other formats, it should be fine, even if some of those helper applications are non-free (and thus, not in Fedora). Might be a bit confusing to the user when those formats do not work because of the absence of some helper applications, but I would imagine the code handles that gracefully.
(In reply to Christopher Meng from comment #7) > (In reply to Antonio Trande from comment #6) > Do we need to include the subdir? Many packages only contain the toplevel > one. I don't think we need to include the subdir as all packages reviewed > are passed. I know but in comment #2 I wrote: "I prefer to list them (all dirs/files) explicitely in '%files' section." However, do as you please. :)
Is there any news?
Yes, after communicating with upstream he said that he cannot run the test, too. I found there are errors in test, if I don't make test and everything will be OK. Besides these days I'm waiting for its new version. Spec URL: http://cicku.me/patool.spec SRPM URL: http://cicku.me/patool-1.3-1.fc20.src.rpm
(Quote from Tom Callaway in comment #9) > Since this program only natively handles TAR, ZIP, BZIP2 and GZIP, and > relies on external helper applications for all the other formats, it should > be fine, even if some of those helper applications are non-free (and thus, > not in Fedora). Might be a bit confusing to the user when those formats do > not work because of the absence of some helper applications, but I would > imagine the code handles that gracefully. (In reply to Christopher Meng) > I found there are errors in test, if I don't make test and everything will be > OK. We can also bypass all tests but, impartially, patool needs of some non-free helper applications to work: $ patool --verbose test t.rar patool: Testing t.rar ... patool error: error testing t.rar: could not find an executable program to test format rar; candidates are (rar,unrar,7z), $ patool --verbose test t.ace patool: Testing t.ace ... patool error: error testing t.ace: could not find an executable program to test format ace; candidates are (unace), In Fedora, package description is partially mistaken: patool cannot manage ACE (.ace) and RAR (.rar) completely, unless user installs some other non-free packages from external non-free repos. Neither we can annotate in %description section like "install these others non-free applications to ...". Do all users realize of which applications they need in way to use patool in its entirety ? :) In my opinion, better choice should be to propose 'patool' in RPMFusion.
(In reply to Antonio Trande from comment #13) [omit] Agree. Closed.