Red Hat Bugzilla – Bug 983052
[PATCH] gogoc linux.sh template scrapes ifconfig output improperly
Last modified: 2013-07-21 20:35:14 EDT
Created attachment 771562 [details]
Patch for template/linux.sh to correctly scrape ifconfig output
Description of problem:
The gogoc client runs a script /etc/gogoc/template/linux.sh to configure the network upon successfully authenticating to the tunnelbroker. This script parses the output of ifconfig to determine configured interface addresses and adjust them accordingly. However, its assumptions about the format of ifconfig output are out of date, causing the script to fail before completion.
The attached patch properly scrapes the output of ifconfig, so that valid command invocations are constructed from the results.
Version-Release number of selected component (if applicable):
Note that the scraping has actually been broken since the ifconfig format changed in Fedora 17 (and this breakage predicted at the time) — see rhbz #784314. However, I suspect the ifconfig command was previously more input-tolerant, for instance accepting 'ifconfig tun del ip:v6:addr' commands without a prefix length, so the broken scraping was still "good enough". This is no longer true in some cases, and anyway it makes sense that gogoc handle the current format completely and correctly.
Thank you for reporting, I've checked your patch and seems correct.
gogoc-1.2-26.fc19 has been submitted as an update for Fedora 19.
Agreed, I downloaded & installed the gogoc-1.2-26.fc19 build and everything looks good. Thanks!
gogoc-1.2-26.fc18 has been submitted as an update for Fedora 18.
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gogoc-1.2-26.fc19'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
gogoc-1.2-26.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
gogoc-1.2-26.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.