Description of problem: In the past, cartridges were installed on nodes via RPM %post. This turned out to be unreliable for important edge cases. The install was moved to %posttrans, which solved the edge cases, but shares the same fundamental flaw as %post: the install occurs outside the RPM transaction, and any failure during the install is considered non-fatal to the overall RPM transaction. This is dangerous, because cartridge installation failure (via oo-admin-cartridge) is absolutely fatal to the RPM installation: if the cartridge installation fails, the node is invalid for use for the failed cartridge. Failure to install a cartridge into the cartridge repository during RPM installation must be fatal to the RPM installation, or must somehow be detected during node validation. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
*** Bug 986080 has been marked as a duplicate of this bug. ***
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/bf24961cc7a20d705a2eb51af45805384f137177 Bug 985514 - Update CartridgeRepository when mcollectived restarted * Remove all oo-admin-cartridge calls from spec files
Commit pushed to master at https://github.com/openshift/li https://github.com/openshift/li/commit/9382e34ba1e1d6e0051b8f3adc915cb46c461b7e Bug 985514 - Update CartridgeRepository when mcollectived restarted * Remove all oo-admin-cartridge calls from spec files
Verified on devenv-stage_435, with following steps 1. Launch devenv-stage_424. 2. Backup the cartridge_repository for compare #mkdir ~/repo #cp -r /var/lib/openshift/.cartridge_repository ~/repo 3. Update the cartridge to latest version #yum update openshift-origin-cartridge* 4. Review the cartridge repository #diff -r repo/ /var/lib/openshift/.cartridge_repository/ 5. Update the mcollective and restart it #yum update openshift-origin-msg-node-mcollective.noarch #service mcollective restart 6. Review the cartridge repository again #diff -r repo/ /var/lib/openshift/.cartridge_repository/ The changes reflect in step6 but do not reflect in step4. Move bug to verified.
*** Bug 988133 has been marked as a duplicate of this bug. ***