I'm closing this review request, because there are some missing (unpackaged) dependencies, which I didn't notice because somehow I had them on my machine.  I'll work on packaging them first, then reopen this review request.

Thanks!
Eric

Hi, 

Don't close a bug unless it's stalled or invalid. 

Please package the dependencies and use "depends on" to mark them. 

Anyway, I'll leave this bug as NotReady in whiteboard.

I closed it because I didn't think it likely that I'd be able to package the missing dependencies any time soon, so I considered it stalled.  However, as it happens, I actually have been able to get the missing dependencies packaged and submitted for review.

Spec URL: http://fedorapeople.org/~brouhaha/weasyprint/weasyprint.spec
SRPM URL: http://fedorapeople.org/~brouhaha/weasyprint/weasyprint-0.19.2-2.fc19.src.rpm

Depends on copending reviews of:

python-cairocffi  #986715
python-pyphen     #986634
python-tinycss    #986630

and indirectly on python-cffi and python-pycparser.

It is not clear to me from the Fedora Package Review Process document whether I should remove the "NotReady" from the Whiteboard if the package to be reviewed is dependent on other packages which have not yet been reviewed.

(In reply to Eric Smith from comment #3)
> It is not clear to me from the Fedora Package Review Process document
> whether I should remove the "NotReady" from the Whiteboard if the package to
> be reviewed is dependent on other packages which have not yet been reviewed.

You can clear NotReady since the package can be reviewed and imported even if the requisites aren't yet included in Fedora. The thing is that you just can't build the package before the requisites are there.

All the prerequisites have been approved and submitted for updates, there are koji buildroot overrides, and koji scratch builds have succeeded for rawhide, f19, f18, and epel6.

cairocffi is absent.

I'll handle this in the next week.

Absent? The python-cairocffi update is submitted and there is a koji build root override in place, so weasyprint builds successfully in koji.

Next week is fine. Thanks for reviewing!
Eric

Package is fine, only one question:

tests/test_web/run.py:#!/usr/bin/env python

In the past I think we shouldn't let env works, we should use /usr/bin/python. But can you tell me if this time is OK?

Spec URL: http://fedorapeople.org/~brouhaha/weasyprint/weasyprint.spec
SRPM URL: http://fedorapeople.org/~brouhaha/weasyprint/weasyprint-0.19.2-3.fc19.src.rpm

I'm not sure whether the policy on /usr/bin/env was actually adopted, but I've updated the spec to eliminate both uses of it.  Thanks!

APPROVED.

New Package SCM Request
=======================
Package Name: weasyprint
Short Description: Utility and Python library to render HTML and CSS to PDF
Owners: brouhaha
Branches: f18 f19 el6
InitialCC:

Git done (by process-git-requests).

weasyprint-0.19.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/weasyprint-0.19.2-3.fc19

weasyprint-0.19.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/weasyprint-0.19.2-3.fc18

weasyprint-0.19.2-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/weasyprint-0.19.2-3.el6

weasyprint-0.19.2-3.fc19 has been pushed to the Fedora 19 testing repository.

weasyprint-0.19.2-3.fc19 has been pushed to the Fedora 19 stable repository.

weasyprint-0.19.2-3.fc18 has been pushed to the Fedora 18 stable repository.

weasyprint-0.19.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

Package Change Request
======================
Package Name: weasyprint
New Branches: epel7
Owners: brouhaha

Git done (by process-git-requests).

weasyprint-0.22-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/weasyprint-0.22-1.el7

weasyprint-0.22-1.el7 has been pushed to the Fedora EPEL 7 stable repository.