Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-1.fc19.src.rpm Description: Pyphen is a pure Python module to hyphenate text using existing hyphenation dictionaries, e.g., from Libreoffice language packs. Fedora Account System Username: brouhaha
Issues: 1. Please use https://pypi.python.org/packages/source/P/Pyphen/Pyphen-0.7.tar.gz as Source0. 2. In %files section, you shouldn't use glob too much, and so you've missed a unowned dir, so %{python_sitelib}/* should be: %{python_sitelib}/pyphen %{python_sitelib}/Pyphen-%{version}-py%{python_version}.egg-info 3. I'm not sure about Requires: hyphen-en Can we let yum-langpack to choose the appropriate lang?
Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-2.fc19.src.rpm Thanks for reviewing! 1. I prefer to keep github Source0 for reasons we've discussed in other package reviews. If you feel strongly that this needs to change, let me know, and I'll do it. 2. I don't understand what you mean by "missed a unowned dir"; the output of "rpm -qlvp" looks good to me. It contains (and owns) the directory, the directory contents, and the egg-info, and doesn't appear to contain anything it shouldn't. In fact, timestamps aside, I get exactly the same listing whether I use my original files section or the one you propose. However, I've made the change. (If we didn't use a BuildRoot, it certainly wouldn't work to glob all of python_sitelib, but with a BuildRoot there doesn't seem to be any issue with it, and it appears that a lot of RPMs of Python libraries do that.) 3. The purpose of requiring hyphen-en is that I want to add a %check section that does a subset of the upstream unit tests, and wanted to have one language available for that. However, I haven't added that yet, and it would be a BuildRequires rather than a Requires, so I've dropped the Requires.
Eric, rest assured, %{python_sitelib}/* is an entirely valid way to include _anything_ in the %{python_sitelib} dir without introducing unowned directories.
Chris, what further info is needed? I changed the Files section per your request, even though it has been confirmed as unnecessary.
I need URLs......
I posted the updated URLs at the top of comment 2 above, but here they are again: Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-2.fc19.src.rpm
BTW does it support py3? If so please update again... ;)
Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-3.fc19.src.rpm
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: python-pyphen Short Description: Pure Python module to hyphenate text Owners: brouhaha Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
python-pyphen-0.7-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pyphen-0.7-3.fc19
python-pyphen-0.7-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pyphen-0.7-3.fc18
python-pyphen-0.7-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-pyphen-0.7-3.el6
python-pyphen-0.7-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-pyphen-0.7-3.fc19 has been pushed to the Fedora 19 stable repository.
python-pyphen-0.7-3.fc18 has been pushed to the Fedora 18 stable repository.
python-pyphen-0.7-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: python-pyphen New Branches: epel7 Owners: brouhaha