Bug 987823 - Do not ship the Playground repo
Summary: Do not ship the Playground repo
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER2
: 6.0.0
Assignee: Maciej Swiderski
QA Contact: Lukáš Petrovický
URL:
Whiteboard:
Depends On:
Blocks: 988037
TreeView+ depends on / blocked
 
Reported: 2013-07-24 08:52 UTC by Lukáš Petrovický
Modified: 2014-08-06 20:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 988037 (view as bug list)
Environment:
Last Closed: 2014-08-06 20:15:52 UTC
Type: Enhancement
Embargoed:


Attachments (Terms of Use)
standalone.sh (9.75 KB, application/x-shellscript)
2013-08-15 02:37 UTC, Ryan Zhang
no flags Details
server.log (388.25 KB, text/x-log)
2013-08-15 02:41 UTC, Ryan Zhang
no flags Details

Description Lukáš Petrovický 2013-07-24 08:52:45 UTC
At the moment, kie-ide has a hardcoded playground Git project. There is a wide agreement that we shouldn't ship any such repository, so I kindly ask for this to be removed in the productized version.

Comment 2 Maciej Swiderski 2013-07-31 16:40:17 UTC
Load of playground repos has been disabled by default (only for hosted mode and jbpm installer it is enabled). Here are commits for this change:

kie-wb
https://github.com/droolsjbpm/kie-wb-distributions/commit/514100d036691c87622665ba942300c6457ee0f1

jbpm-console-ng
https://github.com/droolsjbpm/jbpm-console-ng/commit/2e5fd1592f88e549613fdee10caca0523cf6c7f6

jbpm
https://github.com/droolsjbpm/jbpm/commit/b8082002e38a525c173236bbc85d210ed0d2f9e6

When running on application server it can be easily enabled by setting system property as follows:
- for jbpm console use: -Dorg.jbpm.console.demo=true
- for kie-wb use: -Dorg.kie.wb.demo=true
- for kie-drools-wb use: -Dorg.kie.droolswb.demo=true 

Since that disables both Group and Repository load it means there will be nothing available (from authoring point of view) when application starts, to setup initial group/repository kie-config-cli tool can be used to bootstrap system repository.

Comment 3 Maciej Swiderski 2013-08-05 17:32:32 UTC
based on discussion slight change was applied to make the playground enabled by default with possibility to disable it via system property. In addition property names were unified to single one:
org.kie.demo

To disable it set system property to false:
-Dorg.kie.demo=false

that will disable completely playground repository load.

Commits:
https://github.com/droolsjbpm/kie-wb-distributions/commit/1ea861bf7c3ca85bbebead2a8f674124ae201a88

https://github.com/droolsjbpm/jbpm-console-ng/commit/7c5643c3bb822f3097ccf63b52e4417f55a98830

Comment 4 Ryan Zhang 2013-08-15 02:37:54 UTC
Created attachment 786758 [details]
standalone.sh

Comment 5 Ryan Zhang 2013-08-15 02:40:02 UTC
I tried this on "sync.2013.08.07".
I added system property -Dorg.kie.demo=false, but the playground is still installed.
Attached standalone.sh and server.log.
Move to Assigned status for investigation.

Comment 6 Ryan Zhang 2013-08-15 02:41:04 UTC
Created attachment 786759 [details]
server.log

Comment 7 Maciej Swiderski 2013-08-15 09:01:15 UTC
Ryan, did you remove .niogit folder from previous installations? As it might be it is still present there so kie-wb does not need to load it from remote and just uses what has already been there.

Comment 8 Ryan Zhang 2013-08-20 07:41:20 UTC
Yes, I tried with removing .niogit folder and the jbpm-playground still appeared.

And beside this, for requirement of the product, we can't modifiy the standalone.sh of EAP.
May I suggest that we keep this option inside the war.

For example, we have an properties.file inside the kie-wb.war that we can patch easily from "false" to "true".

Comment 10 Lukáš Petrovický 2013-09-02 14:48:24 UTC
Repo is still shipped in ER2, but is disabled by default. Since this is the intended behavior, VERIFIED.


Note You need to log in before you can comment on or make changes to this bug.