Description of problem:
cap-get-file should not return error when the file has no capabilities, it's not grace. it's better do a further process to return NULL likes linux original command "getcap"
Version-Release number of selected component (if applicable):
Steps to Reproduce:
# guestfish -N fs -m /dev/sda1 touch /testfile : cap-get-file /testfile
libguestfs: error: cap_get_file: /testfile: No data available
guestfish return error
should return NULL
Same issue in rhel7(libguestfs1.22.4-2)
Fixed upstream in:
Author: Richard W.M. Jones <firstname.lastname@example.org>
Date: Mon Jul 29 14:37:50 2013 +0100
daemon: cap-get-file: Return empty string if no capability on file (RHBZ#989356).
Return an empty string (instead of an error) if no capabilities are
set on a file, and document that in the API.
Verified with libguestfs-1.20.10-2.el6.x86_64,
1. check the return
[root@intel-8400-8-2 home]# guestfish -N fs -m /dev/sda1 touch /testfile : cap-get-file /testfile
2. check document
[root@intel-8400-8-2 home]# guestfish
Welcome to guestfish, the libguestfs filesystem interactive shell for
editing virtual machine filesystems.
Type: 'help' for help on commands
'man' to read the manual
'quit' to quit the shell
><fs> help cap-get-file
cap-get-file - get the Linux capabilities attached to a file
This function returns the Linux capabilities attached to "path". The
capabilities set is returned in text form (see cap_to_text(3)).
If no capabilities are attached to a file, an empty string is returned.
So change the status to verified
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.