RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 989356 - cap-get-file will return error if the file has not be set capabilities
Summary: cap-get-file will return error if the file has not be set capabilities
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libguestfs
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 989352
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-07-29 06:48 UTC by bfan
Modified: 2014-06-18 02:00 UTC (History)
2 users (show)

Fixed In Version: libguestfs-1.22.5-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of: 989352
Environment:
Last Closed: 2014-06-13 12:42:10 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description bfan 2013-07-29 06:48:54 UTC
+++ This bug was initially created as a clone of Bug #989352 +++

Description of problem:
cap-get-file should not return error when the file has no capabilities, it's not grace. it's better do a further process to return NULL likes linux original command "getcap"


Version-Release number of selected component (if applicable):
libguestfs-1.20.9-6.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
# guestfish -N fs -m /dev/sda1 touch /testfile : cap-get-file /testfile
libguestfs: error: cap_get_file: /testfile: No data available


Actual results:
guestfish return error


Expected results:
should return NULL


Additional info:
Same issue in rhel7(libguestfs1.22.4-2)


B.R
Fan Bo

Comment 1 Richard W.M. Jones 2013-07-29 13:28:38 UTC
Upstream 'getcap' utility (part of libcap) has the following code:

    cap_d = cap_get_file(fname);
    if (cap_d == NULL) {
        if (errno != ENODATA) {
            fprintf(stderr, "Failed to get capabilities of file `%s' (%s)\n",
                    fname, strerror(errno));
        } else if (verbose) {
            printf("%s\n", fname);
        }
        return 0;
    }

In other words, it's programmed to ignore the ENODATA error.

I will make a corresponding change to libguestfs.

Comment 4 bfan 2013-12-03 06:55:08 UTC
Verified with libguestfs-1.22.6-16.el7.x86_64

# guestfish -N fs -m /dev/sda1 touch /testfile : cap-get-file /testfile

#

It returns Null, that's what we expect.

Comment 5 Ludek Smid 2014-06-13 12:42:10 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.