+++ This bug was initially created as a clone of Bug #989352 +++ Description of problem: cap-get-file should not return error when the file has no capabilities, it's not grace. it's better do a further process to return NULL likes linux original command "getcap" Version-Release number of selected component (if applicable): libguestfs-1.20.9-6.el6.x86_64 How reproducible: 100% Steps to Reproduce: # guestfish -N fs -m /dev/sda1 touch /testfile : cap-get-file /testfile libguestfs: error: cap_get_file: /testfile: No data available Actual results: guestfish return error Expected results: should return NULL Additional info: Same issue in rhel7(libguestfs1.22.4-2) B.R Fan Bo
Upstream 'getcap' utility (part of libcap) has the following code: cap_d = cap_get_file(fname); if (cap_d == NULL) { if (errno != ENODATA) { fprintf(stderr, "Failed to get capabilities of file `%s' (%s)\n", fname, strerror(errno)); } else if (verbose) { printf("%s\n", fname); } return 0; } In other words, it's programmed to ignore the ENODATA error. I will make a corresponding change to libguestfs.
Upstream fix: https://github.com/libguestfs/libguestfs/commit/c663ab3bb9ab02fb3ca6209333c2d5402081c4de
Verified with libguestfs-1.22.6-16.el7.x86_64 # guestfish -N fs -m /dev/sda1 touch /testfile : cap-get-file /testfile # It returns Null, that's what we expect.
This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request.