Spec URL: http://jgrulich.fedorapeople.org/okteta.spec SRPM URL: http://jgrulich.fedorapeople.org/okteta-4.10.97-1.fc19.src.rpm.part Description: Okteta is a binary/hex editor for KDE Fedora Account System Username: jgrulich This package was retired, because Okteta was part of kdeutils since KDE 4.1. Now it's again separately. Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5777955
Wrong SRPM URL. Spec URL: http://jgrulich.fedorapeople.org/okteta.spec SRPM URL: http://jgrulich.fedorapeople.org/okteta-4.10.97-1.fc19.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in okteta See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/okteta See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in okteta-libs , okteta-devel [ ]: Package complies to the Packaging Guidelines [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2)", "LGPL (v2.1 or later)", "LGPL", "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/rdieter1/pkgs.fedoraproject.org/work/kdesdk/992985-okteta/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked when required Note: icons in okteta [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 163840 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: update-mime-database is invoked as required Note: mimeinfo files in: okteta [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: okteta-4.10.97-1.fc20.x86_64.rpm okteta-libs-4.10.97-1.fc20.x86_64.rpm okteta-devel-4.10.97-1.fc20.x86_64.rpm okteta.x86_64: W: non-executable-in-bin /usr/bin/struct2osd.sh 0644L okteta.x86_64: E: non-executable-script /usr/bin/struct2osd.sh 0644L /bin/bash okteta.x86_64: W: no-manual-page-for-binary okteta okteta-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment okteta-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment okteta-libs.x86_64: W: no-documentation okteta-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint okteta-libs okteta okteta-devel okteta-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment okteta-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1gui.so.0.8.1 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1gui.so.0.8.1 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1gui.so.0.8.1 /lib64/libQtSvg.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1gui.so.0.8.1 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1gui.so.0.8.1 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1gui.so.0.2.1 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1gui.so.0.2.1 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1gui.so.0.2.1 /lib64/libQtSvg.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1gui.so.0.2.1 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1gui.so.0.2.1 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2gui.so.0.2.0 /lib64/libQtSvg.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2gui.so.0.2.0 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2gui.so.0.2.0 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2gui.so.0.2.0 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2gui.so.0.2.0 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libQtScriptTools.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libQtNetwork.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libQtSvg.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1controllers.so.0.2.1 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libnepomukutils.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libQtNetwork.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libQtXml.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libnepomuk.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libsoprano.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libQtSvg.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2controllers.so.0.2.0 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1core.so.0.2.1 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1core.so.0.2.1 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1core.so.0.2.1 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2okteta1core.so.0.2.1 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libQtNetwork.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libQtXml.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libQtSvg.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkasten2core.so.0.2.0 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1core.so.0.8.1 /lib64/libQtDBus.so.4 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1core.so.0.8.1 /lib64/libpthread.so.0 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1core.so.0.8.1 /lib64/libm.so.6 okteta-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libokteta1core.so.0.8.1 /lib64/libgcc_s.so.1 okteta-libs.x86_64: W: no-documentation okteta.x86_64: W: non-executable-in-bin /usr/bin/struct2osd.sh 0644L okteta.x86_64: E: non-executable-script /usr/bin/struct2osd.sh 0644L /bin/bash okteta.x86_64: W: no-manual-page-for-binary okteta okteta-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 53 warnings. # echo 'rpmlint-done:' Requires -------- okteta-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtScript.so.4()(64bit) libQtScriptTools.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkasten2core.so.2()(64bit) libkasten2gui.so.2()(64bit) libkasten2okteta1core.so.1()(64bit) libkasten2okteta1gui.so.1()(64bit) libkcmutils.so.4()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkfile.so.4()(64bit) libkio.so.5()(64bit) libknewstuff3.so.4()(64bit) libkparts.so.4()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libnepomukutils.so.4()(64bit) libokteta1core.so.1()(64bit) libokteta1gui.so.1()(64bit) libpthread.so.0()(64bit) libsolid.so.4()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) okteta rtld(GNU_HASH) okteta (rpmlib, GLIBC filtered): /bin/sh libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSvg.so.4()(64bit) libQtXml.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkasten2controllers.so.2()(64bit) libkasten2core.so.2()(64bit) libkasten2gui.so.2()(64bit) libkasten2okteta1controllers.so.1()(64bit) libkasten2okteta1core.so.1()(64bit) libkasten2okteta1gui.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libkparts.so.4()(64bit) libm.so.6()(64bit) libnepomuk.so.4()(64bit) libnepomukutils.so.4()(64bit) libokteta1core.so.1()(64bit) libokteta1gui.so.1()(64bit) libpthread.so.0()(64bit) libsoprano.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) okteta-libs(x86-64) rtld(GNU_HASH) okteta-devel (rpmlib, GLIBC filtered): libkasten2controllers.so.2()(64bit) libkasten2core.so.2()(64bit) libkasten2gui.so.2()(64bit) libkasten2okteta1controllers.so.1()(64bit) libkasten2okteta1core.so.1()(64bit) libkasten2okteta1gui.so.1()(64bit) libokteta1core.so.1()(64bit) libokteta1gui.so.1()(64bit) okteta-libs(x86-64) Provides -------- okteta-libs: kdesdk-okteta-libs libkasten2controllers.so.2()(64bit) libkasten2core.so.2()(64bit) libkasten2gui.so.2()(64bit) libkasten2okteta1controllers.so.1()(64bit) libkasten2okteta1core.so.1()(64bit) libkasten2okteta1gui.so.1()(64bit) libokteta1core.so.1()(64bit) libokteta1gui.so.1()(64bit) okteta-libs okteta-libs(x86-64) okteta: kdesdk-okteta libkbytearrayedit.so()(64bit) okteta okteta(x86-64) okteta-devel: kdesdk-okteta-devel okteta-devel okteta-devel(x86-64) Unversioned so-files -------------------- okteta: /usr/lib64/kde4/libkbytearrayedit.so okteta: /usr/lib64/kde4/oktetapart.so okteta-libs: /usr/lib64/kde4/plugins/designer/oktetadesignerplugin.so Source checksums ---------------- http://download.kde.org/unstable/4.10.97/src/okteta-4.10.97.tar.xz : CHECKSUM(SHA256) this package : 157ce0b10b68186e774ab76f098eb3ee92088244f719901f20521b38a90d7773 CHECKSUM(SHA256) upstream package : 157ce0b10b68186e774ab76f098eb3ee92088244f719901f20521b38a90d7773 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --bug 992985 --mock-config fedora-rawhide-x86_64 In short, looks good, though probably ought to update main license tag to be: # KDE e.V. may determine that future GPL versions are accepted License: (GPLv2 or GPLv3) and GFDL and -libs, -devel: # KDE e.V. may determine that future LGPL versions are accepted License: LGPLv2 or LGPLv3 but we can haggle over that post-import. APPROVED.
Package Change Request ====================== Package Name: okteta New Branches: f18 f19 Owners: than rdieter jreznik kkofler ltinkl jgrulich InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: okteta New Branches: devel Owners: than rdieter jreznik kkofler ltinkl jgrulich InitialCC:
devel exists but is orphaned, take ownership in pkgdb.
I see no "take ownership" button as I'd expect, I only see this listed in pkgdb: collection: devel owner: orphan status: Deprecated Doesnt "Deprecated" mean retired?
It does, I have now un-retired it.
Imported
Package Change Request ====================== Package Name: okteta New Branches: epel7 Owners: jgrulich rdieter kkofler dvratil ltinkl rnovacek
Sorry, the additional branch is not needed. I could not find it, because the package was called before kdesdk-okteta.