RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 994141 - $dev->get_parent() can't get undef if there is no parent
Summary: $dev->get_parent() can't get undef if there is no parent
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: perl-Sys-Virt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Daniel Berrangé
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-06 14:55 UTC by Daniel Berrangé
Modified: 2015-05-14 17:33 UTC (History)
7 users (show)

Fixed In Version: perl-Sys-Virt-1.1.1-2.el7
Doc Type: Bug Fix
Doc Text:
Prior to this update, using the libvirt-tck utility to find the parent device of a node device with no parent incorrectly returned a "libvirt error code: 0" error message. Now, it is valid for the virNodeDeviceGetParent() function to return NULL if the parent device is nonexistent, and the error message is no longer displayed.
Clone Of: 908274
Environment:
Last Closed: 2014-06-13 12:39:32 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Daniel Berrangé 2013-08-06 14:55:17 UTC
+++ This bug was initially created as a clone of Bug #908274 +++

Description of problem:
When try to get parent of nodedev if there is no parent,libvirt-tck get error.


Version-Release number of selected component (if applicable):
libvirt-0.10.2-17.el6.x86_64
perl-Sys-Virt-0.10.2-5.el6.x86_64
kernel-2.6.32-348.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.348.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1.in libvirt-tck script,added
.....
my @nodelist = $conn->list_all_node_devices();
  foreach my $dev (@nodelist){
  my $parent = $dev->get_parent();
  diag $parent;
}
.....

Actual results:

libvirt error code: 0, message: Unknown problem



Expected results:
should return "undef"

Additional info:
the first item in nodelist is "computer",no parent.
use python interface can return "None".

--- Additional comment from Daniel Berrange on 2013-08-06 14:29:00 BST ---

commit 04470fa5412cbd04386c5c2e785e4672cc6e0e0f
Author: Daniel P. Berrange <berrange>
Date:   Tue Aug 6 14:23:55 2013 +0100

    Fix error handling for virNodeDeviceGetParent()
    
    It is valid for virNodeDeviceGetParent() to return NULL in the
    case where there is no parent device present.
    
    Signed-off-by: Daniel P. Berrange <berrange>

Comment 2 zhe peng 2013-08-26 06:05:33 UTC
verify with perl-Sys-Virt-1.1.1-2.el7.x86_64

step:
.....
my @nodelist = $conn->list_all_node_devices();
  foreach my $dev (@nodelist){
  my $parent = $dev->get_parent();
  diag $parent;
}
.....

output msg:
# parent ===== 
# parent ===== computer
# parent ===== computer
# parent ===== computer

no libvirt error occured. move to verified.

Comment 3 Ludek Smid 2014-06-13 12:39:32 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.