Bug 996446 - [Translation history dialog] The keyboard shortcut mistakenly work on the main translation editor
[Translation history dialog] The keyboard shortcut mistakenly work on the mai...
Status: CLOSED CURRENTRELEASE
Product: Zanata
Classification: Community
Component: Usability (Show other bugs)
3.0
Unspecified Unspecified
unspecified Severity urgent
: ---
: 3.1
Assigned To: Patrick Huang
Zanata-QA Mailling List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-13 03:58 EDT by Ding-Yi Chen
Modified: 2013-11-26 22:36 EST (History)
3 users (show)

See Also:
Fixed In Version: 3.1-SNAPSHOT (20130913-1232)
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 996398
Environment:
Last Closed: 2013-11-26 22:25:26 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ding-Yi Chen 2013-08-13 03:58:33 EDT
Description of problem:
When entering the comments in translation history dialog, the only keyboard shortcut that should work is:

  Control-Enter: Confirm rejection

Some input method may clash with "Esc" (Japanese input methods and ibus-chewing), so no shortcut for "Cancel".

However, keyboard shortcut like "Ctrl-Enter" are mistakenly apply on the "background" translation editor.


Version-Release number of selected component (if applicable):
Zanata version 3.0.0-alpha-2-SNAPSHOT (20130813-1420)

How reproducible:
Always

Steps to Reproduce:
1. Go to translation editor
2. Click translation history icon on any of the non-empty translation.
3. Click to focus on the "Add a comment" text area
4. Press Ctrl-Enter

Actual results:
Save as Translated as if the translation history dialog was not there.

Expected results:
Save the comment and close the review comment dialog.

Additional info:
This is similar to Bug 996398.
Comment 1 Patrick Huang 2013-09-05 22:04:41 EDT
https://github.com/zanata/zanata-server/pull/147
Comment 2 Sean Flanigan 2013-09-06 00:46:58 EDT
Do we need this fix in 3.0?
Comment 3 Ding-Yi Chen 2013-09-16 02:05:22 EDT
The Firefox bug is Bug 1008253
Comment 4 Ding-Yi Chen 2013-09-16 02:37:59 EDT
VERIFIED with Zanata version 3.1-SNAPSHOT (20130913-1232) with Chromium 27.0.1453.93.

And Firefox 17.0.8 without pressing Esc.


Note that Firefox still suffer from Bug 1008253.

Step to reproduce:
1. Go to translation editor view
2. Find or make a Translated message.
3. Click *History* icon on that message.
4. Type "Ok" in comment entry.
5. Press key "Escape"
6. Click *Add Comment*

Actual:
The comment is added, but comment counter is not updated.

Expected: 
The comment is added, and comment counter should be updated.


Additional Info:
The comment is in translation history though.
Comment 5 Sean Flanigan 2013-11-26 22:16:07 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 6 Sean Flanigan 2013-11-26 22:17:09 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 7 Sean Flanigan 2013-11-26 22:19:28 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 8 Sean Flanigan 2013-11-26 22:25:26 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 9 Sean Flanigan 2013-11-26 22:34:14 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.
Comment 10 Sean Flanigan 2013-11-26 22:36:24 EST
Closing VERIFIED bugs for Zanata versions <= 3.1.

Note You need to log in before you can comment on or make changes to this bug.