Red Hat Bugzilla – Bug 997129
oo-last-access script chokes on /etc/openshift/node.conf with only space in configuration line
Last modified: 2015-05-14 19:26:13 EDT
+++ This bug was initially created as a clone of Bug #995525 +++
Describe the issue:
When running oo-last-access from the command line, if the /etc/openshift/node.conf has a configuration line that contains only a space you get the following stack trace:
/usr/sbin/oo-last-access:134:in `block in source_file': undefined method `split' for nil:NilClass (NoMethodError)
from /usr/sbin/oo-last-access:127:in `foreach'
from /usr/sbin/oo-last-access:127:in `source_file'
from /usr/sbin/oo-last-access:151:in `block in <main>'
from /usr/sbin/oo-last-access:144:in `call'
from /usr/sbin/oo-last-access:144:in `single_instance'
from /usr/sbin/oo-last-access:150:in `<main>'
Suggestions for improvement:
--- Additional comment from RHEL Product and Program Management on 2013-08-09 11:58:43 EDT ---
Since this issue was entered in bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.
Commit pushed to master at https://github.com/openshift/origin-server
Bug 997129 - oo-last-access script chokes on /etc/openshift/node.conf with only space in configuration line
Brenton, Was the above commit the fix for this bug? Can we move it ON_QA?
Looks like it. Removed the cargo-culted parser code in favor of Config module.
Checked on devenv_4428, after add new line with only a space to node.conf, oo-last-access can work fine.