Created attachment 786960 [details] wrong icon Description of problem: Wrong favicon.ico (the icon displayed in the browser tab) is a green O (ovirt) instead of the RHEV one. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
need to push a patch that reverts http://gerrit.ovirt.org/#/c/10949/ in the rhev-3.3 downstream repository (that doesn't exist yet...).
Einav, This should be a part of the branding. We could store the icons in brand directories and then use some server config to serve the right brand's icon. Do you agree?
(In reply to Greg Sheremeta from comment #2) > Einav, > > This should be a part of the branding. We could store the icons in brand > directories and then use some server config to serve the right brand's icon. > > Do you agree? definitely, however AFAIU, it is not trivial to change the favicon to the entire web-server (we can set it per page, but I prefer not to do that). @Alex (branding owner) can elaborate.
Right now the favicon is served from: ovirt-engine/backend/manager/modules/root/src/main/webapp/favicon.ico There are some magic settings that somehow read this and use this as the default favicon. I did some research and I could not find any easy way of replacing that with the output of some code (in which case we could read a specific one from somewhere and use that). The only way I found of doing that is including a tag in the html that calls a particular url to retrieve the favicon. However that would require us to add that to every single html page we generate, which is not something we can guarantee very well. If someone knows how to replace the favicon on the fly besides including a tag in the output HTML I am all ears.
/favicon.ico is just where browsers know to look for the icon. But via server side magic, there are a few ways to conditionally serve other things. Two ideas come to mind -- urlredirect filter, or a plain old servlet. I poc'd both of these. See my draft patches here and let me know what you think. http://gerrit.ovirt.org/#/c/18199 (filter) http://gerrit.ovirt.org/#/c/18200 (servlet) The urlredirect would even call a function to determine a path. Very flexible.
Make that last sentence: The urlrewrite filter could even call a function to determine a path.
I would use the servlet and map it to /favicon.ico. That sounds like a really good solution to me. As we talked about you can probably map the branding servlet to it and make that work.