Red Hat Bugzilla – Bug 999554
No Quickstarts installation path validation
Last modified: 2014-09-03 00:57:16 EDT
There is no validation for quickstarts installation target dir.
I would suggest take over input validation from installation target dir:
- The target directory will be created.
- The directory already exists. Are you sure you want to install here and possibly overwrite existing files?
- This directory can not be written. Please choose another directory.
enter "//" as quickstarts target dir during installation
- actual: Could not crate directory Error message is shown during installation procedure
- expected: "This directory can not be written. Please choose another directory." message is shown on Quickstarts screen.
Fixed the logic error during validation of the quickstarts directory.
The quickstarts dir panel now prompts you to create a dir if it doesn't already exist. It also checks for write permissions and emits an appropriate error msg if the directory cannot be created or written to.
If it does not pass these validation checks, the user has to change his directory before continuing to the next installation panel.
See this commit for details:
There will be no ER8. Changing target release to EAP 6.2.
Hi, please move BZs to ON_QA once the issue is fixed and target release is available so I can verify it. Thanks
Verified on EAP 6.2.0 ER1
I found some issues regarding this one.
- select non-existing directory as a quickstarts target:
Message window is thrown, but it uses string from path validation:
<str id="TargetPanel.createdir" txt="A fresh Red Hat JBoss Enterprise Application Platform installation will be placed here: " />. It made sense in 6.1.1 where TargetPanel.createdir text was "The target directory will be created: ", but not in 6.2. We should create new string more related to quickstarts, or make TargetPanel.createdir string more general.
Once I click on cancel of first message dialog, another message window is thrown saying "The directory you have chosen either does not exist or is not valid". Second message dialog shouldn't be there.
For the issue with the incorrect string:
I have made the string for the directory creation more general:
"A new directory will be created here:"
See commit for details:
For the issue with the unnecessary dialog window:
Removing this requires modifying izpack and will be done next time izpack is built. I will update this BZ when this occurs.
I have opened a new BZ for this issue, since it's separate from the incorrect string and will likely not be fixed for the upcoming milestone:
Verified on EAP 6.2.0.ER3