Description of problem: Cannot cancel at the recipe set level over XML-RPC (or using bkr client). Version-Release number of selected component (if applicable): 0.14 Steps to Reproduce: 1. Cancel a recipe set using bkr: bkr job-cancel RS:1234 Actual results: XML-RPC fault: <type 'exceptions.NameError'>:global name 'self' is not defined Expected results: Recipe set is cancelled. Additional info: Aug 22 00:33:29 beaker-02 beaker-server[19870]: bkr.server.xmlrpccontroller ERROR Error handling XML-RPC method Aug 22 00:33:29 beaker-02 beaker-server[19870]: Traceback (most recent call last): Aug 22 00:33:29 beaker-02 beaker-server[19870]: File "/usr/lib/python2.6/site-packages/bkr/server/xmlrpccontroller.py", line 54, in RPC2 Aug 22 00:33:29 beaker-02 beaker-server[19870]: response = self.process_rpc(method,params) Aug 22 00:33:29 beaker-02 beaker-server[19870]: File "/usr/lib/python2.6/site-packages/bkr/server/xmlrpccontroller.py", line 43, in process_rpc Aug 22 00:33:29 beaker-02 beaker-server[19870]: response = obj(*params) Aug 22 00:33:29 beaker-02 beaker-server[19870]: File "<string>", line 3, in stop Aug 22 00:33:29 beaker-02 beaker-server[19870]: File "/usr/lib/python2.6/site-packages/turbogears/identity/conditions.py", line 249, in require Aug 22 00:33:29 beaker-02 beaker-server[19870]: return fn(self, *args, **kwargs) Aug 22 00:33:29 beaker-02 beaker-server[19870]: File "/usr/lib/python2.6/site-packages/bkr/server/task_actions.py", line 104, in stop Aug 22 00:33:29 beaker-02 beaker-server[19870]: if not task.can_stop(identity.current.user): Aug 22 00:33:29 beaker-02 beaker-server[19870]: File "/usr/lib/python2.6/site-packages/bkr/server/model.py", line 5034, in can_stop Aug 22 00:33:29 beaker-02 beaker-server[19870]: return self.job.can_stop(user) Aug 22 00:33:29 beaker-02 beaker-server[19870]: NameError: global name 'self' is not defined Typo in RecipeSet.can_stop, has sel as the first arg (instead of self).
Fixed as part of http://gerrit.beaker-project.org/#/c/2222
Verify: [root@dhcp-65-87 ~]# bkr job-cancel RS:2457 Cancelled RS:2457 [root@dhcp-65-87 ~]# bkr job-cancel RS:2457 Cancelled RS:2457 Version; [root@dhcp-65-87 ~]# rpm -qa | grep beaker beaker-redhat-0.1.54-1.el6eng.noarch beaker-0.14.1-1.git.180.8e142cb.el6eng.noarch beaker-lab-controller-addDistro-0.14.1-1.git.180.8e142cb.el6eng.noarch python-beaker-1.3.1-6.el6.noarch beaker-client-0.14.1-1.git.180.8e142cb.el6eng.noarch beaker-lab-controller-0.14.1-1.git.180.8e142cb.el6eng.noarch beaker-server-0.14.1-1.git.180.8e142cb.el6eng.noarch
*** Bug 1012345 has been marked as a duplicate of this bug. ***
Beaker 0.15 has been released.
This change has been nominated to be back ported to the 0.14 branch, to be released as part of the next maintenance release 0.14.2.
Adjusting target milestone to make the changes backported to 0.14.2 easier to identify. 0.15.0 has enough significant regressions that it shouldn't be used, so the change means that 0.15.1 can be effectively reidentified as the union of that tag and the 0.14.2 target milestone.
Initial set of backports missed the actual fix for this. Missing commit cherry picked here: http://gerrit.beaker-project.org/#/c/2425
Closing as addressed in Beaker 0.14.2.