Bug 999910 - Hook scripts for samba don't add default log file and log level in smb.conf
Summary: Hook scripts for samba don't add default log file and log level in smb.conf
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: scripts
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Raghavendra Talur
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 999921
TreeView+ depends on / blocked
 
Reported: 2013-08-22 11:11 UTC by Raghavendra Talur
Modified: 2014-04-17 11:46 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.5.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 999921 (view as bug list)
Environment:
Last Closed: 2014-04-17 11:46:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Raghavendra Talur 2013-08-22 11:11:04 UTC 
Description of problem:
Hook scripts for samba add entry in smb.conf for each volume.
However, they don't add default log file for the plugin.
In case of errors, this will lead to having no record of what went wrong
in the client process stack.


How reproducible:
Always
Comment 1 Anand Avati 2013-08-22 11:17:43 UTC 
REVIEW: http://review.gluster.org/5685 (extras/hookscripts: Add default logfile for glusterfs vfs plugin.) posted (#1) for review on master by Raghavendra Talur (rtalur)
Comment 2 Anand Avati 2013-08-22 18:47:25 UTC 
REVIEW: http://review.gluster.org/5685 (extras/hookscripts: Add default logfile for glusterfs vfs plugin.) posted (#2) for review on master by Anand Avati (avati)
Comment 3 Anand Avati 2013-08-22 19:50:06 UTC 
COMMIT: http://review.gluster.org/5685 committed in master by Anand Avati (avati) 
------
commit 00a73eb528c39b2d6d0ee2fce83e82c1c47db619
Author: Raghavendra Talur <rtalur>
Date:   Thu Aug 22 16:43:12 2013 +0530

    extras/hookscripts: Add default logfile for glusterfs vfs plugin.
    
    Glusterfs vfs plugin for samba makes call into gfapi which brings
    up complete client process stack of gluster. Not having default
    log file means not logging client process at all.
    
    This patch adds default logfile and loglevel for vfs plugin.
    
    Change-Id: Ie0fb6bbb445d6f3349fc35c713743094c0f08915
    BUG: 999910
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/5685
    Reviewed-by: Anand Avati <avati>
    Tested-by: Anand Avati <avati>
Comment 4 Niels de Vos 2014-04-17 11:46:16 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.